From: Hans de Goede <hdegoede@redhat.com>
To: "Rafael J . Wysocki" <rjw@rjwysocki.net>,
Mark Gross <markgross@kernel.org>,
Andy Shevchenko <andy@infradead.org>,
Wolfram Sang <wsa@the-dreams.de>,
Mika Westerberg <mika.westerberg@linux.intel.com>,
Daniel Scally <djrscally@gmail.com>,
Laurent Pinchart <laurent.pinchart@ideasonboard.com>,
Mauro Carvalho Chehab <mchehab@kernel.org>,
Liam Girdwood <lgirdwood@gmail.com>,
Mark Brown <broonie@kernel.org>,
Michael Turquette <mturquette@baylibre.com>,
Stephen Boyd <sboyd@kernel.org>
Cc: Hans de Goede <hdegoede@redhat.com>, Len Brown <lenb@kernel.org>,
linux-acpi@vger.kernel.org, platform-driver-x86@vger.kernel.org,
linux-kernel@vger.kernel.org,
Sakari Ailus <sakari.ailus@linux.intel.com>,
Kate Hsuan <hpa@redhat.com>,
linux-media@vger.kernel.org, linux-clk@vger.kernel.org
Subject: [PATCH v7 00/14] Add support for X86/ACPI camera sensor/PMIC setup with clk and regulator platform data
Date: Fri, 3 Dec 2021 11:28:43 +0100 [thread overview]
Message-ID: <20211203102857.44539-1-hdegoede@redhat.com> (raw)
Hi All,
Here is v7 of my patch-set adding support for camera sensor connected to a
TPS68470 PMIC on x86/ACPI devices.
Changes in v7:
- Drop "platform/x86: int3472: Enable I2c daisy chain" this workaround is
no longer necessary (the regulator code now takes care of this)
- Fix using PTR_ERR(data->clk) instead of PTR_ERR(rdev) to log an error
code in "regulator: Introduce tps68470-regulator driver"
Changes in v6:
- Add support for the VCM (Voice Coil Motor) controlling the focus of
the back/main sensor camera lens:
- Patch 3 and patches 13-15 are new patches for this
- While working on this I learned that the VIO regulator is an always on
regulator and must be configured at the same voltage as VSIO, the
tps68470-regulator driver and the constraints have been updated for this
- Addressed clk-tps68470 driver review-remarks
- Some minor tweaks based on review-remarks from Andy
- Add Andy's Reviewed-by to all patches which were also in v5
I'm quite happy with how this works now, so from my pov this is ready
for merging now.
Patch 2 and 3 already have acks for merging through another tree.
I believe the best way to merge this is that I create an IM branch with
patches 1-4 + 7-11 (with Rafael's ack for 1) and then the clk / regulator /
media maintainers merge my IM branch + their resp. patches
This assumes that Rafael does not foresee any conflicts caused by the few
small ACPI changes in patch 1. Rafael is this ok with you ? You did already
Ack patch 1 but IIRC that was not specifically for merging it through
another tree, may I have your ack for moving forward with this plan ?
Regards,
Hans
Hans de Goede (14):
ACPI: delay enumeration of devices with a _DEP pointing to an INT3472
device
i2c: acpi: Use acpi_dev_ready_for_enumeration() helper
i2c: acpi: Add i2c_acpi_new_device_by_fwnode() function
platform_data: Add linux/platform_data/tps68470.h file
regulator: Introduce tps68470-regulator driver
clk: Introduce clk-tps68470 driver
platform/x86: int3472: Split into 2 drivers
platform/x86: int3472: Add get_sensor_adev_and_name() helper
platform/x86: int3472: Pass tps68470_clk_platform_data to the
tps68470-regulator MFD-cell
platform/x86: int3472: Pass tps68470_regulator_platform_data to the
tps68470-regulator MFD-cell
platform/x86: int3472: Deal with probe ordering issues
media: ipu3-cio2: Defer probing until the PMIC is fully setup
media: ipu3-cio2: Call cio2_bridge_init() before anything else
media: ipu3-cio2: Add support for instantiating i2c-clients for VCMs
drivers/acpi/scan.c | 37 ++-
drivers/clk/Kconfig | 8 +
drivers/clk/Makefile | 1 +
drivers/clk/clk-tps68470.c | 261 ++++++++++++++++++
drivers/i2c/i2c-core-acpi.c | 22 +-
drivers/media/pci/intel/ipu3/cio2-bridge.c | 92 ++++++
drivers/media/pci/intel/ipu3/cio2-bridge.h | 16 +-
drivers/media/pci/intel/ipu3/ipu3-cio2-main.c | 10 +-
drivers/platform/x86/intel/int3472/Makefile | 9 +-
...lk_and_regulator.c => clk_and_regulator.c} | 2 +-
drivers/platform/x86/intel/int3472/common.c | 82 ++++++
.../{intel_skl_int3472_common.h => common.h} | 6 +-
...ntel_skl_int3472_discrete.c => discrete.c} | 51 ++--
.../intel/int3472/intel_skl_int3472_common.c | 106 -------
...ntel_skl_int3472_tps68470.c => tps68470.c} | 92 +++++-
drivers/platform/x86/intel/int3472/tps68470.h | 25 ++
.../x86/intel/int3472/tps68470_board_data.c | 145 ++++++++++
drivers/regulator/Kconfig | 9 +
drivers/regulator/Makefile | 1 +
drivers/regulator/tps68470-regulator.c | 201 ++++++++++++++
include/acpi/acpi_bus.h | 5 +-
include/linux/i2c.h | 17 +-
include/linux/mfd/tps68470.h | 11 +
include/linux/platform_data/tps68470.h | 35 +++
24 files changed, 1076 insertions(+), 168 deletions(-)
create mode 100644 drivers/clk/clk-tps68470.c
rename drivers/platform/x86/intel/int3472/{intel_skl_int3472_clk_and_regulator.c => clk_and_regulator.c} (99%)
create mode 100644 drivers/platform/x86/intel/int3472/common.c
rename drivers/platform/x86/intel/int3472/{intel_skl_int3472_common.h => common.h} (94%)
rename drivers/platform/x86/intel/int3472/{intel_skl_int3472_discrete.c => discrete.c} (91%)
delete mode 100644 drivers/platform/x86/intel/int3472/intel_skl_int3472_common.c
rename drivers/platform/x86/intel/int3472/{intel_skl_int3472_tps68470.c => tps68470.c} (56%)
create mode 100644 drivers/platform/x86/intel/int3472/tps68470.h
create mode 100644 drivers/platform/x86/intel/int3472/tps68470_board_data.c
create mode 100644 drivers/regulator/tps68470-regulator.c
create mode 100644 include/linux/platform_data/tps68470.h
--
2.33.1
next reply other threads:[~2021-12-03 10:29 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-12-03 10:28 Hans de Goede [this message]
2021-12-03 10:28 ` [PATCH v7 01/14] ACPI: delay enumeration of devices with a _DEP pointing to an INT3472 device Hans de Goede
2021-12-03 10:28 ` [PATCH v7 02/14] i2c: acpi: Use acpi_dev_ready_for_enumeration() helper Hans de Goede
2021-12-03 10:28 ` [PATCH v7 03/14] i2c: acpi: Add i2c_acpi_new_device_by_fwnode() function Hans de Goede
2021-12-03 10:28 ` [PATCH v7 04/14] platform_data: Add linux/platform_data/tps68470.h file Hans de Goede
2021-12-03 10:28 ` [PATCH v7 05/14] regulator: Introduce tps68470-regulator driver Hans de Goede
2021-12-03 10:28 ` [PATCH v7 06/14] clk: Introduce clk-tps68470 driver Hans de Goede
[not found] ` <20211210005710.2BB88C004DD@smtp.kernel.org>
2021-12-13 10:48 ` Hans de Goede
2021-12-03 10:28 ` [PATCH v7 07/14] platform/x86: int3472: Split into 2 drivers Hans de Goede
2021-12-03 10:28 ` [PATCH v7 08/14] platform/x86: int3472: Add get_sensor_adev_and_name() helper Hans de Goede
2021-12-03 10:28 ` [PATCH v7 09/14] platform/x86: int3472: Pass tps68470_clk_platform_data to the tps68470-regulator MFD-cell Hans de Goede
2021-12-03 10:28 ` [PATCH v7 10/14] platform/x86: int3472: Pass tps68470_regulator_platform_data " Hans de Goede
2021-12-03 10:28 ` [PATCH v7 11/14] platform/x86: int3472: Deal with probe ordering issues Hans de Goede
2021-12-03 10:28 ` [PATCH v7 12/14] media: ipu3-cio2: Defer probing until the PMIC is fully setup Hans de Goede
2021-12-03 10:28 ` [PATCH v7 13/14] media: ipu3-cio2: Call cio2_bridge_init() before anything else Hans de Goede
2021-12-03 10:28 ` [PATCH v7 14/14] media: ipu3-cio2: Add support for instantiating i2c-clients for VCMs Hans de Goede
2021-12-16 2:21 ` (subset) [PATCH v7 00/14] Add support for X86/ACPI camera sensor/PMIC setup with clk and regulator platform data Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20211203102857.44539-1-hdegoede@redhat.com \
--to=hdegoede@redhat.com \
--cc=andy@infradead.org \
--cc=broonie@kernel.org \
--cc=djrscally@gmail.com \
--cc=hpa@redhat.com \
--cc=laurent.pinchart@ideasonboard.com \
--cc=lenb@kernel.org \
--cc=lgirdwood@gmail.com \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-clk@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=markgross@kernel.org \
--cc=mchehab@kernel.org \
--cc=mika.westerberg@linux.intel.com \
--cc=mturquette@baylibre.com \
--cc=platform-driver-x86@vger.kernel.org \
--cc=rjw@rjwysocki.net \
--cc=sakari.ailus@linux.intel.com \
--cc=sboyd@kernel.org \
--cc=wsa@the-dreams.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).