From: Shawn Guo <shawnguo@kernel.org>
To: Adam Ford <aford173@gmail.com>, Lucas Stach <l.stach@pengutronix.de>
Cc: linux-arm-kernel@lists.infradead.org, tharvey@gateworks.com,
aford@beaconembedded.com, Sascha Hauer <s.hauer@pengutronix.de>,
Pengutronix Kernel Team <kernel@pengutronix.de>,
Fabio Estevam <festevam@gmail.com>,
NXP Linux Team <linux-imx@nxp.com>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] soc: imx: gpcv2: Enable vpumix/dispmix to wait for handshake
Date: Mon, 6 Dec 2021 08:45:50 +0800 [thread overview]
Message-ID: <20211206004549.GG4216@dragon> (raw)
In-Reply-To: <20211120194900.1309914-1-aford173@gmail.com>
Hi Lucas,
What's your take on this one?
Shawn
On Sat, Nov 20, 2021 at 01:49:00PM -0600, Adam Ford wrote:
> There is a comment in the code that states the driver needs to
> wait for the handshake, but it's only available when the bus
> has been enabled from the blk-ctrl. Since both the
> vpumix and dispmix are called from the blk-ctl, it seems
> reasonable to assume the bus is enabled. Add a bool to determine
> which power-domains are able to properly wait for this
> handshake and set the corresping boolean for the two domains
> activated by the blk-ctrl.
>
> Signed-off-by: Adam Ford <aford173@gmail.com>
>
> diff --git a/drivers/soc/imx/gpcv2.c b/drivers/soc/imx/gpcv2.c
> index 7b6dfa33dcb9..a957f7fff968 100644
> --- a/drivers/soc/imx/gpcv2.c
> +++ b/drivers/soc/imx/gpcv2.c
> @@ -204,6 +204,7 @@ struct imx_pgc_domain {
> const int voltage;
> const bool keep_clocks;
> struct device *dev;
> + bool blkctrl_bus_enabled;
> };
>
> struct imx_pgc_domain_data {
> @@ -282,17 +283,14 @@ static int imx_pgc_power_up(struct generic_pm_domain *genpd)
> domain->bits.hskreq, domain->bits.hskreq);
>
> /*
> - * ret = regmap_read_poll_timeout(domain->regmap, GPC_PU_PWRHSK, reg_val,
> - * (reg_val & domain->bits.hskack), 0,
> - * USEC_PER_MSEC);
> - * Technically we need the commented code to wait handshake. But that needs
> - * the BLK-CTL module BUS clk-en bit being set.
> - *
> - * There is a separate BLK-CTL module and we will have such a driver for it,
> - * that driver will set the BUS clk-en bit and handshake will be triggered
> - * automatically there. Just add a delay and suppose the handshake finish
> - * after that.
> + * blkctrl_bus_enabled implies that the GPC is being invoked from a blk-ctrl
> + * and not from a peripheral or other GPC power domain. The blk-ctrl is required
> + * to support the handshake.
> */
> + if (domain->blkctrl_bus_enabled)
> + ret = regmap_read_poll_timeout(domain->regmap, GPC_PU_PWRHSK, reg_val,
> + (reg_val & domain->bits.hskack), 0,
> + USEC_PER_MSEC);
> }
>
> /* Disable reset clocks for all devices in the domain */
> @@ -701,6 +699,7 @@ static const struct imx_pgc_domain imx8mm_pgc_domains[] = {
> },
> .pgc = BIT(IMX8MM_PGC_VPUMIX),
> .keep_clocks = true,
> + .blkctrl_bus_enabled = true,
> },
>
> [IMX8MM_POWER_DOMAIN_VPUG1] = {
> @@ -749,6 +748,7 @@ static const struct imx_pgc_domain imx8mm_pgc_domains[] = {
> },
> .pgc = BIT(IMX8MM_PGC_DISPMIX),
> .keep_clocks = true,
> + .blkctrl_bus_enabled = true,
> },
>
> [IMX8MM_POWER_DOMAIN_MIPI] = {
> --
> 2.32.0
>
next prev parent reply other threads:[~2021-12-06 1:04 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-11-20 19:49 [PATCH] soc: imx: gpcv2: Enable vpumix/dispmix to wait for handshake Adam Ford
2021-12-06 0:45 ` Shawn Guo [this message]
2021-12-06 9:10 ` Lucas Stach
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20211206004549.GG4216@dragon \
--to=shawnguo@kernel.org \
--cc=aford173@gmail.com \
--cc=aford@beaconembedded.com \
--cc=festevam@gmail.com \
--cc=kernel@pengutronix.de \
--cc=l.stach@pengutronix.de \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-imx@nxp.com \
--cc=linux-kernel@vger.kernel.org \
--cc=s.hauer@pengutronix.de \
--cc=tharvey@gateworks.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).