From: Jakub Kicinski <kuba@kernel.org>
To: Stefan Wahren <stefan.wahren@i2se.com>
Cc: "David S . Miller" <davem@davemloft.net>,
Rob Herring <robh+dt@kernel.org>, Andrew Lunn <andrew@lunn.ch>,
Michael Heimpold <michael.heimpold@in-tech.com>,
jimmy.shen@vertexcom.com, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org, devicetree@vger.kernel.org
Subject: Re: [PATCH RFC V2 3/4] net: introduce media selection IF_PORT_HOMEPLUG
Date: Mon, 6 Dec 2021 11:29:55 -0800 [thread overview]
Message-ID: <20211206112955.285b26b2@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com> (raw)
In-Reply-To: <1638623871-21805-4-git-send-email-stefan.wahren@i2se.com>
On Sat, 4 Dec 2021 14:17:50 +0100 Stefan Wahren wrote:
> Introduce a new media selection dedicated for HomePlug powerline
> communication. This allows us to use the proper if_port setting in
> HomePlug drivers.
>
> Suggested-by: Andrew Lunn <andrew@lunn.ch>
> Signed-off-by: Stefan Wahren <stefan.wahren@i2se.com>
I _think_ the IF_PORT API is an very ancient (Linux 2.2) way of
switching ports on early Ethernet cards. Isn't it? It predates
ethtool and all the modern interfaces. Quick grep seems to indicate
it's accessed only for old HW as well.
Do you have a use case for setting it?
> diff --git a/include/uapi/linux/netdevice.h b/include/uapi/linux/netdevice.h
> index f3770c5..0f1f536 100644
> --- a/include/uapi/linux/netdevice.h
> +++ b/include/uapi/linux/netdevice.h
> @@ -53,7 +53,8 @@ enum {
> IF_PORT_AUI,
> IF_PORT_100BASET,
> IF_PORT_100BASETX,
> - IF_PORT_100BASEFX
> + IF_PORT_100BASEFX,
> + IF_PORT_HOMEPLUG
> };
>
> /* hardware address assignment types */
next prev parent reply other threads:[~2021-12-06 19:30 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-12-04 13:17 [PATCH RFC V2 0/4] add Vertexcom MSE102x support Stefan Wahren
2021-12-04 13:17 ` [PATCH RFC V2 1/4] dt-bindings: add vendor Vertexcom Stefan Wahren
2021-12-04 13:17 ` [PATCH RFC V2 2/4] dt-bindings: net: add Vertexcom MSE102x support Stefan Wahren
2021-12-04 13:17 ` [PATCH RFC V2 3/4] net: introduce media selection IF_PORT_HOMEPLUG Stefan Wahren
2021-12-06 19:29 ` Jakub Kicinski [this message]
2021-12-08 16:55 ` Stefan Wahren
2021-12-04 13:17 ` [PATCH RFC V2 4/4] net: vertexcom: Add MSE102x SPI support Stefan Wahren
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20211206112955.285b26b2@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com \
--to=kuba@kernel.org \
--cc=andrew@lunn.ch \
--cc=davem@davemloft.net \
--cc=devicetree@vger.kernel.org \
--cc=jimmy.shen@vertexcom.com \
--cc=linux-kernel@vger.kernel.org \
--cc=michael.heimpold@in-tech.com \
--cc=netdev@vger.kernel.org \
--cc=robh+dt@kernel.org \
--cc=stefan.wahren@i2se.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).