From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6BF0CC433FE for ; Mon, 6 Dec 2021 14:39:53 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1344372AbhLFOnV (ORCPT ); Mon, 6 Dec 2021 09:43:21 -0500 Received: from frasgout.his.huawei.com ([185.176.79.56]:4213 "EHLO frasgout.his.huawei.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S245057AbhLFOnU (ORCPT ); Mon, 6 Dec 2021 09:43:20 -0500 Received: from fraeml709-chm.china.huawei.com (unknown [172.18.147.201]) by frasgout.his.huawei.com (SkyGuard) with ESMTP id 4J75dx3bmTz67Cqn; Mon, 6 Dec 2021 22:38:45 +0800 (CST) Received: from lhreml710-chm.china.huawei.com (10.201.108.61) by fraeml709-chm.china.huawei.com (10.206.15.37) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.20; Mon, 6 Dec 2021 15:39:49 +0100 Received: from localhost (10.202.226.41) by lhreml710-chm.china.huawei.com (10.201.108.61) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.20; Mon, 6 Dec 2021 14:39:48 +0000 Date: Mon, 6 Dec 2021 14:39:47 +0000 From: Jonathan Cameron To: Cosmin Tanislav CC: , Lars-Peter Clausen , Michael Hennerich , Rob Herring , , , Subject: Re: [PATCH v1 1/2] dt-bindings: iio: accel: add ADXL367 Message-ID: <20211206143934.000017b8@Huawei.com> In-Reply-To: <20211206105403.53049-1-cosmin.tanislav@analog.com> References: <20211206105403.53049-1-cosmin.tanislav@analog.com> Organization: Huawei Technologies Research and Development (UK) Ltd. X-Mailer: Claws Mail 4.0.0 (GTK+ 3.24.29; i686-w64-mingw32) MIME-Version: 1.0 Content-Type: text/plain; charset="US-ASCII" Content-Transfer-Encoding: 7bit X-Originating-IP: [10.202.226.41] X-ClientProxiedBy: lhreml746-chm.china.huawei.com (10.201.108.196) To lhreml710-chm.china.huawei.com (10.201.108.61) X-CFilter-Loop: Reflected Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, 6 Dec 2021 12:54:02 +0200 Cosmin Tanislav wrote: > The ADXL367 is an ultralow power, 3-axis MEMS accelerometer. > > The ADXL367 does not alias input signals to achieve ultralow power > consumption, it samples the full bandwidth of the sensor at all > data rates. Measurement ranges of +-2g, +-4g, and +-8g are available, > with a resolution of 0.25mg/LSB on the +-2 g range. > > In addition to its ultralow power consumption, the ADXL367 > has many features to enable true system level power reduction. > It includes a deep multimode output FIFO, a built-in micropower > temperature sensor, and an internal ADC for synchronous conversion > of an additional analog input. > > Signed-off-by: Cosmin Tanislav Hi Cosmin, Given how often we get patches later to add regulators for devices like these I'd like them supported from the start. I'm guessing it needs power, but how many supplies? I'm not sure as doesn't seem to be a public datasheet yet. > --- > .../bindings/iio/accel/adi,adxl367.yaml | 79 +++++++++++++++++++ > 1 file changed, 79 insertions(+) > create mode 100644 Documentation/devicetree/bindings/iio/accel/adi,adxl367.yaml > > diff --git a/Documentation/devicetree/bindings/iio/accel/adi,adxl367.yaml b/Docu`mentation/devicetree/bindings/iio/accel/adi,adxl367.yaml > new file mode 100644 > index 000000000000..1bf9e1602480 > --- /dev/null > +++ b/Documentation/devicetree/bindings/iio/accel/adi,adxl367.yaml > @@ -0,0 +1,79 @@ > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/iio/accel/adi,adxl367.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: Analog Devices ADXL367 3-Axis Digital Accelerometer > + > +maintainers: > + - Cosmin Tanislav > + > +description: | > + The ADXL367 is an ultralow power, 3-axis MEMS accelerometer. > + > + The ADXL367 does not alias input signals by to achieve ultralow power > + consumption, it samples the full bandwidth of the sensor at all > + data rates. Measurement ranges of +-2g, +-4g, and +-8g are available, > + with a resolution of 0.25mg/LSB on the +-2 g range. > + > + In addition to its ultralow power consumption, the ADXL367 > + has many features to enable true system level power reduction. > + It includes a deep multimode output FIFO, a built-in micropower > + temperature sensor, and an internal ADC for synchronous conversion > + of an additional analog input. > + https://www.analog.com/en/products/adxl367.html "We can't find that page". I guess this driver is running slightly ahead of the datasheet being made public. > + > +properties: > + compatible: > + enum: > + - adi,adxl367 > + > + reg: > + maxItems: 1 > + > + interrupts: > + maxItems: 1 spi-max-frequency: true to fix the issue Rob's bot reported. > + > +required: > + - compatible > + - reg > + - interrupts > + > +additionalProperties: false > + > +examples: > + - | > + #include > + #include > + > + i2c { > + #address-cells = <1>; > + #size-cells = <0>; > + > + adxl367@53 { > + compatible = "adi,adxl367"; > + reg = <0x53>; > + interrupt-parent = <&gpio>; > + interrupts = <25 IRQ_TYPE_EDGE_RISING>; > + }; > + }; > + - | > + #include > + #include > + > + spi { > + #address-cells = <1>; > + #size-cells = <0>; > + > + cs-gpios = <&gpio 17 GPIO_ACTIVE_LOW>; > + status = "okay"; We don't normally list status in example bindings. Also, the cs-gpio is part of the spi master binding so no need to have it here as we are showing how the actual device binding works. That should let you drop the gpio.h header. > + > + adxl367@0 { > + compatible = "adi,adxl367"; > + reg = <0>; > + spi-max-frequency = <1000000>; > + interrupt-parent = <&gpio>; > + interrupts = <25 IRQ_TYPE_EDGE_RISING>; > + }; > + };