From: Lorenzo Pieralisi <lorenzo.pieralisi@arm.com>
To: Bjorn Helgaas <helgaas@kernel.org>
Cc: "qizhong cheng" <qizhong.cheng@mediatek.com>,
"Ryder Lee" <ryder.lee@mediatek.com>,
"Jianjun Wang" <jianjun.wang@mediatek.com>,
"Krzysztof Wilczyński" <kw@linux.com>,
"Bjorn Helgaas" <bhelgaas@google.com>,
linux-pci@vger.kernel.org, linux-mediatek@lists.infradead.org,
linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org, chuanjia.liu@mediatek.com,
"Pali Rohár" <pali@kernel.org>, "Marc Zyngier" <maz@kernel.org>,
"Alyssa Rosenzweig" <alyssa@rosenzweig.io>,
"Mark Kettenis" <mark.kettenis@xs4all.nl>,
"Luca Ceresoli" <luca@lucaceresoli.net>
Subject: Re: [RESEND PATCH v2] PCI: mediatek: Delay 100ms to wait power and clock to become stable
Date: Tue, 7 Dec 2021 18:01:48 +0000 [thread overview]
Message-ID: <20211207180140.GA5938@lpieralisi> (raw)
In-Reply-To: <20211207175416.GA42725@bhelgaas>
On Tue, Dec 07, 2021 at 11:54:16AM -0600, Bjorn Helgaas wrote:
> [+cc Marc, Alyssa, Mark, Luca for reset timing questions]
>
> On Tue, Dec 07, 2021 at 04:41:53PM +0800, qizhong cheng wrote:
> > Described in PCIe CEM specification sections 2.2 (PERST# Signal) and
> > 2.2.1 (Initial Power-Up (G3 to S0)). The deassertion of PERST# should
> > be delayed 100ms (TPVPERL) for the power and clock to become stable.
> >
> > Signed-off-by: qizhong cheng <qizhong.cheng@mediatek.com>
> > Acked-by: Pali Roh�r <pali@kernel.org>
> > ---
> >
> > v2:
> > - Typo fix.
> > - Rewrap into one paragraph.
>
> 1) If you change something, even in the commit log or comments, it is
> a new version, not a "RESEND". A "RESEND" means "I sent this quite a
> while ago and didn't hear anything, so I'm sending the exact same
> thing again in case the first one got lost."
>
> 2) I suggested a subject line update, which apparently got missed.
> Here's a better one:
>
> PCI: mediatek: Assert PERST# for 100ms for power and clock to stabilize
>
> 3) Most importantly, this needs to be reconciled with the similar
> change to the apple driver:
>
> https://lore.kernel.org/r/20211123180636.80558-2-maz@kernel.org
>
> In the apple driver, we're doing:
>
> - Assert PERST#
> - Set up REFCLK
> - Sleep 100us (T_perst-clk, CEM r5 2.2, 2.9.2)
> - Deassert PERST#
> - Sleep 100ms (not sure there's a name? PCIe r5 6.6.1)
>
> But here in mediatek, we're doing:
>
> - Assert PERST#
> - Sleep 100ms (T_pvperl, CEM r5 2.2, 2.2.1, 2.9.2)
> - Deassert PERST#
>
> My questions:
>
> - Where does apple enforce T_pvperl? I can't tell where power to
> the slot is turned on.
>
> - Where does mediatek enforce the PCIe sec 6.6.1 delay after
> deasserting PERST# and before config requests?
>
> - Does either apple or mediatek support speeds greater than 5 GT/s,
> and if so, shouldn't we start the sec 6.6.1 100ms delay *after*
> Link training completes?
I dropped this patch from my pci/mediatek branch, waiting for
clarification.
Thanks,
Lorenzo
> > drivers/pci/controller/pcie-mediatek.c | 7 +++++++
> > 1 file changed, 7 insertions(+)
> >
> > diff --git a/drivers/pci/controller/pcie-mediatek.c b/drivers/pci/controller/pcie-mediatek.c
> > index 2f3f974977a3..a61ea3940471 100644
> > --- a/drivers/pci/controller/pcie-mediatek.c
> > +++ b/drivers/pci/controller/pcie-mediatek.c
> > @@ -702,6 +702,13 @@ static int mtk_pcie_startup_port_v2(struct mtk_pcie_port *port)
> > */
> > writel(PCIE_LINKDOWN_RST_EN, port->base + PCIE_RST_CTRL);
> >
> > + /*
> > + * Described in PCIe CEM specification sections 2.2 (PERST# Signal) and
> > + * 2.2.1 (Initial Power-Up (G3 to S0)). The deassertion of PERST# should
> > + * be delayed 100ms (TPVPERL) for the power and clock to become stable.
> > + */
> > + msleep(100);
> > +
> > /* De-assert PHY, PE, PIPE, MAC and configuration reset */
> > val = readl(port->base + PCIE_RST_CTRL);
> > val |= PCIE_PHY_RSTB | PCIE_PERSTB | PCIE_PIPE_SRSTB |
> > --
> > 2.25.1
> >
next prev parent reply other threads:[~2021-12-07 18:02 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-12-07 8:41 [RESEND PATCH v2] PCI: mediatek: Delay 100ms to wait power and clock to become stable qizhong cheng
2021-12-07 17:54 ` Bjorn Helgaas
2021-12-07 18:01 ` Lorenzo Pieralisi [this message]
2021-12-07 21:00 ` Mark Kettenis
2021-12-08 4:12 ` Bjorn Helgaas
[not found] ` <e891bf625b00078c476cc53c4b8770dfce71ddb0.camel@mediatek.com>
2021-12-08 10:18 ` Pali Rohár
[not found] ` <6e6fd0b50699616e7d943ec1c8bc4e71abd85f6f.camel@mediatek.com>
2021-12-09 13:00 ` Pali Rohár
2021-12-09 15:59 ` Bjorn Helgaas
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20211207180140.GA5938@lpieralisi \
--to=lorenzo.pieralisi@arm.com \
--cc=alyssa@rosenzweig.io \
--cc=bhelgaas@google.com \
--cc=chuanjia.liu@mediatek.com \
--cc=helgaas@kernel.org \
--cc=jianjun.wang@mediatek.com \
--cc=kw@linux.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=linux-pci@vger.kernel.org \
--cc=luca@lucaceresoli.net \
--cc=mark.kettenis@xs4all.nl \
--cc=maz@kernel.org \
--cc=pali@kernel.org \
--cc=qizhong.cheng@mediatek.com \
--cc=ryder.lee@mediatek.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).