From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id DE151C433EF for ; Wed, 8 Dec 2021 01:55:25 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S243548AbhLHB6z (ORCPT ); Tue, 7 Dec 2021 20:58:55 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:38268 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S243382AbhLHB6j (ORCPT ); Tue, 7 Dec 2021 20:58:39 -0500 Received: from mail-pg1-x54a.google.com (mail-pg1-x54a.google.com [IPv6:2607:f8b0:4864:20::54a]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id A3274C061746 for ; Tue, 7 Dec 2021 17:55:07 -0800 (PST) Received: by mail-pg1-x54a.google.com with SMTP id x23-20020a634a17000000b003252e908ce3so456423pga.1 for ; Tue, 07 Dec 2021 17:55:07 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20210112; h=reply-to:date:in-reply-to:message-id:mime-version:references :subject:from:to:cc; bh=aSFkuCGEBTHTvZi9DSeJE23ynNu9ldCmJkWpDFHPYL4=; b=pj1BFS5JDZwdQsoV5ZfUR4IjugpB87psw0hdDXxPgq+MvLU0SnQUMVYqxy80OHAJMz h/HlENiyKKLI8u7Ab1qQ/zFZ0keBREMi7vKUUYCICeOYbPGxHfCaEbg6UHNMkziCJEDn ic8apfjbU4NgCtjM6YLR3j+K4NyNpQLhRlKKXjwqFT5ebNr5zvgY53H2I+VkERETd09z vjcLZXi9NO8+z9zFBak7kTFIzqI71zO2DdlXn/VAjhI6oztWbyjY0w6J/w0ongdSRJSQ A4SM8jHE5VE46ur/zAukww8n4VP2XB8Q0gthwSw3Lxsok8nXU/JcGwe97EQIklK6KtfX kiXg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:reply-to:date:in-reply-to:message-id :mime-version:references:subject:from:to:cc; bh=aSFkuCGEBTHTvZi9DSeJE23ynNu9ldCmJkWpDFHPYL4=; b=o5viXacgs8big5nozoW21Gj8gd6uy4MsnBHKC86VwABaI2esYrFCWCa+FEFGLaK4nb gWcw9QqX/qrPuP/gQUEr9xilpR9724SH82n3HXLp7eeLPDNxJhCN580Z5yULsSEiNYwZ P/kzrDh7d7hYgBCcTFWyuMlJfFJWLYUwPyNIjaNL5NJFVxydPnp8UFiAoyREZdw2eSGD KoHGTC/sM++11PMu1Wy9SB6d1b8EDDQ0Uydewy+yQYQ0rpl+RidSUWig+Cwc60WrFwXS XAixa1twY9jcduCUDmeESz92GYdKEb+f8a0OERMXQlg15CVDDjxVAwIzcEDJK45Loc+D EPZw== X-Gm-Message-State: AOAM532veNyFAlYXOJ+1qc83iAOGL0X0tTwapCg4cZ3tCzivGGQV3kiI H4DvqPCMgBix2oL9O6mby1noobdbHhE= X-Google-Smtp-Source: ABdhPJx+JTTqJ9FCS754xSjU5PQfNUcp7bYmDjWBmkUjGbJNupRxR6OWycRJ4EvS9kgqXp+3ZNsipA1oW9M= X-Received: from seanjc.c.googlers.com ([fda3:e722:ac3:cc00:7f:e700:c0a8:3e5]) (user=seanjc job=sendgmr) by 2002:a17:903:2055:b0:142:497c:a249 with SMTP id q21-20020a170903205500b00142497ca249mr55114947pla.35.1638928507106; Tue, 07 Dec 2021 17:55:07 -0800 (PST) Reply-To: Sean Christopherson Date: Wed, 8 Dec 2021 01:52:22 +0000 In-Reply-To: <20211208015236.1616697-1-seanjc@google.com> Message-Id: <20211208015236.1616697-13-seanjc@google.com> Mime-Version: 1.0 References: <20211208015236.1616697-1-seanjc@google.com> X-Mailer: git-send-email 2.34.1.400.ga245620fadb-goog Subject: [PATCH v3 12/26] KVM: SVM: Remove unnecessary APICv/AVIC update in vCPU unblocking path From: Sean Christopherson To: Paolo Bonzini , Joerg Roedel Cc: Sean Christopherson , Vitaly Kuznetsov , Wanpeng Li , Jim Mattson , Suravee Suthikulpanit , kvm@vger.kernel.org, iommu@lists.linux-foundation.org, linux-kernel@vger.kernel.org, Maxim Levitsky Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Remove handling of KVM_REQ_APICV_UPDATE from svm_vcpu_unblocking(), it's no longer needed as it was made obsolete by commit df7e4827c549 ("KVM: SVM: call avic_vcpu_load/avic_vcpu_put when enabling/disabling AVIC"). Prior to that commit, the manual check was necessary to ensure the AVIC stuff was updated by avic_set_running() when a request to enable APICv became pending while the vCPU was blocking, as the request handling itself would not do the update. But, as evidenced by the commit, that logic was flawed and subject to various races. Now that svm_refresh_apicv_exec_ctrl() does avic_vcpu_load/put() in response to an APICv status change, drop the manual check in the unblocking path. Suggested-by: Paolo Bonzini Signed-off-by: Sean Christopherson --- arch/x86/kvm/svm/avic.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/arch/x86/kvm/svm/avic.c b/arch/x86/kvm/svm/avic.c index 37575b71cdf3..16e4ebd980a2 100644 --- a/arch/x86/kvm/svm/avic.c +++ b/arch/x86/kvm/svm/avic.c @@ -1039,7 +1039,5 @@ void svm_vcpu_blocking(struct kvm_vcpu *vcpu) void svm_vcpu_unblocking(struct kvm_vcpu *vcpu) { - if (kvm_check_request(KVM_REQ_APICV_UPDATE, vcpu)) - kvm_vcpu_update_apicv(vcpu); avic_set_running(vcpu, true); } -- 2.34.1.400.ga245620fadb-goog