* [PATCH] Input: goodix - Fix memory leak in goodix_firmware_upload
@ 2021-12-08 17:33 José Expósito
2021-12-10 5:19 ` Dmitry Torokhov
0 siblings, 1 reply; 2+ messages in thread
From: José Expósito @ 2021-12-08 17:33 UTC (permalink / raw)
To: hdegoede
Cc: hadess, dmitry.torokhov, linux-input, linux-kernel,
José Expósito
Addresses-Coverity-ID: 1493934 ("Resource leak")
Signed-off-by: José Expósito <jose.exposito89@gmail.com>
---
drivers/input/touchscreen/goodix_fwupload.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/input/touchscreen/goodix_fwupload.c b/drivers/input/touchscreen/goodix_fwupload.c
index c1e7a2413078..191d4f38d991 100644
--- a/drivers/input/touchscreen/goodix_fwupload.c
+++ b/drivers/input/touchscreen/goodix_fwupload.c
@@ -207,7 +207,7 @@ static int goodix_firmware_upload(struct goodix_ts_data *ts)
error = goodix_reset_no_int_sync(ts);
if (error)
- return error;
+ goto release;
error = goodix_enter_upload_mode(ts->client);
if (error)
--
2.25.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] Input: goodix - Fix memory leak in goodix_firmware_upload
2021-12-08 17:33 [PATCH] Input: goodix - Fix memory leak in goodix_firmware_upload José Expósito
@ 2021-12-10 5:19 ` Dmitry Torokhov
0 siblings, 0 replies; 2+ messages in thread
From: Dmitry Torokhov @ 2021-12-10 5:19 UTC (permalink / raw)
To: José Expósito; +Cc: hdegoede, hadess, linux-input, linux-kernel
On Wed, Dec 08, 2021 at 06:33:21PM +0100, José Expósito wrote:
> Addresses-Coverity-ID: 1493934 ("Resource leak")
> Signed-off-by: José Expósito <jose.exposito89@gmail.com>
Applied, thank you.
--
Dmitry
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2021-12-10 5:19 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-12-08 17:33 [PATCH] Input: goodix - Fix memory leak in goodix_firmware_upload José Expósito
2021-12-10 5:19 ` Dmitry Torokhov
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).