* [PATCH] kernel/crash_core.c: No judgment required
@ 2021-12-10 3:20 lizhe
2021-12-14 16:32 ` Philipp Rudo
0 siblings, 1 reply; 5+ messages in thread
From: lizhe @ 2021-12-10 3:20 UTC (permalink / raw)
To: dyoung, bhe, vgoyal, sensor1010; +Cc: kexec, linux-kernel
No judgment required ck_cmdline is NULL
its caller has alreadly judged, see __parse_crashkernel
function
Signed-off-by: lizhe <sensor1010@163.com>
---
kernel/crash_core.c | 3 ---
1 file changed, 3 deletions(-)
diff --git a/kernel/crash_core.c b/kernel/crash_core.c
index eb53f5ec62c9..9981cf9b9fe4 100644
--- a/kernel/crash_core.c
+++ b/kernel/crash_core.c
@@ -221,9 +221,6 @@ static __init char *get_last_crashkernel(char *cmdline,
p = strstr(p+1, name);
}
- if (!ck_cmdline)
- return NULL;
-
return ck_cmdline;
}
--
2.25.1
^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [PATCH] kernel/crash_core.c: No judgment required
2021-12-10 3:20 [PATCH] kernel/crash_core.c: No judgment required lizhe
@ 2021-12-14 16:32 ` Philipp Rudo
2022-04-25 1:36 ` Baoquan He
0 siblings, 1 reply; 5+ messages in thread
From: Philipp Rudo @ 2021-12-14 16:32 UTC (permalink / raw)
To: lizhe; +Cc: dyoung, bhe, vgoyal, kexec, linux-kernel
Hi lizhe,
On Thu, 9 Dec 2021 19:20:03 -0800
lizhe <sensor1010@163.com> wrote:
> No judgment required ck_cmdline is NULL
> its caller has alreadly judged, see __parse_crashkernel
> function
>
> Signed-off-by: lizhe <sensor1010@163.com>
> ---
> kernel/crash_core.c | 3 ---
> 1 file changed, 3 deletions(-)
>
> diff --git a/kernel/crash_core.c b/kernel/crash_core.c
> index eb53f5ec62c9..9981cf9b9fe4 100644
> --- a/kernel/crash_core.c
> +++ b/kernel/crash_core.c
> @@ -221,9 +221,6 @@ static __init char *get_last_crashkernel(char *cmdline,
> p = strstr(p+1, name);
> }
>
> - if (!ck_cmdline)
> - return NULL;
> -
> return ck_cmdline;
> }
>
I agree that the if-block is not needed and can be removed. However, I
cannot follow your reasoning in the commit message. Could you please
explain it in more detail.
The reason why I think that the 'if' can be removed is that the
expression can only be true when ck_cmdline = NULL. But with that the
last three lines are equivalent to
if (!ck_cmdline)
return ck_cmdline;
return ck_cmdline;
Which simply doesn't make any sense.
Thanks
Philipp
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] kernel/crash_core.c: No judgment required
2021-12-14 16:32 ` Philipp Rudo
@ 2022-04-25 1:36 ` Baoquan He
[not found] ` <62058381.3b6e.1805f62c8f4.Coremail.sensor1010@163.com>
0 siblings, 1 reply; 5+ messages in thread
From: Baoquan He @ 2022-04-25 1:36 UTC (permalink / raw)
To: Philipp Rudo; +Cc: lizhe, dyoung, vgoyal, kexec, linux-kernel
On 12/14/21 at 05:32pm, Philipp Rudo wrote:
> Hi lizhe,
>
> On Thu, 9 Dec 2021 19:20:03 -0800
> lizhe <sensor1010@163.com> wrote:
>
> > No judgment required ck_cmdline is NULL
> > its caller has alreadly judged, see __parse_crashkernel
> > function
> >
> > Signed-off-by: lizhe <sensor1010@163.com>
> > ---
> > kernel/crash_core.c | 3 ---
> > 1 file changed, 3 deletions(-)
> >
> > diff --git a/kernel/crash_core.c b/kernel/crash_core.c
> > index eb53f5ec62c9..9981cf9b9fe4 100644
> > --- a/kernel/crash_core.c
> > +++ b/kernel/crash_core.c
> > @@ -221,9 +221,6 @@ static __init char *get_last_crashkernel(char *cmdline,
> > p = strstr(p+1, name);
> > }
> >
> > - if (!ck_cmdline)
> > - return NULL;
> > -
> > return ck_cmdline;
> > }
> >
>
> I agree that the if-block is not needed and can be removed. However, I
> cannot follow your reasoning in the commit message. Could you please
> explain it in more detail.
>
> The reason why I think that the 'if' can be removed is that the
> expression can only be true when ck_cmdline = NULL. But with that the
> last three lines are equivalent to
>
> if (!ck_cmdline)
> return ck_cmdline;
>
> return ck_cmdline;
>
> Which simply doesn't make any sense.
Right, the judgement actually introduces redundant codes. As Zhe
replied, maybe you can rewrite the log and repost with your
Signed-off-by, Philipp. As for Author, you two can discuss in private
mail.
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] kernel/crash_core.c: No judgment required
[not found] ` <62058381.3b6e.1805f62c8f4.Coremail.sensor1010@163.com>
@ 2022-04-26 8:17 ` Philipp Rudo
2022-04-26 8:20 ` Philipp Rudo
0 siblings, 1 reply; 5+ messages in thread
From: Philipp Rudo @ 2022-04-26 8:17 UTC (permalink / raw)
To: lizhe; +Cc: Baoquan He, dyoung, vgoyal, kexec, linux-kernel
Hi lizhe,
On Mon, 25 Apr 2022 14:22:31 +0800 (CST)
lizhe <sensor1010@163.com> wrote:
> HI :
>
>
> I found the problem at the first time and gave the solution,
>
>
>
>
> Pphilipp Rudo just saw the solution to the problem and gave an explanation.
> the author of this patch should only be me
right, I only commented on the patch you sent.
Could you please update the commit message and send a v2.
Thanks
Philipp
>
>
>
>
>
>
>
> lizhe
>
>
>
>
>
>
>
>
> At 2022-04-25 09:36:17, "Baoquan He" <bhe@redhat.com> wrote:
> >On 12/14/21 at 05:32pm, Philipp Rudo wrote:
> >> Hi lizhe,
> >>
> >> On Thu, 9 Dec 2021 19:20:03 -0800
> >> lizhe <sensor1010@163.com> wrote:
> >>
> >> > No judgment required ck_cmdline is NULL
> >> > its caller has alreadly judged, see __parse_crashkernel
> >> > function
> >> >
> >> > Signed-off-by: lizhe <sensor1010@163.com>
> >> > ---
> >> > kernel/crash_core.c | 3 ---
> >> > 1 file changed, 3 deletions(-)
> >> >
> >> > diff --git a/kernel/crash_core.c b/kernel/crash_core.c
> >> > index eb53f5ec62c9..9981cf9b9fe4 100644
> >> > --- a/kernel/crash_core.c
> >> > +++ b/kernel/crash_core.c
> >> > @@ -221,9 +221,6 @@ static __init char *get_last_crashkernel(char *cmdline,
> >> > p = strstr(p+1, name);
> >> > }
> >> >
> >> > - if (!ck_cmdline)
> >> > - return NULL;
> >> > -
> >> > return ck_cmdline;
> >> > }
> >> >
> >>
> >> I agree that the if-block is not needed and can be removed. However, I
> >> cannot follow your reasoning in the commit message. Could you please
> >> explain it in more detail.
> >>
> >> The reason why I think that the 'if' can be removed is that the
> >> expression can only be true when ck_cmdline = NULL. But with that the
> >> last three lines are equivalent to
> >>
> >> if (!ck_cmdline)
> >> return ck_cmdline;
> >>
> >> return ck_cmdline;
> >>
> >> Which simply doesn't make any sense.
> >
> >Right, the judgement actually introduces redundant codes. As Zhe
> >replied, maybe you can rewrite the log and repost with your
> >Signed-off-by, Philipp. As for Author, you two can discuss in private
> >mail.
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] kernel/crash_core.c: No judgment required
2022-04-26 8:17 ` Philipp Rudo
@ 2022-04-26 8:20 ` Philipp Rudo
0 siblings, 0 replies; 5+ messages in thread
From: Philipp Rudo @ 2022-04-26 8:20 UTC (permalink / raw)
To: lizhe; +Cc: Baoquan He, dyoung, vgoyal, kexec, linux-kernel
Hi,
On Tue, 26 Apr 2022 10:17:18 +0200
Philipp Rudo <prudo@redhat.com> wrote:
> Hi lizhe,
>
> On Mon, 25 Apr 2022 14:22:31 +0800 (CST)
> lizhe <sensor1010@163.com> wrote:
>
> > HI :
> >
> >
> > I found the problem at the first time and gave the solution,
> >
> >
> >
> >
> > Pphilipp Rudo just saw the solution to the problem and gave an explanation.
> > the author of this patch should only be me
>
> right, I only commented on the patch you sent.
>
> Could you please update the commit message and send a v2.
should have checked the rest of my mails first...
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2022-04-26 8:20 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-12-10 3:20 [PATCH] kernel/crash_core.c: No judgment required lizhe
2021-12-14 16:32 ` Philipp Rudo
2022-04-25 1:36 ` Baoquan He
[not found] ` <62058381.3b6e.1805f62c8f4.Coremail.sensor1010@163.com>
2022-04-26 8:17 ` Philipp Rudo
2022-04-26 8:20 ` Philipp Rudo
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).