From: Akira Kawata <akirakawata1@gmail.com>
To: akpm@linux-foundation.org, adobriyan@gmail.com,
viro@zeniv.linux.org.uk, keescook@chromium.org,
linux-fsdevel@vger.kernel.org, lukas.bulwahn@gmail.com
Cc: akirakawata1@gmail.com, Eric Biederman <ebiederm@xmission.com>,
linux-kernel@vger.kernel.org
Subject: [PATCH v4 0/2] [PATCH v4 0/2] fs/binfmt_elf: Fix AT_PHDR for unusual ELF files
Date: Mon, 13 Dec 2021 08:24:10 +0900 [thread overview]
Message-ID: <20211212232414.1402199-1-akirakawata1@gmail.com> (raw)
These patches fix a bug in AT_PHDR calculation.
We cannot calculate AT_PHDR as the sum of load_addr and exec->e_phoff.
This is because exec->e_phoff is the offset of PHDRs in the file and the
address of PHDRs in the memory may differ from it. These patches fix the
bug by calculating the address of program headers from PT_LOADs
directly.
Sorry for my latency.
Changes in v4
- Reflecting comments from Lukas, add a refactoring commit.
Changes in v3:
- Fix a reported bug from kernel test robot.
Changes in v2:
- Remove unused load_addr from create_elf_tables.
- Improve the commit message.
Akira Kawata (2):
fs/binfmt_elf: Fix AT_PHDR for unusual ELF files
fs/binfmt_elf: Refactor load_elf_binary function
fs/binfmt_elf.c | 36 +++++++++++++++++++++---------------
1 file changed, 21 insertions(+), 15 deletions(-)
base-commit: 4eee8d0b64ecc3231040fa68ba750317ffca5c52
--
2.34.1
next reply other threads:[~2021-12-12 23:26 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-12-12 23:24 Akira Kawata [this message]
2021-12-12 23:24 ` [PATCH v4 1/2] fs/binfmt_elf: Fix AT_PHDR for unusual ELF files Akira Kawata
2022-01-27 5:01 ` Kees Cook
2022-01-27 12:56 ` Akira Kawata
2022-01-27 16:23 ` Kees Cook
2022-01-28 11:10 ` Akira Kawata
2022-01-28 19:56 ` Kees Cook
2021-12-12 23:24 ` [PATCH v4 2/2] fs/binfmt_elf: Refactor load_elf_binary function Akira Kawata
2022-01-27 5:11 ` Kees Cook
2021-12-12 23:24 ` [PATCH v4 0/2] [PATCH v4 0/2] fs/binfmt_elf: Fix AT_PHDR for unusual ELF files Akira Kawata
2021-12-12 23:35 ` Akira Kawata
2021-12-12 23:24 ` [PATCH v4 1/2] " Akira Kawata
2021-12-12 23:24 ` [PATCH v4 2/2] fs/binfmt_elf: Refactor load_elf_binary function Akira Kawata
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20211212232414.1402199-1-akirakawata1@gmail.com \
--to=akirakawata1@gmail.com \
--cc=adobriyan@gmail.com \
--cc=akpm@linux-foundation.org \
--cc=ebiederm@xmission.com \
--cc=keescook@chromium.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lukas.bulwahn@gmail.com \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).