From: "André Werner" <Andre.Werner@b-tu.de>
To: Mark Brown <broonie@kernel.org>
Cc: lgirdwood@gmail.com, anson.huang@nxp.com,
linux-kernel@vger.kernel.org, andre.werner@systec-electronic.com
Subject: Re: [PATCH] regulator: pca9450.h: Correct register masks for LDOs
Date: Tue, 14 Dec 2021 13:35:55 +0100 [thread overview]
Message-ID: <20211214133555.Horde.vtlLH95Iq91Ch-lE2bqCnJL@webmail.b-tu.de> (raw)
In-Reply-To: <YbegDDszsM4GyMyV@sirena.org.uk>
[-- Attachment #1: Type: text/plain, Size: 1676 bytes --]
Quoting Mark Brown <broonie@kernel.org>:
> On Mon, Dec 13, 2021 at 08:23:19AM +0100, André Werner wrote:
>> Within the defines of the register masks for LDO3 and LDO4,
>> the most significant bit was missing. The datasheet said
>> the range is 4:0 bits. Thus, the output voltage cannot be
>> set above 1.7V for each.
>
> This doesn't apply against current code, please check and resend.
From ade25a42e56c341073fc4b35e8096d01522b9046 Mon Sep 17 00:00:00 2001
From: Andre Werner <andre.werner@systec-electronic.com>
Date: Tue, 14 Dec 2021 08:41:14 +0100
Subject: [PATCH] linux: regulator: pca9450.h: Correct register masks for LDOs
Within the defines of the register masks for LDO3 and LDO4,
the most significant bit was missing. The datasheet said
the range is 4:0 bits. Thus, the output voltage cannot be
set above 1.7V for each.
Signed-off-by: Andre Werner <andre.werner@systec-electronic.com>
---
include/linux/regulator/pca9450.h | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/include/linux/regulator/pca9450.h
b/include/linux/regulator/pca9450.h
index 71902f41c919..0c3edff6bdff 100644
--- a/include/linux/regulator/pca9450.h
+++ b/include/linux/regulator/pca9450.h
@@ -196,11 +196,11 @@ enum {
/* PCA9450_REG_LDO3_VOLT bits */
#define LDO3_EN_MASK 0xC0
-#define LDO3OUT_MASK 0x0F
+#define LDO3OUT_MASK 0x1F
/* PCA9450_REG_LDO4_VOLT bits */
#define LDO4_EN_MASK 0xC0
-#define LDO4OUT_MASK 0x0F
+#define LDO4OUT_MASK 0x1F
/* PCA9450_REG_LDO5_VOLT bits */
#define LDO5L_EN_MASK 0xC0
--
2.31.1
[-- Attachment #2: PGP Public Key --]
[-- Type: application/pgp-keys, Size: 1263 bytes --]
next prev parent reply other threads:[~2021-12-14 12:36 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-12-13 7:23 [PATCH] linux: regulator: pca9450.h: Correct register masks for LDOs André Werner
2021-12-13 19:33 ` [PATCH] " Mark Brown
2021-12-14 12:35 ` André Werner [this message]
2021-12-14 13:18 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20211214133555.Horde.vtlLH95Iq91Ch-lE2bqCnJL@webmail.b-tu.de \
--to=andre.werner@b-tu.de \
--cc=andre.werner@systec-electronic.com \
--cc=anson.huang@nxp.com \
--cc=broonie@kernel.org \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).