linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Lee Jones <lee.jones@linaro.org>
To: lee.jones@linaro.org
Cc: linux-kernel@vger.kernel.org, Vlad Yasevich <vyasevich@gmail.com>,
	Neil Horman <nhorman@tuxdriver.com>,
	Marcelo Ricardo Leitner <marcelo.leitner@gmail.com>,
	"David S. Miller" <davem@davemloft.net>,
	Jakub Kicinski <kuba@kernel.org>,
	lksctp developers <linux-sctp@vger.kernel.org>,
	"H.P. Yarroll" <piggy@acm.org>,
	Karl Knutson <karl@athena.chicago.il.us>,
	Jon Grimm <jgrimm@us.ibm.com>,
	Xingang Guo <xingang.guo@intel.com>,
	Hui Huang <hui.huang@nokia.com>,
	Sridhar Samudrala <sri@us.ibm.com>,
	Daisy Chang <daisyc@us.ibm.com>, Ryan Layer <rmlayer@us.ibm.com>,
	Kevin Gao <kevin.gao@intel.com>,
	netdev@vger.kernel.org
Subject: [RESEND 1/2] sctp: export sctp_endpoint_{hold,put}() for use by seperate modules
Date: Tue, 14 Dec 2021 21:57:31 +0000	[thread overview]
Message-ID: <20211214215732.1507504-1-lee.jones@linaro.org> (raw)

net/sctp/diag.c for instance is built into its own separate module
(sctp_diag.ko) and requires the use of sctp_endpoint_{hold,put}() in
order to prevent a recently found use-after-free issue.

Cc: Vlad Yasevich <vyasevich@gmail.com>
Cc: Neil Horman <nhorman@tuxdriver.com>
Cc: Marcelo Ricardo Leitner <marcelo.leitner@gmail.com>
Cc: "David S. Miller" <davem@davemloft.net>
Cc: Jakub Kicinski <kuba@kernel.org>
Cc: lksctp developers <linux-sctp@vger.kernel.org>
Cc: "H.P. Yarroll" <piggy@acm.org>
Cc: Karl Knutson <karl@athena.chicago.il.us>
Cc: Jon Grimm <jgrimm@us.ibm.com>
Cc: Xingang Guo <xingang.guo@intel.com>
Cc: Hui Huang <hui.huang@nokia.com>
Cc: Sridhar Samudrala <sri@us.ibm.com>
Cc: Daisy Chang <daisyc@us.ibm.com>
Cc: Ryan Layer <rmlayer@us.ibm.com>
Cc: Kevin Gao <kevin.gao@intel.com>
Cc: linux-sctp@vger.kernel.org
Cc: netdev@vger.kernel.org
Signed-off-by: Lee Jones <lee.jones@linaro.org>
---
 net/sctp/endpointola.c | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/net/sctp/endpointola.c b/net/sctp/endpointola.c
index 48c9c2c7602f7..7c36056f3a1b4 100644
--- a/net/sctp/endpointola.c
+++ b/net/sctp/endpointola.c
@@ -226,6 +226,7 @@ void sctp_endpoint_hold(struct sctp_endpoint *ep)
 {
 	refcount_inc(&ep->base.refcnt);
 }
+EXPORT_SYMBOL_GPL(sctp_endpoint_hold);
 
 /* Release a reference to an endpoint and clean up if there are
  * no more references.
@@ -235,6 +236,7 @@ void sctp_endpoint_put(struct sctp_endpoint *ep)
 	if (refcount_dec_and_test(&ep->base.refcnt))
 		sctp_endpoint_destroy(ep);
 }
+EXPORT_SYMBOL_GPL(sctp_endpoint_put);
 
 /* Is this the endpoint we are looking for?  */
 struct sctp_endpoint *sctp_endpoint_is_match(struct sctp_endpoint *ep,
-- 
2.34.1.173.g76aa8bc2d0-goog


             reply	other threads:[~2021-12-14 21:57 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-12-14 21:57 Lee Jones [this message]
2021-12-14 21:57 ` [RESEND 2/2] sctp: hold cached endpoints to prevent possible UAF Lee Jones
2021-12-16  1:48   ` Jakub Kicinski
2021-12-16 16:12     ` Xin Long
2021-12-16 16:39       ` Lee Jones
2021-12-16 16:52         ` Xin Long
2021-12-16 17:13           ` Lee Jones
2021-12-16 17:14             ` Lee Jones
2021-12-16 18:12               ` Xin Long
2021-12-16 18:22                 ` Xin Long
2021-12-16 19:03                   ` Lee Jones
2021-12-19 21:20                     ` Xin Long
2021-12-20  8:56                       ` Lee Jones
2021-12-21 19:52                         ` Xin Long
2021-12-22 10:58                           ` Lee Jones
2021-12-16 18:25                 ` Lee Jones
2021-12-16 20:44         ` Jakub Kicinski
2021-12-17 11:21           ` Lee Jones

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20211214215732.1507504-1-lee.jones@linaro.org \
    --to=lee.jones@linaro.org \
    --cc=daisyc@us.ibm.com \
    --cc=davem@davemloft.net \
    --cc=hui.huang@nokia.com \
    --cc=jgrimm@us.ibm.com \
    --cc=karl@athena.chicago.il.us \
    --cc=kevin.gao@intel.com \
    --cc=kuba@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-sctp@vger.kernel.org \
    --cc=marcelo.leitner@gmail.com \
    --cc=netdev@vger.kernel.org \
    --cc=nhorman@tuxdriver.com \
    --cc=piggy@acm.org \
    --cc=rmlayer@us.ibm.com \
    --cc=sri@us.ibm.com \
    --cc=vyasevich@gmail.com \
    --cc=xingang.guo@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).