From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 027F3C433F5 for ; Fri, 17 Dec 2021 10:37:39 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235125AbhLQKhi (ORCPT ); Fri, 17 Dec 2021 05:37:38 -0500 Received: from lelv0143.ext.ti.com ([198.47.23.248]:34362 "EHLO lelv0143.ext.ti.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233421AbhLQKhh (ORCPT ); Fri, 17 Dec 2021 05:37:37 -0500 Received: from lelv0265.itg.ti.com ([10.180.67.224]) by lelv0143.ext.ti.com (8.15.2/8.15.2) with ESMTP id 1BHAbFQl103265; Fri, 17 Dec 2021 04:37:15 -0600 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ti.com; s=ti-com-17Q1; t=1639737435; bh=+nXhcjKNNROdKntOJztmSKywAUuemvkNHfzpB9oXqY0=; h=Date:From:To:CC:Subject:References:In-Reply-To; b=Wn2HMULsh4Ek3bx430KH0iZt2ggBb19Ef5zzPQFh/mksTKmTKMqcpgocVO7uExFDn OmuEMkjvSkFVzIm5yVNSVLtJoKKFPyw9VeVEt9X0kmiO1nhMJk3abNcfD+jPYUgKjT 3ZfCUyyewp0GaQDgtb3pjisRNOZGS48hNyxEz4yc= Received: from DLEE115.ent.ti.com (dlee115.ent.ti.com [157.170.170.26]) by lelv0265.itg.ti.com (8.15.2/8.15.2) with ESMTPS id 1BHAbEXx055352 (version=TLSv1.2 cipher=AES256-GCM-SHA384 bits=256 verify=FAIL); Fri, 17 Dec 2021 04:37:15 -0600 Received: from DLEE100.ent.ti.com (157.170.170.30) by DLEE115.ent.ti.com (157.170.170.26) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.2308.14; Fri, 17 Dec 2021 04:37:14 -0600 Received: from fllv0040.itg.ti.com (10.64.41.20) by DLEE100.ent.ti.com (157.170.170.30) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.2308.14 via Frontend Transport; Fri, 17 Dec 2021 04:37:14 -0600 Received: from localhost (ileax41-snat.itg.ti.com [10.172.224.153]) by fllv0040.itg.ti.com (8.15.2/8.15.2) with ESMTP id 1BHAbDjX018824; Fri, 17 Dec 2021 04:37:14 -0600 Date: Fri, 17 Dec 2021 16:07:13 +0530 From: Pratyush Yadav To: Matthias Schiffer CC: Tudor Ambarus , Michael Walle , Miquel Raynal , Richard Weinberger , Vignesh Raghavendra , , Subject: Re: [PATCH v2 1/2] mtd: spi-nor: micron-st: make mt25ql02g/mt25qu02g match more specific, add 4B opcodes Message-ID: <20211217103711.vrwx45spgzl73emp@ti.com> References: <20211216185254.pt3quvb4wkzou6wh@ti.com> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline In-Reply-To: User-Agent: NeoMutt/20171215 X-EXCLAIMER-MD-CONFIG: e1e8a2fd-e40a-4ac6-ac9b-f7e9cc9ee180 Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 17/12/21 11:07AM, Matthias Schiffer wrote: > On Fri, 2021-12-17 at 00:22 +0530, Pratyush Yadav wrote: > > Hi Matthias, > > > > On 07/10/21 02:08PM, Matthias Schiffer wrote: > > > Change the mt25ql02g/mt25qu02g entries to include > > > SPI_NOR_4B_OPCODES. In > > > addition, the SPI_NOR_DUAL_READ flag is added to mt25ql02g; this > > > seems > > > to have been an accidental omission, as mt25ql02g and mt25qu02g > > > should > > > support the same features. > > > > The way flags are specified are changed a bit. See [0]. Please re- > > roll > > your patch to use the new flag types. If this flash supports SFDP > > you > > should ideally just need to set the sfdp flag to true and the core > > should take care of the rest. Test reports with the new changes would > > be > > much appreciated :-) > > Will do. Is there an easy way to check which features the kernel > detected from the SFDP with the new code? Hm, I don't think so. I think you would have to add debug prints in the driver to know which flags were discovered by SFDP. -- Regards, Pratyush Yadav Texas Instruments Inc.