From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 97390C4332F for ; Fri, 17 Dec 2021 14:47:27 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S237506AbhLQOr0 (ORCPT ); Fri, 17 Dec 2021 09:47:26 -0500 Received: from mail-m17643.qiye.163.com ([59.111.176.43]:19252 "EHLO mail-m17643.qiye.163.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232771AbhLQOrZ (ORCPT ); Fri, 17 Dec 2021 09:47:25 -0500 DKIM-Signature: a=rsa-sha256; b=FE97xfNiCH2GO6VWAvP27wDcADAiSxzVCbspMp0R2wFATv7wLmU0T4bLjnHChXLqp3zb1zJ4yPXDeo9gRUCIqI5QqP8QMXjWOjx4tdUnrGuURJK/mdtooGMxhQOOMZhvIhck6XLsQHdJ3xxnRv/hvximNfEoS8WaGzQUj3SpRtg=; s=default; c=relaxed/relaxed; d=vivo.com; v=1; bh=5FMw7kp1HH8RVuayQYlBDiL3oMoktV9Ah1Z/ALYgqdw=; h=date:mime-version:subject:message-id:from; Received: from vivo-600-G6.vivo.xyz (unknown [58.250.176.229]) by mail-m17643.qiye.163.com (Hmail) with ESMTPA id 2E6B07E00E9; Fri, 17 Dec 2021 22:47:23 +0800 (CST) From: Yaqin Pan To: robh@kernel.org Cc: akingchen@vivo.com, balbi@kernel.org, devicetree@vger.kernel.org, gregkh@linuxfoundation.org, kernel@vivo.com, linux-kernel@vger.kernel.org, linux-usb@vger.kernel.org, s.shtylyov@omp.ru Subject: Re: [PATCH 2/2] dt-bindings: usb: document snps,dis_split_quirk property in dwc3 Date: Fri, 17 Dec 2021 22:47:09 +0800 Message-Id: <20211217144709.7194-1-akingchen@vivo.com> X-Mailer: git-send-email 2.17.1 In-Reply-To: References: X-HM-Spam-Status: e1kfGhgUHx5ZQUtXWQgPGg8OCBgUHx5ZQUlOS1dZCBgUCR5ZQVlLVUtZV1 kWDxoPAgseWUFZKDYvK1lXWShZQUhPN1dZLVlBSVdZDwkaFQgSH1lBWUMeSUNWHhhLTE1ISEoaH0 1OVRMBExYaEhckFA4PWVdZFhoPEhUdFFlBWVVLWQY+ X-HM-Sender-Digest: e1kMHhlZQR0aFwgeV1kSHx4VD1lBWUc6NS46Ezo6Aj5LVjYJNgpCLCwR GE8aCkNVSlVKTUhCTE5JT09ITEhKVTMWGhIXVRoQEhUcGBMeFTsNEg0UVRgUFkVZV1kSC1lBWU5D VUlOS1VKTE1VSUlCWVdZCAFZQUlPTU43Bg++ X-HM-Tid: 0a7dc8dca64fd999kuws2e6b07e00e9 Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org >> >> Add snps,dis_split_quirk property for dwc3 controller >> >> >> >> Signed-off-by: Yaqin Pan >> >> --- >> >> Documentation/devicetree/bindings/usb/snps,dwc3.yaml | 6 ++++++ >> >> 1 file changed, 6 insertions(+) >> >> >> >> diff --git a/Documentation/devicetree/bindings/usb/snps,dwc3.yaml b/Documentation/devicetree/bindings/usb/snps,dwc3.yaml >> >> index 41416fbd92aa..e9615ca8f447 100644 >> >> --- a/Documentation/devicetree/bindings/usb/snps,dwc3.yaml >> >> +++ b/Documentation/devicetree/bindings/usb/snps,dwc3.yaml >> >> @@ -226,6 +226,12 @@ properties: >> >> avoid -EPROTO errors with usbhid on some devices (Hikey 970). >> >> type: boolean >> >> + snps,dis_split_quirk: > >I'm tired of the never ending DWC3 quirks. Imply this from the >compatible unless it varies by board. Yes, this is a DWC3 controller compatible issue. > >Also, don't use '_' in DT names. Sure, i will change "snps,dis_split_quirk" to "snps,dis-split-quirk". > >> >> + description: >> >> + When set, change the way host controller schedules transations for a Control transfer. >> > >> > Transactions. >> > >> >> + Needed to avoid emurate some devices fail. >> > >> > Avoid failing to enumerating some devices? Yes. Avoid failing to enumerate some devices. >> >> Sorry. enumarate. :-) > Or enumerate