* [PATCH 1/1] drm/nouveau/device: Get right pgsize_bitmap of iommu_domain
@ 2021-12-18 7:45 Lu Baolu
2021-12-20 11:22 ` Robin Murphy
0 siblings, 1 reply; 2+ messages in thread
From: Lu Baolu @ 2021-12-18 7:45 UTC (permalink / raw)
To: Ben Skeggs, David Airlie, Daniel Vetter, Thierry Reding, Jonathan Hunter
Cc: Joerg Roedel, Robin Murphy, dri-devel, nouveau, linux-tegra,
iommu, linux-kernel, Lu Baolu
The suported page sizes of an iommu_domain are saved in the pgsize_bitmap
field. Retrieve the value from the right place.
Fixes: 58fd9375c2c534 ("drm/nouveau/platform: probe IOMMU if present")
Signed-off-by: Lu Baolu <baolu.lu@linux.intel.com>
---
drivers/gpu/drm/nouveau/nvkm/engine/device/tegra.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/nouveau/nvkm/engine/device/tegra.c b/drivers/gpu/drm/nouveau/nvkm/engine/device/tegra.c
index d0d52c1d4aee..992cc285f2fe 100644
--- a/drivers/gpu/drm/nouveau/nvkm/engine/device/tegra.c
+++ b/drivers/gpu/drm/nouveau/nvkm/engine/device/tegra.c
@@ -133,7 +133,7 @@ nvkm_device_tegra_probe_iommu(struct nvkm_device_tegra *tdev)
* or equal to the system's PAGE_SIZE, with a preference if
* both are equal.
*/
- pgsize_bitmap = tdev->iommu.domain->ops->pgsize_bitmap;
+ pgsize_bitmap = tdev->iommu.domain->pgsize_bitmap;
if (pgsize_bitmap & PAGE_SIZE) {
tdev->iommu.pgshift = PAGE_SHIFT;
} else {
--
2.25.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH 1/1] drm/nouveau/device: Get right pgsize_bitmap of iommu_domain
2021-12-18 7:45 [PATCH 1/1] drm/nouveau/device: Get right pgsize_bitmap of iommu_domain Lu Baolu
@ 2021-12-20 11:22 ` Robin Murphy
0 siblings, 0 replies; 2+ messages in thread
From: Robin Murphy @ 2021-12-20 11:22 UTC (permalink / raw)
To: Lu Baolu, Ben Skeggs, David Airlie, Daniel Vetter,
Thierry Reding, Jonathan Hunter
Cc: Joerg Roedel, dri-devel, nouveau, linux-tegra, iommu, linux-kernel
On 2021-12-18 07:45, Lu Baolu wrote:
> The suported page sizes of an iommu_domain are saved in the pgsize_bitmap
> field. Retrieve the value from the right place.
>
> Fixes: 58fd9375c2c534 ("drm/nouveau/platform: probe IOMMU if present")
...except domain->pgsize_bitmap was introduced more than a year after
that commit ;)
As an improvement rather than a fix, though,
Reviewed-by: Robin Murphy <robin.murphy@arm.com>
> Signed-off-by: Lu Baolu <baolu.lu@linux.intel.com>
> ---
> drivers/gpu/drm/nouveau/nvkm/engine/device/tegra.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/nouveau/nvkm/engine/device/tegra.c b/drivers/gpu/drm/nouveau/nvkm/engine/device/tegra.c
> index d0d52c1d4aee..992cc285f2fe 100644
> --- a/drivers/gpu/drm/nouveau/nvkm/engine/device/tegra.c
> +++ b/drivers/gpu/drm/nouveau/nvkm/engine/device/tegra.c
> @@ -133,7 +133,7 @@ nvkm_device_tegra_probe_iommu(struct nvkm_device_tegra *tdev)
> * or equal to the system's PAGE_SIZE, with a preference if
> * both are equal.
> */
> - pgsize_bitmap = tdev->iommu.domain->ops->pgsize_bitmap;
> + pgsize_bitmap = tdev->iommu.domain->pgsize_bitmap;
> if (pgsize_bitmap & PAGE_SIZE) {
> tdev->iommu.pgshift = PAGE_SHIFT;
> } else {
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2021-12-20 11:23 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-12-18 7:45 [PATCH 1/1] drm/nouveau/device: Get right pgsize_bitmap of iommu_domain Lu Baolu
2021-12-20 11:22 ` Robin Murphy
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).