linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] udmabuf: put dmabuf in case of get fd failed
@ 2021-12-20  5:43 Xianting Tian
  2021-12-20 13:20 ` kernel test robot
                   ` (2 more replies)
  0 siblings, 3 replies; 4+ messages in thread
From: Xianting Tian @ 2021-12-20  5:43 UTC (permalink / raw)
  To: kraxel, sumit.semwal, christian.koenig
  Cc: dri-devel, linux-media, linaro-mm-sig, linux-kernel, Xianting Tian

It needs call dma_buf_put() to put dmabuf in case of getting
fd failed.

Signed-off-by: Xianting Tian <xianting.tian@linux.alibaba.com>
---
 drivers/dma-buf/udmabuf.c | 5 ++++-
 1 file changed, 4 insertions(+), 1 deletion(-)

diff --git a/drivers/dma-buf/udmabuf.c b/drivers/dma-buf/udmabuf.c
index c57a609db..d77f96995 100644
--- a/drivers/dma-buf/udmabuf.c
+++ b/drivers/dma-buf/udmabuf.c
@@ -274,8 +274,11 @@ static long udmabuf_create(struct miscdevice *device,
 	flags = 0;
 	if (head->flags & UDMABUF_FLAGS_CLOEXEC)
 		flags |= O_CLOEXEC;
-	return dma_buf_fd(buf, flags);
+	ret = dma_buf_fd(buf, flags);
+	if (ret < 0) {
+		dma_buf_put(buf);
 
+	return ret;
 err:
 	while (pgbuf > 0)
 		put_page(ubuf->pages[--pgbuf]);
-- 
2.17.1


^ permalink raw reply related	[flat|nested] 4+ messages in thread

* Re: [PATCH] udmabuf: put dmabuf in case of get fd failed
  2021-12-20  5:43 [PATCH] udmabuf: put dmabuf in case of get fd failed Xianting Tian
@ 2021-12-20 13:20 ` kernel test robot
  2021-12-20 13:41 ` kernel test robot
  2021-12-20 14:06 ` kernel test robot
  2 siblings, 0 replies; 4+ messages in thread
From: kernel test robot @ 2021-12-20 13:20 UTC (permalink / raw)
  To: Xianting Tian, kraxel, sumit.semwal, christian.koenig
  Cc: kbuild-all, dri-devel, linux-media, linaro-mm-sig, linux-kernel,
	Xianting Tian

Hi Xianting,

Thank you for the patch! Perhaps something to improve:

[auto build test WARNING on linus/master]
[also build test WARNING on v5.16-rc6 next-20211217]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]

url:    https://github.com/0day-ci/linux/commits/Xianting-Tian/udmabuf-put-dmabuf-in-case-of-get-fd-failed/20211220-134433
base:   https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git a7904a538933c525096ca2ccde1e60d0ee62c08e
config: x86_64-randconfig-r032-20211220 (https://download.01.org/0day-ci/archive/20211220/202112202144.R9IV6eP2-lkp@intel.com/config)
compiler: gcc-9 (Debian 9.3.0-22) 9.3.0
reproduce (this is a W=1 build):
        # https://github.com/0day-ci/linux/commit/322781a4da9de4a3057afd933108d23ca7f5282e
        git remote add linux-review https://github.com/0day-ci/linux
        git fetch --no-tags linux-review Xianting-Tian/udmabuf-put-dmabuf-in-case-of-get-fd-failed/20211220-134433
        git checkout 322781a4da9de4a3057afd933108d23ca7f5282e
        # save the config file to linux build tree
        mkdir build_dir
        make W=1 O=build_dir ARCH=x86_64 SHELL=/bin/bash drivers/dma-buf/

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>

All warnings (new ones prefixed by >>):

   drivers/dma-buf/udmabuf.c: In function 'udmabuf_create':
   drivers/dma-buf/udmabuf.c:292:13: error: invalid storage class for function 'udmabuf_ioctl_create'
     292 | static long udmabuf_ioctl_create(struct file *filp, unsigned long arg)
         |             ^~~~~~~~~~~~~~~~~~~~
>> drivers/dma-buf/udmabuf.c:292:1: warning: ISO C90 forbids mixed declarations and code [-Wdeclaration-after-statement]
     292 | static long udmabuf_ioctl_create(struct file *filp, unsigned long arg)
         | ^~~~~~
   drivers/dma-buf/udmabuf.c:311:13: error: invalid storage class for function 'udmabuf_ioctl_create_list'
     311 | static long udmabuf_ioctl_create_list(struct file *filp, unsigned long arg)
         |             ^~~~~~~~~~~~~~~~~~~~~~~~~
   drivers/dma-buf/udmabuf.c:332:13: error: invalid storage class for function 'udmabuf_ioctl'
     332 | static long udmabuf_ioctl(struct file *filp, unsigned int ioctl,
         |             ^~~~~~~~~~~~~
   drivers/dma-buf/udmabuf.c:353:20: error: initializer element is not constant
     353 |  .unlocked_ioctl = udmabuf_ioctl,
         |                    ^~~~~~~~~~~~~
   drivers/dma-buf/udmabuf.c:353:20: note: (near initialization for 'udmabuf_fops.unlocked_ioctl')
   drivers/dma-buf/udmabuf.c:355:20: error: initializer element is not constant
     355 |  .compat_ioctl   = udmabuf_ioctl,
         |                    ^~~~~~~~~~~~~
   drivers/dma-buf/udmabuf.c:355:20: note: (near initialization for 'udmabuf_fops.compat_ioctl')
   drivers/dma-buf/udmabuf.c:365:19: error: invalid storage class for function 'udmabuf_dev_init'
     365 | static int __init udmabuf_dev_init(void)
         |                   ^~~~~~~~~~~~~~~~
   drivers/dma-buf/udmabuf.c:370:20: error: invalid storage class for function 'udmabuf_dev_exit'
     370 | static void __exit udmabuf_dev_exit(void)
         |                    ^~~~~~~~~~~~~~~~
   In file included from include/linux/init.h:5,
                    from include/linux/cred.h:12,
                    from drivers/dma-buf/udmabuf.c:2:
   include/linux/compiler.h:244:46: error: initializer element is not constant
     244 |   __UNIQUE_ID(__PASTE(__addressable_,sym)) = (void *)&sym;
         |                                              ^
   include/linux/init.h:236:2: note: in expansion of macro '__ADDRESSABLE'
     236 |  __ADDRESSABLE(fn)
         |  ^~~~~~~~~~~~~
   include/linux/init.h:241:2: note: in expansion of macro '__define_initcall_stub'
     241 |  __define_initcall_stub(__stub, fn)   \
         |  ^~~~~~~~~~~~~~~~~~~~~~
   include/linux/init.h:254:2: note: in expansion of macro '____define_initcall'
     254 |  ____define_initcall(fn,     \
         |  ^~~~~~~~~~~~~~~~~~~
   include/linux/init.h:260:2: note: in expansion of macro '__unique_initcall'
     260 |  __unique_initcall(fn, id, __sec, __initcall_id(fn))
         |  ^~~~~~~~~~~~~~~~~
   include/linux/init.h:262:35: note: in expansion of macro '___define_initcall'
     262 | #define __define_initcall(fn, id) ___define_initcall(fn, id, .initcall##id)
         |                                   ^~~~~~~~~~~~~~~~~~
   include/linux/init.h:291:30: note: in expansion of macro '__define_initcall'
     291 | #define device_initcall(fn)  __define_initcall(fn, 6)
         |                              ^~~~~~~~~~~~~~~~~
   include/linux/init.h:296:24: note: in expansion of macro 'device_initcall'
     296 | #define __initcall(fn) device_initcall(fn)
         |                        ^~~~~~~~~~~~~~~
   include/linux/module.h:88:24: note: in expansion of macro '__initcall'
      88 | #define module_init(x) __initcall(x);
         |                        ^~~~~~~~~~
   drivers/dma-buf/udmabuf.c:375:1: note: in expansion of macro 'module_init'
     375 | module_init(udmabuf_dev_init)
         | ^~~~~~~~~~~
   In file included from include/linux/container_of.h:5,
                    from include/linux/list.h:5,
                    from include/linux/key.h:14,
                    from include/linux/cred.h:13,
                    from drivers/dma-buf/udmabuf.c:2:
>> include/linux/build_bug.h:78:41: warning: ISO C90 forbids mixed declarations and code [-Wdeclaration-after-statement]
      78 | #define __static_assert(expr, msg, ...) _Static_assert(expr, msg)
         |                                         ^~~~~~~~~~~~~~
   include/linux/build_bug.h:77:34: note: in expansion of macro '__static_assert'
      77 | #define static_assert(expr, ...) __static_assert(expr, ##__VA_ARGS__, #expr)
         |                                  ^~~~~~~~~~~~~~~
   include/linux/init.h:246:2: note: in expansion of macro 'static_assert'
     246 |  static_assert(__same_type(initcall_t, &fn));
         |  ^~~~~~~~~~~~~
   include/linux/init.h:254:2: note: in expansion of macro '____define_initcall'
     254 |  ____define_initcall(fn,     \
         |  ^~~~~~~~~~~~~~~~~~~
   include/linux/init.h:260:2: note: in expansion of macro '__unique_initcall'
     260 |  __unique_initcall(fn, id, __sec, __initcall_id(fn))
         |  ^~~~~~~~~~~~~~~~~
   include/linux/init.h:262:35: note: in expansion of macro '___define_initcall'
     262 | #define __define_initcall(fn, id) ___define_initcall(fn, id, .initcall##id)
         |                                   ^~~~~~~~~~~~~~~~~~
   include/linux/init.h:291:30: note: in expansion of macro '__define_initcall'
     291 | #define device_initcall(fn)  __define_initcall(fn, 6)
         |                              ^~~~~~~~~~~~~~~~~
   include/linux/init.h:296:24: note: in expansion of macro 'device_initcall'
     296 | #define __initcall(fn) device_initcall(fn)
         |                        ^~~~~~~~~~~~~~~
   include/linux/module.h:88:24: note: in expansion of macro '__initcall'
      88 | #define module_init(x) __initcall(x);
         |                        ^~~~~~~~~~
   drivers/dma-buf/udmabuf.c:375:1: note: in expansion of macro 'module_init'
     375 | module_init(udmabuf_dev_init)
         | ^~~~~~~~~~~
   In file included from include/linux/cred.h:12,
                    from drivers/dma-buf/udmabuf.c:2:
   drivers/dma-buf/udmabuf.c:376:13: error: initializer element is not constant
     376 | module_exit(udmabuf_dev_exit)
         |             ^~~~~~~~~~~~~~~~
   include/linux/init.h:299:50: note: in definition of macro '__exitcall'
     299 |  static exitcall_t __exitcall_##fn __exit_call = fn
         |                                                  ^~
   drivers/dma-buf/udmabuf.c:376:1: note: in expansion of macro 'module_exit'
     376 | module_exit(udmabuf_dev_exit)
         | ^~~~~~~~~~~
   include/linux/init.h:299:2: warning: ISO C90 forbids mixed declarations and code [-Wdeclaration-after-statement]
     299 |  static exitcall_t __exitcall_##fn __exit_call = fn
         |  ^~~~~~
   include/linux/module.h:100:24: note: in expansion of macro '__exitcall'
     100 | #define module_exit(x) __exitcall(x);
         |                        ^~~~~~~~~~
   drivers/dma-buf/udmabuf.c:376:1: note: in expansion of macro 'module_exit'
     376 | module_exit(udmabuf_dev_exit)
         | ^~~~~~~~~~~
   drivers/dma-buf/udmabuf.c:379:1: error: expected declaration or statement at end of input
     379 | MODULE_LICENSE("GPL v2");
         | ^~~~~~~~~~~~~~


vim +292 drivers/dma-buf/udmabuf.c

fbb0de79507819 Gerd Hoffmann   2018-08-27  291  
fbb0de79507819 Gerd Hoffmann   2018-08-27 @292  static long udmabuf_ioctl_create(struct file *filp, unsigned long arg)
fbb0de79507819 Gerd Hoffmann   2018-08-27  293  {
fbb0de79507819 Gerd Hoffmann   2018-08-27  294  	struct udmabuf_create create;
fbb0de79507819 Gerd Hoffmann   2018-08-27  295  	struct udmabuf_create_list head;
fbb0de79507819 Gerd Hoffmann   2018-08-27  296  	struct udmabuf_create_item list;
fbb0de79507819 Gerd Hoffmann   2018-08-27  297  
fbb0de79507819 Gerd Hoffmann   2018-08-27  298  	if (copy_from_user(&create, (void __user *)arg,
33f35429fc49c0 Gerd Hoffmann   2018-09-11  299  			   sizeof(create)))
fbb0de79507819 Gerd Hoffmann   2018-08-27  300  		return -EFAULT;
fbb0de79507819 Gerd Hoffmann   2018-08-27  301  
fbb0de79507819 Gerd Hoffmann   2018-08-27  302  	head.flags  = create.flags;
fbb0de79507819 Gerd Hoffmann   2018-08-27  303  	head.count  = 1;
fbb0de79507819 Gerd Hoffmann   2018-08-27  304  	list.memfd  = create.memfd;
fbb0de79507819 Gerd Hoffmann   2018-08-27  305  	list.offset = create.offset;
fbb0de79507819 Gerd Hoffmann   2018-08-27  306  	list.size   = create.size;
fbb0de79507819 Gerd Hoffmann   2018-08-27  307  
c1bbed66899726 Gurchetan Singh 2019-12-02  308  	return udmabuf_create(filp->private_data, &head, &list);
fbb0de79507819 Gerd Hoffmann   2018-08-27  309  }
fbb0de79507819 Gerd Hoffmann   2018-08-27  310  

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH] udmabuf: put dmabuf in case of get fd failed
  2021-12-20  5:43 [PATCH] udmabuf: put dmabuf in case of get fd failed Xianting Tian
  2021-12-20 13:20 ` kernel test robot
@ 2021-12-20 13:41 ` kernel test robot
  2021-12-20 14:06 ` kernel test robot
  2 siblings, 0 replies; 4+ messages in thread
From: kernel test robot @ 2021-12-20 13:41 UTC (permalink / raw)
  To: Xianting Tian, kraxel, sumit.semwal, christian.koenig
  Cc: llvm, kbuild-all, dri-devel, linux-media, linaro-mm-sig,
	linux-kernel, Xianting Tian

Hi Xianting,

Thank you for the patch! Perhaps something to improve:

[auto build test WARNING on linus/master]
[also build test WARNING on v5.16-rc6 next-20211217]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]

url:    https://github.com/0day-ci/linux/commits/Xianting-Tian/udmabuf-put-dmabuf-in-case-of-get-fd-failed/20211220-134433
base:   https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git a7904a538933c525096ca2ccde1e60d0ee62c08e
config: x86_64-randconfig-r024-20211220 (https://download.01.org/0day-ci/archive/20211220/202112202114.4rnU3YZF-lkp@intel.com/config)
compiler: clang version 14.0.0 (https://github.com/llvm/llvm-project 555eacf75f21cd1dfc6363d73ad187b730349543)
reproduce (this is a W=1 build):
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # https://github.com/0day-ci/linux/commit/322781a4da9de4a3057afd933108d23ca7f5282e
        git remote add linux-review https://github.com/0day-ci/linux
        git fetch --no-tags linux-review Xianting-Tian/udmabuf-put-dmabuf-in-case-of-get-fd-failed/20211220-134433
        git checkout 322781a4da9de4a3057afd933108d23ca7f5282e
        # save the config file to linux build tree
        mkdir build_dir
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross W=1 O=build_dir ARCH=x86_64 SHELL=/bin/bash drivers/dma-buf/

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>

All warnings (new ones prefixed by >>):

   drivers/dma-buf/udmabuf.c:293:1: error: function definition is not allowed here
   {
   ^
   drivers/dma-buf/udmabuf.c:312:1: error: function definition is not allowed here
   {
   ^
   drivers/dma-buf/udmabuf.c:334:1: error: function definition is not allowed here
   {
   ^
   drivers/dma-buf/udmabuf.c:353:20: error: use of undeclared identifier 'udmabuf_ioctl'
           .unlocked_ioctl = udmabuf_ioctl,
                             ^
   drivers/dma-buf/udmabuf.c:355:20: error: use of undeclared identifier 'udmabuf_ioctl'
           .compat_ioctl   = udmabuf_ioctl,
                             ^
   drivers/dma-buf/udmabuf.c:366:1: error: function definition is not allowed here
   {
   ^
   drivers/dma-buf/udmabuf.c:371:1: error: function definition is not allowed here
   {
   ^
   drivers/dma-buf/udmabuf.c:375:13: error: use of undeclared identifier 'udmabuf_dev_init'
   module_init(udmabuf_dev_init)
               ^
   drivers/dma-buf/udmabuf.c:375:13: error: use of undeclared identifier 'udmabuf_dev_init'
   drivers/dma-buf/udmabuf.c:376:13: error: use of undeclared identifier 'udmabuf_dev_exit'
   module_exit(udmabuf_dev_exit)
               ^
   drivers/dma-buf/udmabuf.c:379:26: error: expected '}'
   MODULE_LICENSE("GPL v2");
                            ^
   drivers/dma-buf/udmabuf.c:166:1: note: to match this '{'
   {
   ^
>> drivers/dma-buf/udmabuf.c:351:37: warning: ISO C90 forbids mixing declarations and code [-Wdeclaration-after-statement]
   static const struct file_operations udmabuf_fops = {
                                       ^
   1 warning and 11 errors generated.


vim +351 drivers/dma-buf/udmabuf.c

fbb0de79507819 Gerd Hoffmann          2018-08-27  350  
fbb0de79507819 Gerd Hoffmann          2018-08-27 @351  static const struct file_operations udmabuf_fops = {
fbb0de79507819 Gerd Hoffmann          2018-08-27  352  	.owner		= THIS_MODULE,
fbb0de79507819 Gerd Hoffmann          2018-08-27  353  	.unlocked_ioctl = udmabuf_ioctl,
d4a197f4047e01 Kristian H. Kristensen 2020-09-03  354  #ifdef CONFIG_COMPAT
d4a197f4047e01 Kristian H. Kristensen 2020-09-03  355  	.compat_ioctl   = udmabuf_ioctl,
d4a197f4047e01 Kristian H. Kristensen 2020-09-03  356  #endif
fbb0de79507819 Gerd Hoffmann          2018-08-27  357  };
fbb0de79507819 Gerd Hoffmann          2018-08-27  358  

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH] udmabuf: put dmabuf in case of get fd failed
  2021-12-20  5:43 [PATCH] udmabuf: put dmabuf in case of get fd failed Xianting Tian
  2021-12-20 13:20 ` kernel test robot
  2021-12-20 13:41 ` kernel test robot
@ 2021-12-20 14:06 ` kernel test robot
  2 siblings, 0 replies; 4+ messages in thread
From: kernel test robot @ 2021-12-20 14:06 UTC (permalink / raw)
  To: Xianting Tian, kraxel, sumit.semwal, christian.koenig
  Cc: kbuild-all, dri-devel, linux-media, linaro-mm-sig, linux-kernel,
	Xianting Tian

Hi Xianting,

Thank you for the patch! Yet something to improve:

[auto build test ERROR on linus/master]
[also build test ERROR on v5.16-rc6 next-20211217]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]

url:    https://github.com/0day-ci/linux/commits/Xianting-Tian/udmabuf-put-dmabuf-in-case-of-get-fd-failed/20211220-134433
base:   https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git a7904a538933c525096ca2ccde1e60d0ee62c08e
config: arc-randconfig-r043-20211220 (https://download.01.org/0day-ci/archive/20211220/202112202101.tVpymGaH-lkp@intel.com/config)
compiler: arceb-elf-gcc (GCC) 11.2.0
reproduce (this is a W=1 build):
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # https://github.com/0day-ci/linux/commit/322781a4da9de4a3057afd933108d23ca7f5282e
        git remote add linux-review https://github.com/0day-ci/linux
        git fetch --no-tags linux-review Xianting-Tian/udmabuf-put-dmabuf-in-case-of-get-fd-failed/20211220-134433
        git checkout 322781a4da9de4a3057afd933108d23ca7f5282e
        # save the config file to linux build tree
        mkdir build_dir
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-11.2.0 make.cross O=build_dir ARCH=arc SHELL=/bin/bash drivers/dma-buf/

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>

All error/warnings (new ones prefixed by >>):

   drivers/dma-buf/udmabuf.c: In function 'udmabuf_create':
>> drivers/dma-buf/udmabuf.c:292:13: error: invalid storage class for function 'udmabuf_ioctl_create'
     292 | static long udmabuf_ioctl_create(struct file *filp, unsigned long arg)
         |             ^~~~~~~~~~~~~~~~~~~~
>> drivers/dma-buf/udmabuf.c:292:1: warning: ISO C90 forbids mixed declarations and code [-Wdeclaration-after-statement]
     292 | static long udmabuf_ioctl_create(struct file *filp, unsigned long arg)
         | ^~~~~~
>> drivers/dma-buf/udmabuf.c:311:13: error: invalid storage class for function 'udmabuf_ioctl_create_list'
     311 | static long udmabuf_ioctl_create_list(struct file *filp, unsigned long arg)
         |             ^~~~~~~~~~~~~~~~~~~~~~~~~
>> drivers/dma-buf/udmabuf.c:332:13: error: invalid storage class for function 'udmabuf_ioctl'
     332 | static long udmabuf_ioctl(struct file *filp, unsigned int ioctl,
         |             ^~~~~~~~~~~~~
>> drivers/dma-buf/udmabuf.c:353:27: error: initializer element is not constant
     353 |         .unlocked_ioctl = udmabuf_ioctl,
         |                           ^~~~~~~~~~~~~
   drivers/dma-buf/udmabuf.c:353:27: note: (near initialization for 'udmabuf_fops.unlocked_ioctl')
>> drivers/dma-buf/udmabuf.c:365:19: error: invalid storage class for function 'udmabuf_dev_init'
     365 | static int __init udmabuf_dev_init(void)
         |                   ^~~~~~~~~~~~~~~~
>> drivers/dma-buf/udmabuf.c:370:20: error: invalid storage class for function 'udmabuf_dev_exit'
     370 | static void __exit udmabuf_dev_exit(void)
         |                    ^~~~~~~~~~~~~~~~
   In file included from include/linux/cred.h:12,
                    from drivers/dma-buf/udmabuf.c:2:
   drivers/dma-buf/udmabuf.c:375:13: error: initializer element is not constant
     375 | module_init(udmabuf_dev_init)
         |             ^~~~~~~~~~~~~~~~
   include/linux/init.h:250:55: note: in definition of macro '____define_initcall'
     250 |                 __attribute__((__section__(__sec))) = fn;
         |                                                       ^~
   include/linux/init.h:260:9: note: in expansion of macro '__unique_initcall'
     260 |         __unique_initcall(fn, id, __sec, __initcall_id(fn))
         |         ^~~~~~~~~~~~~~~~~
   include/linux/init.h:262:35: note: in expansion of macro '___define_initcall'
     262 | #define __define_initcall(fn, id) ___define_initcall(fn, id, .initcall##id)
         |                                   ^~~~~~~~~~~~~~~~~~
   include/linux/init.h:291:41: note: in expansion of macro '__define_initcall'
     291 | #define device_initcall(fn)             __define_initcall(fn, 6)
         |                                         ^~~~~~~~~~~~~~~~~
   include/linux/init.h:296:24: note: in expansion of macro 'device_initcall'
     296 | #define __initcall(fn) device_initcall(fn)
         |                        ^~~~~~~~~~~~~~~
   include/linux/module.h:88:25: note: in expansion of macro '__initcall'
      88 | #define module_init(x)  __initcall(x);
         |                         ^~~~~~~~~~
   drivers/dma-buf/udmabuf.c:375:1: note: in expansion of macro 'module_init'
     375 | module_init(udmabuf_dev_init)
         | ^~~~~~~~~~~
   drivers/dma-buf/udmabuf.c:376:13: error: initializer element is not constant
     376 | module_exit(udmabuf_dev_exit)
         |             ^~~~~~~~~~~~~~~~
   include/linux/init.h:299:57: note: in definition of macro '__exitcall'
     299 |         static exitcall_t __exitcall_##fn __exit_call = fn
         |                                                         ^~
   drivers/dma-buf/udmabuf.c:376:1: note: in expansion of macro 'module_exit'
     376 | module_exit(udmabuf_dev_exit)
         | ^~~~~~~~~~~
>> include/linux/init.h:299:9: warning: ISO C90 forbids mixed declarations and code [-Wdeclaration-after-statement]
     299 |         static exitcall_t __exitcall_##fn __exit_call = fn
         |         ^~~~~~
   include/linux/module.h:100:25: note: in expansion of macro '__exitcall'
     100 | #define module_exit(x)  __exitcall(x);
         |                         ^~~~~~~~~~
   drivers/dma-buf/udmabuf.c:376:1: note: in expansion of macro 'module_exit'
     376 | module_exit(udmabuf_dev_exit)
         | ^~~~~~~~~~~
>> drivers/dma-buf/udmabuf.c:379:1: error: expected declaration or statement at end of input
     379 | MODULE_LICENSE("GPL v2");
         | ^~~~~~~~~~~~~~


vim +/udmabuf_ioctl_create +292 drivers/dma-buf/udmabuf.c

fbb0de795078190 Gerd Hoffmann          2018-08-27  291  
fbb0de795078190 Gerd Hoffmann          2018-08-27 @292  static long udmabuf_ioctl_create(struct file *filp, unsigned long arg)
fbb0de795078190 Gerd Hoffmann          2018-08-27  293  {
fbb0de795078190 Gerd Hoffmann          2018-08-27  294  	struct udmabuf_create create;
fbb0de795078190 Gerd Hoffmann          2018-08-27  295  	struct udmabuf_create_list head;
fbb0de795078190 Gerd Hoffmann          2018-08-27  296  	struct udmabuf_create_item list;
fbb0de795078190 Gerd Hoffmann          2018-08-27  297  
fbb0de795078190 Gerd Hoffmann          2018-08-27  298  	if (copy_from_user(&create, (void __user *)arg,
33f35429fc49c09 Gerd Hoffmann          2018-09-11  299  			   sizeof(create)))
fbb0de795078190 Gerd Hoffmann          2018-08-27  300  		return -EFAULT;
fbb0de795078190 Gerd Hoffmann          2018-08-27  301  
fbb0de795078190 Gerd Hoffmann          2018-08-27  302  	head.flags  = create.flags;
fbb0de795078190 Gerd Hoffmann          2018-08-27  303  	head.count  = 1;
fbb0de795078190 Gerd Hoffmann          2018-08-27  304  	list.memfd  = create.memfd;
fbb0de795078190 Gerd Hoffmann          2018-08-27  305  	list.offset = create.offset;
fbb0de795078190 Gerd Hoffmann          2018-08-27  306  	list.size   = create.size;
fbb0de795078190 Gerd Hoffmann          2018-08-27  307  
c1bbed668997268 Gurchetan Singh        2019-12-02  308  	return udmabuf_create(filp->private_data, &head, &list);
fbb0de795078190 Gerd Hoffmann          2018-08-27  309  }
fbb0de795078190 Gerd Hoffmann          2018-08-27  310  
fbb0de795078190 Gerd Hoffmann          2018-08-27 @311  static long udmabuf_ioctl_create_list(struct file *filp, unsigned long arg)
fbb0de795078190 Gerd Hoffmann          2018-08-27  312  {
fbb0de795078190 Gerd Hoffmann          2018-08-27  313  	struct udmabuf_create_list head;
fbb0de795078190 Gerd Hoffmann          2018-08-27  314  	struct udmabuf_create_item *list;
fbb0de795078190 Gerd Hoffmann          2018-08-27  315  	int ret = -EINVAL;
fbb0de795078190 Gerd Hoffmann          2018-08-27  316  	u32 lsize;
fbb0de795078190 Gerd Hoffmann          2018-08-27  317  
fbb0de795078190 Gerd Hoffmann          2018-08-27  318  	if (copy_from_user(&head, (void __user *)arg, sizeof(head)))
fbb0de795078190 Gerd Hoffmann          2018-08-27  319  		return -EFAULT;
dc4716d75154b36 Gerd Hoffmann          2018-09-11  320  	if (head.count > list_limit)
fbb0de795078190 Gerd Hoffmann          2018-08-27  321  		return -EINVAL;
fbb0de795078190 Gerd Hoffmann          2018-08-27  322  	lsize = sizeof(struct udmabuf_create_item) * head.count;
fbb0de795078190 Gerd Hoffmann          2018-08-27  323  	list = memdup_user((void __user *)(arg + sizeof(head)), lsize);
fbb0de795078190 Gerd Hoffmann          2018-08-27  324  	if (IS_ERR(list))
fbb0de795078190 Gerd Hoffmann          2018-08-27  325  		return PTR_ERR(list);
fbb0de795078190 Gerd Hoffmann          2018-08-27  326  
c1bbed668997268 Gurchetan Singh        2019-12-02  327  	ret = udmabuf_create(filp->private_data, &head, list);
fbb0de795078190 Gerd Hoffmann          2018-08-27  328  	kfree(list);
fbb0de795078190 Gerd Hoffmann          2018-08-27  329  	return ret;
fbb0de795078190 Gerd Hoffmann          2018-08-27  330  }
fbb0de795078190 Gerd Hoffmann          2018-08-27  331  
fbb0de795078190 Gerd Hoffmann          2018-08-27 @332  static long udmabuf_ioctl(struct file *filp, unsigned int ioctl,
fbb0de795078190 Gerd Hoffmann          2018-08-27  333  			  unsigned long arg)
fbb0de795078190 Gerd Hoffmann          2018-08-27  334  {
fbb0de795078190 Gerd Hoffmann          2018-08-27  335  	long ret;
fbb0de795078190 Gerd Hoffmann          2018-08-27  336  
fbb0de795078190 Gerd Hoffmann          2018-08-27  337  	switch (ioctl) {
fbb0de795078190 Gerd Hoffmann          2018-08-27  338  	case UDMABUF_CREATE:
fbb0de795078190 Gerd Hoffmann          2018-08-27  339  		ret = udmabuf_ioctl_create(filp, arg);
fbb0de795078190 Gerd Hoffmann          2018-08-27  340  		break;
fbb0de795078190 Gerd Hoffmann          2018-08-27  341  	case UDMABUF_CREATE_LIST:
fbb0de795078190 Gerd Hoffmann          2018-08-27  342  		ret = udmabuf_ioctl_create_list(filp, arg);
fbb0de795078190 Gerd Hoffmann          2018-08-27  343  		break;
fbb0de795078190 Gerd Hoffmann          2018-08-27  344  	default:
52499d9cdd88784 Gerd Hoffmann          2018-09-11  345  		ret = -ENOTTY;
fbb0de795078190 Gerd Hoffmann          2018-08-27  346  		break;
fbb0de795078190 Gerd Hoffmann          2018-08-27  347  	}
fbb0de795078190 Gerd Hoffmann          2018-08-27  348  	return ret;
fbb0de795078190 Gerd Hoffmann          2018-08-27  349  }
fbb0de795078190 Gerd Hoffmann          2018-08-27  350  
fbb0de795078190 Gerd Hoffmann          2018-08-27  351  static const struct file_operations udmabuf_fops = {
fbb0de795078190 Gerd Hoffmann          2018-08-27  352  	.owner		= THIS_MODULE,
fbb0de795078190 Gerd Hoffmann          2018-08-27 @353  	.unlocked_ioctl = udmabuf_ioctl,
d4a197f4047e01d Kristian H. Kristensen 2020-09-03  354  #ifdef CONFIG_COMPAT
d4a197f4047e01d Kristian H. Kristensen 2020-09-03  355  	.compat_ioctl   = udmabuf_ioctl,
d4a197f4047e01d Kristian H. Kristensen 2020-09-03  356  #endif
fbb0de795078190 Gerd Hoffmann          2018-08-27  357  };
fbb0de795078190 Gerd Hoffmann          2018-08-27  358  
fbb0de795078190 Gerd Hoffmann          2018-08-27  359  static struct miscdevice udmabuf_misc = {
fbb0de795078190 Gerd Hoffmann          2018-08-27  360  	.minor          = MISC_DYNAMIC_MINOR,
fbb0de795078190 Gerd Hoffmann          2018-08-27  361  	.name           = "udmabuf",
fbb0de795078190 Gerd Hoffmann          2018-08-27  362  	.fops           = &udmabuf_fops,
fbb0de795078190 Gerd Hoffmann          2018-08-27  363  };
fbb0de795078190 Gerd Hoffmann          2018-08-27  364  
fbb0de795078190 Gerd Hoffmann          2018-08-27 @365  static int __init udmabuf_dev_init(void)
fbb0de795078190 Gerd Hoffmann          2018-08-27  366  {
fbb0de795078190 Gerd Hoffmann          2018-08-27  367  	return misc_register(&udmabuf_misc);
fbb0de795078190 Gerd Hoffmann          2018-08-27  368  }
fbb0de795078190 Gerd Hoffmann          2018-08-27  369  
fbb0de795078190 Gerd Hoffmann          2018-08-27 @370  static void __exit udmabuf_dev_exit(void)
fbb0de795078190 Gerd Hoffmann          2018-08-27  371  {
fbb0de795078190 Gerd Hoffmann          2018-08-27  372  	misc_deregister(&udmabuf_misc);
fbb0de795078190 Gerd Hoffmann          2018-08-27  373  }
fbb0de795078190 Gerd Hoffmann          2018-08-27  374  
fbb0de795078190 Gerd Hoffmann          2018-08-27  375  module_init(udmabuf_dev_init)
fbb0de795078190 Gerd Hoffmann          2018-08-27  376  module_exit(udmabuf_dev_exit)
fbb0de795078190 Gerd Hoffmann          2018-08-27  377  
fbb0de795078190 Gerd Hoffmann          2018-08-27  378  MODULE_AUTHOR("Gerd Hoffmann <kraxel@redhat.com>");
fbb0de795078190 Gerd Hoffmann          2018-08-27 @379  MODULE_LICENSE("GPL v2");

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org

^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2021-12-20 14:12 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-12-20  5:43 [PATCH] udmabuf: put dmabuf in case of get fd failed Xianting Tian
2021-12-20 13:20 ` kernel test robot
2021-12-20 13:41 ` kernel test robot
2021-12-20 14:06 ` kernel test robot

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).