From: Yang Li <yang.lee@linux.alibaba.com>
To: linkinjeon@kernel.org
Cc: senozhatsky@chromium.org, sfrench@samba.org, hyc.lee@gmail.com,
linux-cifs@vger.kernel.org, linux-kernel@vger.kernel.org,
Yang Li <yang.lee@linux.alibaba.com>,
Abaci Robot <abaci@linux.alibaba.com>
Subject: [PATCH -next 2/4] ksmbd: Fix smb2_set_info_file() kernel-doc comment
Date: Tue, 21 Dec 2021 17:07:12 +0800 [thread overview]
Message-ID: <20211221090714.122543-2-yang.lee@linux.alibaba.com> (raw)
In-Reply-To: <20211221090714.122543-1-yang.lee@linux.alibaba.com>
Fix argument list that the kdoc format and script verified in
smb2_set_info_file().
The warnings were found by running scripts/kernel-doc, which is
caused by using 'make W=1'.
fs/ksmbd/smb2pdu.c:5862: warning: Function parameter or member 'req' not
described in 'smb2_set_info_file'
fs/ksmbd/smb2pdu.c:5862: warning: Excess function parameter 'info_class'
description in 'smb2_set_info_file'
Reported-by: Abaci Robot <abaci@linux.alibaba.com>
Fixes: 9496e268e3af ("ksmbd: add request buffer validation in smb2_set_info")
Signed-off-by: Yang Li <yang.lee@linux.alibaba.com>
---
fs/ksmbd/smb2pdu.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/fs/ksmbd/smb2pdu.c b/fs/ksmbd/smb2pdu.c
index ee2bcd02d0d7..2d55a186b825 100644
--- a/fs/ksmbd/smb2pdu.c
+++ b/fs/ksmbd/smb2pdu.c
@@ -5850,7 +5850,7 @@ static int set_file_mode_info(struct ksmbd_file *fp,
* smb2_set_info_file() - handler for smb2 set info command
* @work: smb work containing set info command buffer
* @fp: ksmbd_file pointer
- * @info_class: smb2 set info class
+ * @req: request buffer validation
* @share: ksmbd_share_config pointer
*
* Return: 0 on success, otherwise error
--
2.20.1.7.g153144c
next prev parent reply other threads:[~2021-12-21 9:07 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-12-21 9:07 [PATCH -next 1/4] ksmbd: Fix buffer_check_err() kernel-doc comment Yang Li
2021-12-21 9:07 ` Yang Li [this message]
2021-12-21 11:39 ` [PATCH -next 2/4] ksmbd: Fix smb2_set_info_file() " Namjae Jeon
2021-12-21 9:07 ` [PATCH -next 3/4] ksmbd: Delete an invalid arguement description in smb2_populate_readdir_entry() Yang Li
2021-12-21 9:07 ` [PATCH -next 4/4] ksmbd: Fix smb2_get_name() kernel-doc comment Yang Li
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20211221090714.122543-2-yang.lee@linux.alibaba.com \
--to=yang.lee@linux.alibaba.com \
--cc=abaci@linux.alibaba.com \
--cc=hyc.lee@gmail.com \
--cc=linkinjeon@kernel.org \
--cc=linux-cifs@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=senozhatsky@chromium.org \
--cc=sfrench@samba.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).