From: Masami Hiramatsu <mhiramat@kernel.org>
To: Beau Belgrave <beaub@linux.microsoft.com>
Cc: rostedt@goodmis.org, linux-trace-devel@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v8 03/12] user_events: Handle matching arguments from dyn_events
Date: Wed, 22 Dec 2021 15:19:02 +0900 [thread overview]
Message-ID: <20211222151902.f932b280d09cc8bce9304b30@kernel.org> (raw)
In-Reply-To: <20211216173511.10390-4-beaub@linux.microsoft.com>
On Thu, 16 Dec 2021 09:35:02 -0800
Beau Belgrave <beaub@linux.microsoft.com> wrote:
> Ensures that when dynamic events requests a match with arguments that
> they match what is in the user_event.
>
Looks good to me.
Reviewed-by: Masami Hiramatsu <mhiramat@kernel.org>
Thank you,
> Signed-off-by: Beau Belgrave <beaub@linux.microsoft.com>
> ---
> kernel/trace/trace_events_user.c | 77 +++++++++++++++++++++++++++++++-
> 1 file changed, 76 insertions(+), 1 deletion(-)
>
> diff --git a/kernel/trace/trace_events_user.c b/kernel/trace/trace_events_user.c
> index 67a92fe04ee4..9859e62b9838 100644
> --- a/kernel/trace/trace_events_user.c
> +++ b/kernel/trace/trace_events_user.c
> @@ -39,6 +39,7 @@
> #define MAX_EVENT_DESC 512
> #define EVENT_NAME(user_event) ((user_event)->tracepoint.name)
> #define MAX_FIELD_ARRAY_SIZE 1024
> +#define MAX_FIELD_ARG_NAME 256
>
> static char *register_page_data;
>
> @@ -694,13 +695,87 @@ static int user_event_free(struct dyn_event *ev)
> return destroy_user_event(user);
> }
>
> +static bool user_field_match(struct ftrace_event_field *field, int argc,
> + const char **argv, int *iout)
> +{
> + char *field_name, *arg_name;
> + int len, pos, i = *iout;
> + bool colon = false, match = false;
> +
> + if (i >= argc)
> + return false;
> +
> + len = MAX_FIELD_ARG_NAME;
> + field_name = kmalloc(len, GFP_KERNEL);
> + arg_name = kmalloc(len, GFP_KERNEL);
> +
> + if (!arg_name || !field_name)
> + goto out;
> +
> + pos = 0;
> +
> + for (; i < argc; ++i) {
> + if (i != *iout)
> + pos += snprintf(arg_name + pos, len - pos, " ");
> +
> + pos += snprintf(arg_name + pos, len - pos, argv[i]);
> +
> + if (strchr(argv[i], ';')) {
> + ++i;
> + colon = true;
> + break;
> + }
> + }
> +
> + pos = 0;
> +
> + pos += snprintf(field_name + pos, len - pos, field->type);
> + pos += snprintf(field_name + pos, len - pos, " ");
> + pos += snprintf(field_name + pos, len - pos, field->name);
> +
> + if (colon)
> + pos += snprintf(field_name + pos, len - pos, ";");
> +
> + *iout = i;
> +
> + match = strcmp(arg_name, field_name) == 0;
> +out:
> + kfree(arg_name);
> + kfree(field_name);
> +
> + return match;
> +}
> +
> +static bool user_fields_match(struct user_event *user, int argc,
> + const char **argv)
> +{
> + struct ftrace_event_field *field, *next;
> + struct list_head *head = &user->fields;
> + int i = 0;
> +
> + list_for_each_entry_safe_reverse(field, next, head, link)
> + if (!user_field_match(field, argc, argv, &i))
> + return false;
> +
> + if (i != argc)
> + return false;
> +
> + return true;
> +}
> +
> static bool user_event_match(const char *system, const char *event,
> int argc, const char **argv, struct dyn_event *ev)
> {
> struct user_event *user = container_of(ev, struct user_event, devent);
> + bool match;
>
> - return strcmp(EVENT_NAME(user), event) == 0 &&
> + match = strcmp(EVENT_NAME(user), event) == 0 &&
> (!system || strcmp(system, USER_EVENTS_SYSTEM) == 0);
> +
> + if (match && argc > 0)
> + match = user_fields_match(user, argc, argv);
> +
> + return match;
> }
>
> static struct dyn_event_operations user_event_dops = {
> --
> 2.17.1
>
--
Masami Hiramatsu <mhiramat@kernel.org>
next prev parent reply other threads:[~2021-12-22 6:19 UTC|newest]
Thread overview: 35+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-12-16 17:34 [PATCH v8 00/12] user_events: Enable user processes to create and write to trace events Beau Belgrave
2021-12-16 17:35 ` [PATCH v8 01/12] user_events: Add minimal support for trace_event into ftrace Beau Belgrave
2021-12-21 15:16 ` Masami Hiramatsu
2022-01-03 18:22 ` Beau Belgrave
2021-12-16 17:35 ` [PATCH v8 02/12] user_events: Add print_fmt generation support for basic types Beau Belgrave
2021-12-22 0:30 ` Masami Hiramatsu
2022-01-03 18:56 ` Beau Belgrave
2021-12-16 17:35 ` [PATCH v8 03/12] user_events: Handle matching arguments from dyn_events Beau Belgrave
2021-12-22 6:19 ` Masami Hiramatsu [this message]
2021-12-16 17:35 ` [PATCH v8 04/12] user_events: Add basic perf and eBPF support Beau Belgrave
2021-12-22 7:55 ` Masami Hiramatsu
2021-12-16 17:35 ` [PATCH v8 05/12] user_events: Add self-test for ftrace integration Beau Belgrave
2021-12-16 17:35 ` [PATCH v8 06/12] user_events: Add self-test for dynamic_events integration Beau Belgrave
2021-12-16 17:35 ` [PATCH v8 07/12] user_events: Add self-test for perf_event integration Beau Belgrave
2021-12-16 17:35 ` [PATCH v8 08/12] user_events: Optimize writing events by only copying data once Beau Belgrave
2021-12-22 15:11 ` Masami Hiramatsu
2022-01-03 18:58 ` Beau Belgrave
2022-01-06 22:17 ` Steven Rostedt
2022-01-06 23:05 ` Beau Belgrave
2021-12-16 17:35 ` [PATCH v8 09/12] user_events: Add documentation file Beau Belgrave
2021-12-22 14:18 ` Masami Hiramatsu
2022-01-03 23:01 ` Beau Belgrave
2022-01-06 21:14 ` Steven Rostedt
2021-12-16 17:35 ` [PATCH v8 10/12] user_events: Add sample code for typical usage Beau Belgrave
2021-12-22 23:18 ` Masami Hiramatsu
2022-01-06 22:09 ` Steven Rostedt
2022-01-06 23:06 ` Beau Belgrave
2021-12-16 17:35 ` [PATCH v8 11/12] user_events: Validate user payloads for size and null termination Beau Belgrave
2021-12-23 0:08 ` Masami Hiramatsu
2022-01-03 18:53 ` Beau Belgrave
2022-01-06 23:32 ` Masami Hiramatsu
2022-01-07 1:01 ` Beau Belgrave
2021-12-16 17:35 ` [PATCH v8 12/12] user_events: Add self-test for validator boundaries Beau Belgrave
2022-04-18 20:43 ` [PATCH v8 00/12] user_events: Enable user processes to create and write to trace events Hagen Paul Pfeifer
2022-04-19 0:25 ` Beau Belgrave
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20211222151902.f932b280d09cc8bce9304b30@kernel.org \
--to=mhiramat@kernel.org \
--cc=beaub@linux.microsoft.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-trace-devel@vger.kernel.org \
--cc=rostedt@goodmis.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).