From: Sasha Levin <sashal@kernel.org>
To: linux-kernel@vger.kernel.org, stable@vger.kernel.org
Cc: Guodong Liu <guodong.liu@mediatek.corp-partner.google.com>,
Zhiyong Tao <zhiyong.tao@mediatek.com>,
Chen-Yu Tsai <wenst@chromium.org>,
Linus Walleij <linus.walleij@linaro.org>,
Sasha Levin <sashal@kernel.org>,
sean.wang@kernel.org, matthias.bgg@gmail.com,
linux-mediatek@lists.infradead.org, linux-gpio@vger.kernel.org,
linux-arm-kernel@lists.infradead.org
Subject: [PATCH AUTOSEL 5.10 01/14] pinctrl: mediatek: fix global-out-of-bounds issue
Date: Mon, 27 Dec 2021 14:04:39 -0500 [thread overview]
Message-ID: <20211227190452.1042714-1-sashal@kernel.org> (raw)
From: Guodong Liu <guodong.liu@mediatek.corp-partner.google.com>
[ Upstream commit 2d5446da5acecf9c67db1c9d55ae2c3e5de01f8d ]
When eint virtual eint number is greater than gpio number,
it maybe produce 'desc[eint_n]' size globle-out-of-bounds issue.
Signed-off-by: Guodong Liu <guodong.liu@mediatek.corp-partner.google.com>
Signed-off-by: Zhiyong Tao <zhiyong.tao@mediatek.com>
Reviewed-by: Chen-Yu Tsai <wenst@chromium.org>
Link: https://lore.kernel.org/r/20211110071900.4490-2-zhiyong.tao@mediatek.com
Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
Signed-off-by: Sasha Levin <sashal@kernel.org>
---
drivers/pinctrl/mediatek/pinctrl-mtk-common-v2.c | 8 ++++++--
1 file changed, 6 insertions(+), 2 deletions(-)
diff --git a/drivers/pinctrl/mediatek/pinctrl-mtk-common-v2.c b/drivers/pinctrl/mediatek/pinctrl-mtk-common-v2.c
index 10002b8497fea..fbb7807e0da29 100644
--- a/drivers/pinctrl/mediatek/pinctrl-mtk-common-v2.c
+++ b/drivers/pinctrl/mediatek/pinctrl-mtk-common-v2.c
@@ -280,8 +280,12 @@ static int mtk_xt_get_gpio_n(void *data, unsigned long eint_n,
desc = (const struct mtk_pin_desc *)hw->soc->pins;
*gpio_chip = &hw->chip;
- /* Be greedy to guess first gpio_n is equal to eint_n */
- if (desc[eint_n].eint.eint_n == eint_n)
+ /*
+ * Be greedy to guess first gpio_n is equal to eint_n.
+ * Only eint virtual eint number is greater than gpio number.
+ */
+ if (hw->soc->npins > eint_n &&
+ desc[eint_n].eint.eint_n == eint_n)
*gpio_n = eint_n;
else
*gpio_n = mtk_xt_find_eint_num(hw, eint_n);
--
2.34.1
next reply other threads:[~2021-12-27 19:05 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-12-27 19:04 Sasha Levin [this message]
2021-12-27 19:04 ` [PATCH AUTOSEL 5.10 02/14] Input: i8042 - add deferred probe support Sasha Levin
2021-12-27 19:04 ` [PATCH AUTOSEL 5.10 03/14] Input: i8042 - enable deferred probe quirk for ASUS UM325UA Sasha Levin
2021-12-27 19:04 ` [PATCH AUTOSEL 5.10 04/14] Input: goodix - add id->model mapping for the "9111" model Sasha Levin
2021-12-27 19:04 ` [PATCH AUTOSEL 5.10 05/14] hwmon: (lm90) Do not report 'busy' status bit as alarm Sasha Levin
2021-12-27 19:04 ` [PATCH AUTOSEL 5.10 06/14] ASoC: rt5682: fix the wrong jack type detected Sasha Levin
2021-12-27 19:04 ` [PATCH AUTOSEL 5.10 07/14] ASoC: tas2770: Fix setting of high sample rates Sasha Levin
2021-12-27 19:04 ` [PATCH AUTOSEL 5.10 08/14] tomoyo: Check exceeded quota early in tomoyo_domain_quota_is_ok() Sasha Levin
2021-12-27 19:04 ` [PATCH AUTOSEL 5.10 09/14] tomoyo: use hwight16() " Sasha Levin
2021-12-27 19:04 ` [PATCH AUTOSEL 5.10 10/14] ax25: NPD bug when detaching AX25 device Sasha Levin
2021-12-27 19:04 ` [PATCH AUTOSEL 5.10 11/14] phonet/pep: refuse to enable an unbound pipe Sasha Levin
2021-12-27 19:04 ` [PATCH AUTOSEL 5.10 12/14] parisc: Clear stale IIR value on instruction access rights trap Sasha Levin
2021-12-27 19:04 ` [PATCH AUTOSEL 5.10 13/14] platform/x86: apple-gmux: use resource_size() with res Sasha Levin
2021-12-27 19:04 ` [PATCH AUTOSEL 5.10 14/14] memblock: fix memblock_phys_alloc() section mismatch error Sasha Levin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20211227190452.1042714-1-sashal@kernel.org \
--to=sashal@kernel.org \
--cc=guodong.liu@mediatek.corp-partner.google.com \
--cc=linus.walleij@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=matthias.bgg@gmail.com \
--cc=sean.wang@kernel.org \
--cc=stable@vger.kernel.org \
--cc=wenst@chromium.org \
--cc=zhiyong.tao@mediatek.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).