From: Yu Kuai <yukuai3@huawei.com>
To: <jack@suse.cz>, <tj@kernel.org>, <axboe@kernel.dk>,
<paolo.valente@linaro.org>
Cc: <cgroups@vger.kernel.org>, <linux-block@vger.kernel.org>,
<linux-kernel@vger.kernel.org>, <yukuai3@huawei.com>,
<yi.zhang@huawei.com>
Subject: [PATCH v2 2/3] block, bfq: avoid moving bfqq to it's parent bfqg
Date: Fri, 31 Dec 2021 11:23:53 +0800 [thread overview]
Message-ID: <20211231032354.793092-3-yukuai3@huawei.com> (raw)
In-Reply-To: <20211231032354.793092-1-yukuai3@huawei.com>
Moving bfqq to it's parent bfqg is pointless.
Signed-off-by: Yu Kuai <yukuai3@huawei.com>
Reviewed-by: Jan Kara <jack@suse.cz>
---
block/bfq-cgroup.c | 10 +++++++++-
1 file changed, 9 insertions(+), 1 deletion(-)
diff --git a/block/bfq-cgroup.c b/block/bfq-cgroup.c
index 09ff0bb1042c..5e65b0407e85 100644
--- a/block/bfq-cgroup.c
+++ b/block/bfq-cgroup.c
@@ -645,6 +645,14 @@ void bfq_bfqq_move(struct bfq_data *bfqd, struct bfq_queue *bfqq,
struct bfq_group *bfqg)
{
struct bfq_entity *entity = &bfqq->entity;
+ struct bfq_group *old_parent = bfq_group(bfqq);
+
+ /*
+ * No point to move bfqq to the same group, which can happen when
+ * root group is offlined
+ */
+ if (old_parent == bfqg)
+ return;
/*
* Get extra reference to prevent bfqq from being freed in
@@ -666,7 +674,7 @@ void bfq_bfqq_move(struct bfq_data *bfqd, struct bfq_queue *bfqq,
bfq_deactivate_bfqq(bfqd, bfqq, false, false);
else if (entity->on_st_or_in_serv)
bfq_put_idle_entity(bfq_entity_service_tree(entity), entity);
- bfqg_and_blkg_put(bfqq_group(bfqq));
+ bfqg_and_blkg_put(old_parent);
if (entity->parent &&
entity->parent->last_bfqq_created == bfqq)
--
2.31.1
next prev parent reply other threads:[~2021-12-31 3:12 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-12-31 3:23 [PATCH v2 0/3] block, bfq: minor cleanup and fix Yu Kuai
2021-12-31 3:23 ` [PATCH v2 1/3] block, bfq: cleanup bfq_bfqq_to_bfqg() Yu Kuai
2021-12-31 3:23 ` Yu Kuai [this message]
2021-12-31 3:23 ` [PATCH v2 3/3] block, bfq: don't move oom_bfqq Yu Kuai
2022-01-11 1:40 ` [PATCH v2 0/3] block, bfq: minor cleanup and fix yukuai (C)
2022-01-14 8:23 ` yukuai (C)
2022-01-14 9:59 ` Jan Kara
2022-01-18 17:53 ` Paolo Valente
2022-01-24 3:46 ` yukuai (C)
2022-01-28 9:35 ` yukuai (C)
2022-01-28 14:45 ` Jens Axboe
2022-01-28 19:27 ` Jens Axboe
2022-01-29 1:42 ` yukuai (C)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20211231032354.793092-3-yukuai3@huawei.com \
--to=yukuai3@huawei.com \
--cc=axboe@kernel.dk \
--cc=cgroups@vger.kernel.org \
--cc=jack@suse.cz \
--cc=linux-block@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=paolo.valente@linaro.org \
--cc=tj@kernel.org \
--cc=yi.zhang@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).