From: Wei Ming Chen <jj251510319013@gmail.com>
To: linux-kernel@vger.kernel.org
Cc: linux-usb@vger.kernel.org, gregkh@linuxfoundation.org,
balbi@kernel.org, maze@google.com,
Wei Ming Chen <jj251510319013@gmail.com>
Subject: [PATCH] usb: gadget: function: Fix returning incorrect PNP string
Date: Wed, 5 Jan 2022 12:04:39 +0800 [thread overview]
Message-ID: <20220105040439.3182-1-jj251510319013@gmail.com> (raw)
There will be 2 leading bytes indicating the total length of
the PNP string, so I think we should add value by 2, otherwise
the PNP string copied to user will not contain the last 2 bytes
Signed-off-by: Wei Ming Chen <jj251510319013@gmail.com>
---
drivers/usb/gadget/function/f_printer.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/drivers/usb/gadget/function/f_printer.c b/drivers/usb/gadget/function/f_printer.c
index abec5c58f525..3fb00fd0b5ee 100644
--- a/drivers/usb/gadget/function/f_printer.c
+++ b/drivers/usb/gadget/function/f_printer.c
@@ -1005,9 +1005,11 @@ static int printer_func_setup(struct usb_function *f,
break;
}
value = strlen(dev->pnp_string);
+ memcpy(buf + 2, dev->pnp_string, value);
+
+ value += 2;
buf[0] = (value >> 8) & 0xFF;
buf[1] = value & 0xFF;
- memcpy(buf + 2, dev->pnp_string, value);
DBG(dev, "1284 PNP String: %x %s\n", value,
dev->pnp_string);
break;
--
2.25.1
next reply other threads:[~2022-01-05 4:04 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-01-05 4:04 Wei Ming Chen [this message]
2022-01-06 14:35 ` [PATCH] usb: gadget: function: Fix returning incorrect PNP string Greg KH
2022-01-07 2:37 ` 陳偉銘
2022-01-26 12:21 ` Greg KH
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220105040439.3182-1-jj251510319013@gmail.com \
--to=jj251510319013@gmail.com \
--cc=balbi@kernel.org \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=maze@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).