From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9D933C4321E for ; Thu, 6 Jan 2022 07:29:11 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235701AbiAFH3H (ORCPT ); Thu, 6 Jan 2022 02:29:07 -0500 Received: from box.trvn.ru ([194.87.146.52]:38493 "EHLO box.trvn.ru" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S235610AbiAFH3E (ORCPT ); Thu, 6 Jan 2022 02:29:04 -0500 Received: from authenticated-user (box.trvn.ru [194.87.146.52]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) (No client certificate requested) by box.trvn.ru (Postfix) with ESMTPSA id 2B49642064; Thu, 6 Jan 2022 12:29:01 +0500 (+05) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=trvn.ru; s=mail; t=1641454141; bh=YGq3tK4Qa1gT0lBwrqqbtBTes6WWGLWzf8xd1+IjiT0=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=T5e2E5FoiHzX2Sr198cDknRr8t2aKUCHJvlwt2mT2ZClqgXjVRqte4zpIJMGrgnH1 vv/VnFJ2fdLYPbBHL8N3afCbZSgfZqSIou3k6ia9kybz3qWuwu3/XoTnsfWzFql3Bm s7SKSVfD1+IMfPtVmQ0+yfahRD2m4VsCCIEOM+6eaw1P3ChfBs7oqXkAzRNa6kb3mL pMcjXd55Ug1CiVaO/VeBu6EDTrQvU9LBibU5kHo4PcUTk1X0ZQt8adA/gvjvYwui/e yFSQdkGCZP0oK5iYhaLeeqRajWW54C7BDBggHyWFCD/ecDpw+eOc9vzByFTQClT2uq Y/q12tAf5REXg== From: Nikita Travkin To: dmitry.torokhov@gmail.com Cc: robh+dt@kernel.org, Michael.Srba@seznam.cz, linus.walleij@linaro.org, broonie@kernel.org, luca@z3ntu.xyz, linux-input@vger.kernel.org, devicetree@vger.kernel.org, phone-devel@vger.kernel.org, linux-kernel@vger.kernel.org, ~postmarketos/upstreaming@lists.sr.ht, Nikita Travkin Subject: [PATCH v3 1/6] input: zinitix: Make sure the IRQ is allocated before it gets enabled Date: Thu, 6 Jan 2022 12:28:35 +0500 Message-Id: <20220106072840.36851-2-nikita@trvn.ru> In-Reply-To: <20220106072840.36851-1-nikita@trvn.ru> References: <20220106072840.36851-1-nikita@trvn.ru> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Since irq request is the last thing in the driver probe, it happens later than the input device registration. This means that there is a small time window where if the open method is called the driver will attempt to enable not yet available irq. Fix that by moving the irq request before the input device registration. Reviewed-by: Linus Walleij Fixes: 26822652c85e ("Input: add zinitix touchscreen driver") Signed-off-by: Nikita Travkin --- drivers/input/touchscreen/zinitix.c | 18 +++++++++--------- 1 file changed, 9 insertions(+), 9 deletions(-) diff --git a/drivers/input/touchscreen/zinitix.c b/drivers/input/touchscreen/zinitix.c index b8d901099378..1e70b8d2a8d7 100644 --- a/drivers/input/touchscreen/zinitix.c +++ b/drivers/input/touchscreen/zinitix.c @@ -488,6 +488,15 @@ static int zinitix_ts_probe(struct i2c_client *client) return error; } + error = devm_request_threaded_irq(&client->dev, client->irq, + NULL, zinitix_ts_irq_handler, + IRQF_ONESHOT | IRQF_NO_AUTOEN, + client->name, bt541); + if (error) { + dev_err(&client->dev, "Failed to request IRQ: %d\n", error); + return error; + } + error = zinitix_init_input_dev(bt541); if (error) { dev_err(&client->dev, @@ -513,15 +522,6 @@ static int zinitix_ts_probe(struct i2c_client *client) return -EINVAL; } - error = devm_request_threaded_irq(&client->dev, client->irq, - NULL, zinitix_ts_irq_handler, - IRQF_ONESHOT | IRQF_NO_AUTOEN, - client->name, bt541); - if (error) { - dev_err(&client->dev, "Failed to request IRQ: %d\n", error); - return error; - } - return 0; } -- 2.30.2