From: Melissa Wen <mwen@igalia.com>
To: Jiasheng Jiang <jiasheng@iscas.ac.cn>
Cc: emma@anholt.net, airlied@linux.ie, daniel@ffwll.ch,
p.zabel@pengutronix.de, linux-kernel@vger.kernel.org,
dri-devel@lists.freedesktop.org
Subject: Re: [PATCH] drm/v3d/v3d_drv: Check for error num after setting mask
Date: Thu, 6 Jan 2022 09:17:57 -0100 [thread overview]
Message-ID: <20220106101757.4sd7d3nvoeatjzuq@mail.igalia.com> (raw)
In-Reply-To: <20220106025539.2597562-1-jiasheng@iscas.ac.cn>
[-- Attachment #1: Type: text/plain, Size: 1214 bytes --]
On 01/06, Jiasheng Jiang wrote:
> Because of the possible failure of the dma_supported(), the
> dma_set_mask_and_coherent() may return error num.
> Therefore, it should be better to check it and return the error if
> fails.
>
> Fixes: 334dd38a3878 ("drm/v3d: Set dma_mask as well as coherent_dma_mask")
> Signed-off-by: Jiasheng Jiang <jiasheng@iscas.ac.cn>
> ---
> drivers/gpu/drm/v3d/v3d_drv.c | 5 ++++-
> 1 file changed, 4 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/v3d/v3d_drv.c b/drivers/gpu/drm/v3d/v3d_drv.c
> index 99e22beea90b..bedd52195723 100644
> --- a/drivers/gpu/drm/v3d/v3d_drv.c
> +++ b/drivers/gpu/drm/v3d/v3d_drv.c
> @@ -232,8 +232,11 @@ static int v3d_platform_drm_probe(struct platform_device *pdev)
> return ret;
>
> mmu_debug = V3D_READ(V3D_MMU_DEBUG_INFO);
> - dma_set_mask_and_coherent(dev,
> + ret = dma_set_mask_and_coherent(dev,
> DMA_BIT_MASK(30 + V3D_GET_FIELD(mmu_debug, V3D_MMU_PA_WIDTH)));
> + if (ret)
> + return ret;
> +
lgtm, thanks!
Reviewed-by: Melissa Wen <mwen@igalia.com>
> v3d->va_width = 30 + V3D_GET_FIELD(mmu_debug, V3D_MMU_VA_WIDTH);
>
> ident1 = V3D_READ(V3D_HUB_IDENT1);
> --
> 2.25.1
>
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
next prev parent reply other threads:[~2022-01-06 10:18 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-01-06 2:55 [PATCH] drm/v3d/v3d_drv: Check for error num after setting mask Jiasheng Jiang
2022-01-06 10:17 ` Melissa Wen [this message]
2022-01-09 17:34 ` Melissa Wen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220106101757.4sd7d3nvoeatjzuq@mail.igalia.com \
--to=mwen@igalia.com \
--cc=airlied@linux.ie \
--cc=daniel@ffwll.ch \
--cc=dri-devel@lists.freedesktop.org \
--cc=emma@anholt.net \
--cc=jiasheng@iscas.ac.cn \
--cc=linux-kernel@vger.kernel.org \
--cc=p.zabel@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).