From: Stephen Boyd <sboyd@kernel.org>
To: Mmturquette@baylibre.com, conor.dooley@microchip.com,
linux-clk@vger.kernel.org, mani@kernel.org
Cc: linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, daire.mcnamara@microchip.com,
mail@conchuod.ie, Conor Dooley <conor.dooley@microchip.com>
Subject: Re: [PATCH] clk: bm1880: remove kfrees on static allocations
Date: Thu, 06 Jan 2022 17:46:51 -0800 [thread overview]
Message-ID: <20220107014652.E7FB7C36AE0@smtp.kernel.org> (raw)
In-Reply-To: <20211223154244.1024062-1-conor.dooley@microchip.com>
Quoting conor.dooley@microchip.com (2021-12-23 07:42:44)
> From: Conor Dooley <conor.dooley@microchip.com>
>
> bm1880_clk_unregister_pll & bm1880_clk_unregister_div both try to
> free statically allocated variables, so remove those kfrees.
>
> For example, if we take L703 kfree(div_hw):
> - div_hw is a bm1880_div_hw_clock pointer
> - in bm1880_clk_register_plls this is pointed to an element of arg1:
> struct bm1880_div_hw_clock *clks
> - in the probe, where bm1880_clk_register_plls is called arg1 is
> bm1880_div_clks, defined on L371:
> static struct bm1880_div_hw_clock bm1880_div_clks[]
>
> Signed-off-by: Conor Dooley <conor.dooley@microchip.com>
> ---
Applied to clk-next
prev parent reply other threads:[~2022-01-07 1:46 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-12-23 15:42 [PATCH] clk: bm1880: remove kfrees on static allocations conor.dooley
2022-01-07 1:46 ` Stephen Boyd [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220107014652.E7FB7C36AE0@smtp.kernel.org \
--to=sboyd@kernel.org \
--cc=Mmturquette@baylibre.com \
--cc=conor.dooley@microchip.com \
--cc=daire.mcnamara@microchip.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-clk@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mail@conchuod.ie \
--cc=mani@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).