[PATCH 1/2] clk: mediatek: clk-gate: Shrink by adding clockgating bit check helper

* [PATCH 1/2] clk: mediatek: clk-gate: Shrink by adding clockgating bit check helper
@ 2022-01-03 14:37 AngeloGioacchino Del Regno
  2022-01-03 14:37 ` [PATCH 2/2] clk: mediatek: clk-gate: Use regmap_{set/clear}_bits helpers AngeloGioacchino Del Regno
  2022-01-07  2:27 ` [PATCH 1/2] clk: mediatek: clk-gate: Shrink by adding clockgating bit check helper Stephen Boyd
  0 siblings, 2 replies; 5+ messages in thread
From: AngeloGioacchino Del Regno @ 2022-01-03 14:37 UTC (permalink / raw)
  To: mturquette
  Cc: sboyd, matthias.bgg, angelogioacchino.delregno, miles.chen,
	linux-clk, linux-kernel, linux-arm-kernel, linux-mediatek,
	kernel

Add a clockgating bit check helper and use it in functions
mtk_cg_bit_is_cleared(), mtk_cg_bit_is_set() to shrink the
file size.

Signed-off-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>
---
 drivers/clk/mediatek/clk-gate.c | 18 +++++++-----------
 1 file changed, 7 insertions(+), 11 deletions(-)

diff --git a/drivers/clk/mediatek/clk-gate.c b/drivers/clk/mediatek/clk-gate.c
index b02d2f74dd0d..957fa1d68f07 100644
--- a/drivers/clk/mediatek/clk-gate.c
+++ b/drivers/clk/mediatek/clk-gate.c
@@ -16,28 +16,24 @@
 #include "clk-mtk.h"
 #include "clk-gate.h"
 
-static int mtk_cg_bit_is_cleared(struct clk_hw *hw)
+static u32 mtk_get_clockgating(struct clk_hw *hw)
 {
 	struct mtk_clk_gate *cg = to_mtk_clk_gate(hw);
 	u32 val;
 
 	regmap_read(cg->regmap, cg->sta_ofs, &val);
 
-	val &= BIT(cg->bit);
+	return val & BIT(cg->bit);
+}
 
-	return val == 0;
+static int mtk_cg_bit_is_cleared(struct clk_hw *hw)
+{
+	return mtk_get_clockgating(hw) == 0;
 }
 
 static int mtk_cg_bit_is_set(struct clk_hw *hw)
 {
-	struct mtk_clk_gate *cg = to_mtk_clk_gate(hw);
-	u32 val;
-
-	regmap_read(cg->regmap, cg->sta_ofs, &val);
-
-	val &= BIT(cg->bit);
-
-	return val != 0;
+	return mtk_get_clockgating(hw) != 0;
 }
 
 static void mtk_cg_set_bit(struct clk_hw *hw)
-- 
2.33.1


^ permalink raw reply related	[flat|nested] 5+ messages in thread