* [PATCH] phy: phy-mtk-tphy: Fix dumplicated argument in phy-mtk-tphy
@ 2022-01-07 2:50 Wan Jiabing
2022-01-07 5:31 ` Chunfeng Yun
2022-01-27 6:42 ` Vinod Koul
0 siblings, 2 replies; 3+ messages in thread
From: Wan Jiabing @ 2022-01-07 2:50 UTC (permalink / raw)
To: Chunfeng Yun, Kishon Vijay Abraham I, Vinod Koul,
Matthias Brugger, linux-arm-kernel, linux-mediatek, linux-phy,
linux-kernel
Cc: jiabing.wan, Wan Jiabing
Fix following coccicheck warning:
./drivers/phy/mediatek/phy-mtk-tphy.c:994:6-29: duplicated argument
to && or ||
The efuse_rx_imp is duplicate. Here should be efuse_tx_imp.
Signed-off-by: Wan Jiabing <wanjiabing@vivo.com>
---
drivers/phy/mediatek/phy-mtk-tphy.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/phy/mediatek/phy-mtk-tphy.c b/drivers/phy/mediatek/phy-mtk-tphy.c
index 6d307102f4f6..8ee7682b8e93 100644
--- a/drivers/phy/mediatek/phy-mtk-tphy.c
+++ b/drivers/phy/mediatek/phy-mtk-tphy.c
@@ -992,7 +992,7 @@ static int phy_efuse_get(struct mtk_tphy *tphy, struct mtk_phy_instance *instanc
/* no efuse, ignore it */
if (!instance->efuse_intr &&
!instance->efuse_rx_imp &&
- !instance->efuse_rx_imp) {
+ !instance->efuse_tx_imp) {
dev_warn(dev, "no u3 intr efuse, but dts enable it\n");
instance->efuse_sw_en = 0;
break;
--
2.34.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] phy: phy-mtk-tphy: Fix dumplicated argument in phy-mtk-tphy
2022-01-07 2:50 [PATCH] phy: phy-mtk-tphy: Fix dumplicated argument in phy-mtk-tphy Wan Jiabing
@ 2022-01-07 5:31 ` Chunfeng Yun
2022-01-27 6:42 ` Vinod Koul
1 sibling, 0 replies; 3+ messages in thread
From: Chunfeng Yun @ 2022-01-07 5:31 UTC (permalink / raw)
To: Wan Jiabing, Kishon Vijay Abraham I, Vinod Koul,
Matthias Brugger, linux-arm-kernel, linux-mediatek, linux-phy,
linux-kernel
Cc: jiabing.wan
On Fri, 2022-01-07 at 10:50 +0800, Wan Jiabing wrote:
> Fix following coccicheck warning:
> ./drivers/phy/mediatek/phy-mtk-tphy.c:994:6-29: duplicated argument
> to && or ||
>
> The efuse_rx_imp is duplicate. Here should be efuse_tx_imp.
>
> Signed-off-by: Wan Jiabing <wanjiabing@vivo.com>
> ---
> drivers/phy/mediatek/phy-mtk-tphy.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/phy/mediatek/phy-mtk-tphy.c
> b/drivers/phy/mediatek/phy-mtk-tphy.c
> index 6d307102f4f6..8ee7682b8e93 100644
> --- a/drivers/phy/mediatek/phy-mtk-tphy.c
> +++ b/drivers/phy/mediatek/phy-mtk-tphy.c
> @@ -992,7 +992,7 @@ static int phy_efuse_get(struct mtk_tphy *tphy,
> struct mtk_phy_instance *instanc
> /* no efuse, ignore it */
> if (!instance->efuse_intr &&
> !instance->efuse_rx_imp &&
> - !instance->efuse_rx_imp) {
> + !instance->efuse_tx_imp) {
> dev_warn(dev, "no u3 intr efuse, but dts enable
> it\n");
> instance->efuse_sw_en = 0;
> break;
Acked-by: Chunfeng Yun <chunfeng.yun@mediatek.com>
Thanks a lot
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] phy: phy-mtk-tphy: Fix dumplicated argument in phy-mtk-tphy
2022-01-07 2:50 [PATCH] phy: phy-mtk-tphy: Fix dumplicated argument in phy-mtk-tphy Wan Jiabing
2022-01-07 5:31 ` Chunfeng Yun
@ 2022-01-27 6:42 ` Vinod Koul
1 sibling, 0 replies; 3+ messages in thread
From: Vinod Koul @ 2022-01-27 6:42 UTC (permalink / raw)
To: Wan Jiabing
Cc: Chunfeng Yun, Kishon Vijay Abraham I, Matthias Brugger,
linux-arm-kernel, linux-mediatek, linux-phy, linux-kernel,
jiabing.wan
On 07-01-22, 10:50, Wan Jiabing wrote:
> Fix following coccicheck warning:
> ./drivers/phy/mediatek/phy-mtk-tphy.c:994:6-29: duplicated argument
> to && or ||
>
> The efuse_rx_imp is duplicate. Here should be efuse_tx_imp.
Applied, thanks
--
~Vinod
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2022-01-27 6:42 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-01-07 2:50 [PATCH] phy: phy-mtk-tphy: Fix dumplicated argument in phy-mtk-tphy Wan Jiabing
2022-01-07 5:31 ` Chunfeng Yun
2022-01-27 6:42 ` Vinod Koul
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).