From: Javier Martinez Canillas <javierm@redhat.com>
To: linux-kernel@vger.kernel.org
Cc: Kris Karas <bugs-a21@moonlit-rail.com>,
Javier Martinez Canillas <javierm@redhat.com>,
dri-devel@lists.freedesktop.org, linux-fbdev@vger.kernel.org
Subject: [PATCH 1/2] video: vga16fb: Fix logic that checks for the display standard
Date: Fri, 7 Jan 2022 12:07:22 +0100 [thread overview]
Message-ID: <20220107110723.323276-2-javierm@redhat.com> (raw)
In-Reply-To: <20220107110723.323276-1-javierm@redhat.com>
The vga16fb framebuffer driver supports both Enhanced Graphics Adapter
(EGA) and Video Graphics Array (VGA) 16 color graphic cards.
But the logic to check whether the EGA or VGA standard are used is not
correct. It just checks if screen_info.orig_video_isVGA is set, but it
should check if is set to VIDEO_TYPE_VGAC instead.
This means that it assumes to be VGA even if is set to VIDEO_TYPE_EGAC.
Signed-off-by: Javier Martinez Canillas <javierm@redhat.com>
---
drivers/video/fbdev/vga16fb.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/video/fbdev/vga16fb.c b/drivers/video/fbdev/vga16fb.c
index e2757ff1c23d..3347c9b6a332 100644
--- a/drivers/video/fbdev/vga16fb.c
+++ b/drivers/video/fbdev/vga16fb.c
@@ -1332,7 +1332,7 @@ static int vga16fb_probe(struct platform_device *dev)
printk(KERN_INFO "vga16fb: mapped to 0x%p\n", info->screen_base);
par = info->par;
- par->isVGA = screen_info.orig_video_isVGA;
+ par->isVGA = screen_info.orig_video_isVGA == VIDEO_TYPE_VGAC;
par->palette_blanked = 0;
par->vesa_blanked = 0;
--
2.33.1
next prev parent reply other threads:[~2022-01-07 11:07 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-01-07 11:07 [PATCH 0/2] video: A couple of fixes for the vga16fb driver Javier Martinez Canillas
2022-01-07 11:07 ` Javier Martinez Canillas [this message]
2022-01-09 10:02 ` [PATCH 1/2] video: vga16fb: Fix logic that checks for the display standard Geert Uytterhoeven
2022-01-09 20:20 ` Kris Karas (Bug reporting)
2022-01-10 8:22 ` Javier Martinez Canillas
2022-01-07 11:07 ` [PATCH 2/2] video: vga16fb: Only probe for EGA and VGA 16 color graphic cards Javier Martinez Canillas
2022-01-09 10:01 ` Geert Uytterhoeven
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220107110723.323276-2-javierm@redhat.com \
--to=javierm@redhat.com \
--cc=bugs-a21@moonlit-rail.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=linux-fbdev@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).