From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id E6B48C433FE for ; Sat, 8 Jan 2022 14:33:30 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234462AbiAHOd2 (ORCPT ); Sat, 8 Jan 2022 09:33:28 -0500 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]:31514 "EHLO us-smtp-delivery-124.mimecast.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229712AbiAHOd1 (ORCPT ); Sat, 8 Jan 2022 09:33:27 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1641652406; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding; bh=OTEoDAXesUBrrz0y7VX933AG7BpNKcC+21DOjfav4eQ=; b=N8zW4mVxz9x85I2DTig0IFp+9D5JB7bbiXl86u1vWUY1oN9e53DGCRn1ZvjmbCHBCS3QY3 T86ENFsag5dSAYFydtWmWngPtrmi/plN8ehPnv5+gFt4lt/vDREbrKUbpd/hEq3Jo/7Dxe MLsojwuUDHbPIkePTvRMFXkCW68k4gg= Received: from mail-oo1-f69.google.com (mail-oo1-f69.google.com [209.85.161.69]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-134-7uLzGcGAMkuwwpYik-DyUQ-1; Sat, 08 Jan 2022 09:33:25 -0500 X-MC-Unique: 7uLzGcGAMkuwwpYik-DyUQ-1 Received: by mail-oo1-f69.google.com with SMTP id p3-20020a4a4803000000b002da84ca8abcso5998494ooa.14 for ; Sat, 08 Jan 2022 06:33:24 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=OTEoDAXesUBrrz0y7VX933AG7BpNKcC+21DOjfav4eQ=; b=anhMbeUA8zwacPX7ngIpZH4C67KX33E0byABNRDGdkKOa7TBVwA1AihCoP8VgBQ8M5 NeSF5NEonYKqu4Hb7qaP6zMnt2rrgH552TVHwbF8QvGv4dayKBB+HrZQmSGNKXNycaNW pzwj0kSwVIXqPeozvtjk317JLAZwFmvt/2F8eFvbL7IcZPgsNnWpJkS2rdQqb6y8XW1r P4v3UlElktN/cq+QnGcV2Sk5unioq0j5JuswDiTbC66YTBSAN8pBRZQ6sdg0v+qbF5cJ bRqJYi3J5SY4OXrJX7bjsUgI3S6ir1UPWHgotKb4GuSxaq9LEmTZP4jk+9uL70YS6XdP JZSQ== X-Gm-Message-State: AOAM531IN5804YeaZa8EosX0NEDl3kZHSINvxs3/RpGVlfALXcnOOkKP yYdyoSxlX7fbWB2lFfeoJMq/ywFEly/7a87pn2pJ6YyXoLHmxSuEaAE4UcGZZQPiG/FEDy6nAnb S+0EiZu4gjurawUUdZWNbU+QU X-Received: by 2002:a9d:d68:: with SMTP id 95mr46520890oti.188.1641652404334; Sat, 08 Jan 2022 06:33:24 -0800 (PST) X-Google-Smtp-Source: ABdhPJyrzTGEeaVMK49HTR2/2D3npJiXwy7xQHcIPlSumyPxfb0SUfpPiLi4GiaG2GrUwzY6o8mW7Q== X-Received: by 2002:a9d:d68:: with SMTP id 95mr46520883oti.188.1641652404104; Sat, 08 Jan 2022 06:33:24 -0800 (PST) Received: from localhost.localdomain.com (024-205-208-113.res.spectrum.com. [24.205.208.113]) by smtp.gmail.com with ESMTPSA id r37sm353568otv.54.2022.01.08.06.33.22 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 08 Jan 2022 06:33:23 -0800 (PST) From: trix@redhat.com To: wg@grandegger.com, mkl@pengutronix.de, davem@davemloft.net, kuba@kernel.org, nathan@kernel.org, ndesaulniers@google.com, mailhol.vincent@wanadoo.fr, stefan.maetje@esd.eu Cc: linux-can@vger.kernel.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, llvm@lists.linux.dev, Tom Rix Subject: [PATCH] can: janz-ican3: initialize dlc variable Date: Sat, 8 Jan 2022 06:33:19 -0800 Message-Id: <20220108143319.3986923-1-trix@redhat.com> X-Mailer: git-send-email 2.26.3 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Tom Rix Clang static analysis reports this problem janz-ican3.c:1311:2: warning: Undefined or garbage value returned to caller return dlc; ^~~~~~~~~~ dlc is only set with this conditional if (!(cf->can_id & CAN_RTR_FLAG)) dlc = cf->len; But is always returned. So initialize dlc to 0. Fixes: cc4b08c31b5c ("can: do not increase tx_bytes statistics for RTR frames") Signed-off-by: Tom Rix --- drivers/net/can/janz-ican3.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/can/janz-ican3.c b/drivers/net/can/janz-ican3.c index 5b677af5f2a41..808c105cf8f7e 100644 --- a/drivers/net/can/janz-ican3.c +++ b/drivers/net/can/janz-ican3.c @@ -1285,7 +1285,7 @@ static unsigned int ican3_get_echo_skb(struct ican3_dev *mod) { struct sk_buff *skb = skb_dequeue(&mod->echoq); struct can_frame *cf; - u8 dlc; + u8 dlc = 0; /* this should never trigger unless there is a driver bug */ if (!skb) { -- 2.26.3