From: kernel test robot <lkp@intel.com>
To: Sanrio Alvares <sanrio.alvares@intel.com>,
bhelgaas@google.com, linux-pci@vger.kernel.org,
linux-kernel@vger.kernel.org
Cc: llvm@lists.linux.dev, kbuild-all@lists.01.org,
mika.westerberg@linux.intel.com,
Sanrio Alvares <sanrio.alvares@intel.com>
Subject: Re: [PATCH] PCI / thunderbolt: Add quirk to handle incorrect Supported Link Speeds
Date: Sat, 8 Jan 2022 19:13:59 +0800 [thread overview]
Message-ID: <202201081937.sL6eGkBc-lkp@intel.com> (raw)
In-Reply-To: <20220106224240.31052-1-sanrio.alvares@intel.com>
Hi Sanrio,
Thank you for the patch! Perhaps something to improve:
[auto build test WARNING on helgaas-pci/next]
[also build test WARNING on v5.16-rc8 next-20220107]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]
url: https://github.com/0day-ci/linux/commits/Sanrio-Alvares/PCI-thunderbolt-Add-quirk-to-handle-incorrect-Supported-Link-Speeds/20220107-064444
base: https://git.kernel.org/pub/scm/linux/kernel/git/helgaas/pci.git next
config: i386-randconfig-r024-20220107 (https://download.01.org/0day-ci/archive/20220108/202201081937.sL6eGkBc-lkp@intel.com/config)
compiler: clang version 14.0.0 (https://github.com/llvm/llvm-project 32167bfe64a4c5dd4eb3f7a58e24f4cba76f5ac2)
reproduce (this is a W=1 build):
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# https://github.com/0day-ci/linux/commit/98f8f42acd1b8f46f3e6778fa58dd0d1cd005369
git remote add linux-review https://github.com/0day-ci/linux
git fetch --no-tags linux-review Sanrio-Alvares/PCI-thunderbolt-Add-quirk-to-handle-incorrect-Supported-Link-Speeds/20220107-064444
git checkout 98f8f42acd1b8f46f3e6778fa58dd0d1cd005369
# save the config file to linux build tree
mkdir build_dir
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross W=1 O=build_dir ARCH=i386 SHELL=/bin/bash drivers/pci/
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>
All warnings (new ones prefixed by >>):
>> drivers/pci/quirks.c:5304:6: warning: no previous prototype for function 'quirk_intel_tbt_supported_link_speeds' [-Wmissing-prototypes]
void quirk_intel_tbt_supported_link_speeds(struct pci_dev *pdev)
^
drivers/pci/quirks.c:5304:1: note: declare 'static' if the function is not intended to be used outside of this translation unit
void quirk_intel_tbt_supported_link_speeds(struct pci_dev *pdev)
^
static
1 warning generated.
vim +/quirk_intel_tbt_supported_link_speeds +5304 drivers/pci/quirks.c
5298
5299 /*
5300 * Intel Titan Ridge returns incorrect Supported Link Speeds Vector
5301 * when max Link Speed is 2.5GT/s. This results in an extra 1s delay during
5302 * resume_noirq with pcie tunneling enabled. Override that value:
5303 */
> 5304 void quirk_intel_tbt_supported_link_speeds(struct pci_dev *pdev)
5305 {
5306 pci_info(pdev, "applying Supported Link Speeds quirk\n");
5307 pdev->supported_link_speed = PCIE_SPEED_2_5GT;
5308 }
5309 DECLARE_PCI_FIXUP_EARLY(PCI_VENDOR_ID_INTEL, 0x15e7, quirk_intel_tbt_supported_link_speeds);
5310 DECLARE_PCI_FIXUP_EARLY(PCI_VENDOR_ID_INTEL, 0x15ea, quirk_intel_tbt_supported_link_speeds);
5311 DECLARE_PCI_FIXUP_EARLY(PCI_VENDOR_ID_INTEL, 0x15ef, quirk_intel_tbt_supported_link_speeds);
5312
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org
next prev parent reply other threads:[~2022-01-08 11:14 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-01-06 22:42 [PATCH] PCI / thunderbolt: Add quirk to handle incorrect Supported Link Speeds Sanrio Alvares
2022-01-08 11:13 ` kernel test robot [this message]
2022-01-08 14:58 ` kernel test robot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=202201081937.sL6eGkBc-lkp@intel.com \
--to=lkp@intel.com \
--cc=bhelgaas@google.com \
--cc=kbuild-all@lists.01.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=llvm@lists.linux.dev \
--cc=mika.westerberg@linux.intel.com \
--cc=sanrio.alvares@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).