From: Maxime Ripard <maxime@cerno.tech>
To: Javier Martinez Canillas <javierm@redhat.com>
Cc: linux-kernel@vger.kernel.org, linux-fbdev@vger.kernel.org,
Daniel Vetter <daniel.vetter@ffwll.ch>,
dri-devel@lists.freedesktop.org,
Kris Karas <bugs-a21@moonlit-rail.com>,
Geert Uytterhoeven <geert@linux-m68k.org>,
Peter Robinson <pbrobinson@gmail.com>,
Thomas Zimmermann <tzimmermann@suse.de>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Borislav Petkov <bp@suse.de>
Subject: Re: [PATCH v2 0/2] video: A couple of fixes for the vga16fb driver
Date: Tue, 11 Jan 2022 14:16:01 +0100 [thread overview]
Message-ID: <20220111131601.u36j6grsvnir5gvp@houat> (raw)
In-Reply-To: <20220110095625.278836-1-javierm@redhat.com>
[-- Attachment #1: Type: text/plain, Size: 948 bytes --]
Hi,
On Mon, Jan 10, 2022 at 10:56:23AM +0100, Javier Martinez Canillas wrote:
> This patch series contains two fixes for the vga16fb driver. I looked at
> the driver due a regression reported [0], caused by commit d391c5827107
> ("drivers/firmware: move x86 Generic System Framebuffers support").
>
> The mentioned commit didn't change any logic but just moved the platform
> device registration that matches the vesafb and efifb drivers to happen
> later. And this caused the vga16fb driver to be probed even in machines
> that don't have an EGA or VGA video adapter.
>
> This is a v2 of the patch series that addresses issues pointed out by
> Geert Uytterhoeven.
>
> Patch #1 is fixing the wrong check to determine if either EGA or VGA is
> used and patch #2 adds a check to the driver to only be loaded for EGA
> and VGA 16 color graphic cards.
For both patches,
Acked-by: Maxime Ripard <maxime@cerno.tech>
Maxime
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]
next prev parent reply other threads:[~2022-01-11 13:16 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-01-10 9:56 [PATCH v2 0/2] video: A couple of fixes for the vga16fb driver Javier Martinez Canillas
2022-01-10 9:56 ` [PATCH v2 1/2] video: vga16fb: Fix logic that checks for the display standard Javier Martinez Canillas
2022-01-10 9:56 ` [PATCH v2 2/2] video: vga16fb: Only probe for EGA and VGA 16 color graphic cards Javier Martinez Canillas
2022-01-11 13:16 ` Maxime Ripard [this message]
2022-01-12 2:19 ` [PATCH v2 0/2] video: A couple of fixes for the vga16fb driver Kris Karas (Bug reporting)
2022-01-12 7:57 ` Geert Uytterhoeven
2022-01-12 11:38 ` Javier Martinez Canillas
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220111131601.u36j6grsvnir5gvp@houat \
--to=maxime@cerno.tech \
--cc=bp@suse.de \
--cc=bugs-a21@moonlit-rail.com \
--cc=daniel.vetter@ffwll.ch \
--cc=dri-devel@lists.freedesktop.org \
--cc=geert@linux-m68k.org \
--cc=gregkh@linuxfoundation.org \
--cc=javierm@redhat.com \
--cc=linux-fbdev@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=pbrobinson@gmail.com \
--cc=tzimmermann@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).