From: Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com>
To: Pavel Machek <pavel@ucw.cz>, Rob Herring <robh+dt@kernel.org>,
Lee Jones <lee.jones@linaro.org>,
Javier Martinez Canillas <javier@dowhile0.org>,
Liam Girdwood <lgirdwood@gmail.com>,
Mark Brown <broonie@kernel.org>,
Jacek Anaszewski <jacek.anaszewski@gmail.com>,
Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com>,
linux-leds@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: [PATCH v2 3/3] dt-bindings: leds: common: fix unit address in max77693 example
Date: Tue, 11 Jan 2022 18:54:30 +0100 [thread overview]
Message-ID: <20220111175430.224421-4-krzysztof.kozlowski@canonical.com> (raw)
In-Reply-To: <20220111175430.224421-1-krzysztof.kozlowski@canonical.com>
The max77693 LED device node should not take an unit address, because it
is instantiated from a max77693 I2C parent device node. This also
splits all examples to separate DTS examples because they are actually
independent.
Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com>
---
Documentation/devicetree/bindings/leds/common.yaml | 9 +++++++--
1 file changed, 7 insertions(+), 2 deletions(-)
diff --git a/Documentation/devicetree/bindings/leds/common.yaml b/Documentation/devicetree/bindings/leds/common.yaml
index 697102707703..328952d7acbb 100644
--- a/Documentation/devicetree/bindings/leds/common.yaml
+++ b/Documentation/devicetree/bindings/leds/common.yaml
@@ -185,9 +185,11 @@ examples:
};
};
- led-controller@0 {
+ - |
+ #include <dt-bindings/leds/common.h>
+
+ led-controller {
compatible = "maxim,max77693-led";
- reg = <0 0x100>;
led {
function = LED_FUNCTION_FLASH;
@@ -199,6 +201,9 @@ examples:
};
};
+ - |
+ #include <dt-bindings/leds/common.h>
+
i2c {
#address-cells = <1>;
#size-cells = <0>;
--
2.32.0
next prev parent reply other threads:[~2022-01-11 17:56 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-01-11 17:54 [PATCH v2 0/3] regulator/mfd: dt-bindings: maxim,max77802: convert to dtschema Krzysztof Kozlowski
2022-01-11 17:54 ` [PATCH v2 1/3] regulator: " Krzysztof Kozlowski
2022-01-11 22:31 ` Rob Herring
2022-02-10 17:01 ` Mark Brown
2022-03-07 9:18 ` Lee Jones
2022-01-11 17:54 ` [PATCH v2 2/3] dt-bindings: mfd: " Krzysztof Kozlowski
2022-03-07 9:19 ` Lee Jones
2022-01-11 17:54 ` Krzysztof Kozlowski [this message]
2022-01-11 22:31 ` [PATCH v2 3/3] dt-bindings: leds: common: fix unit address in max77693 example Rob Herring
2022-01-12 7:42 ` Krzysztof Kozlowski
2022-02-12 11:24 ` Pavel Machek
2022-01-12 8:10 ` [PATCH v2 0/3] regulator/mfd: dt-bindings: maxim,max77802: convert to dtschema Javier Martinez Canillas
2022-02-06 17:34 ` Krzysztof Kozlowski
2022-02-07 9:36 ` Lee Jones
2022-02-12 11:25 ` Pavel Machek
2022-02-12 16:04 ` Krzysztof Kozlowski
2022-02-15 7:31 ` Krzysztof Kozlowski
2022-03-07 9:42 ` Lee Jones
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220111175430.224421-4-krzysztof.kozlowski@canonical.com \
--to=krzysztof.kozlowski@canonical.com \
--cc=broonie@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=jacek.anaszewski@gmail.com \
--cc=javier@dowhile0.org \
--cc=lee.jones@linaro.org \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-leds@vger.kernel.org \
--cc=pavel@ucw.cz \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).