From: Jagath Jog J <jagathjog1996@gmail.com>
To: gregkh@linuxfoundation.org, fabioaiuto83@gmail.com,
marcocesati@gmail.com
Cc: linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org,
jagathjog1996@gmail.com
Subject: [PATCH 2/4] Staging: rtl8723bs: Interchanging comparison expression operands
Date: Wed, 12 Jan 2022 09:51:59 +0530 [thread overview]
Message-ID: <20220112042201.5056-3-jagathjog1996@gmail.com> (raw)
In-Reply-To: <20220112042201.5056-1-jagathjog1996@gmail.com>
Fix following checkpatch.pl warning by placing constant on rignt side of
comparison
WARNING: Comparisons should place the constant on the right side of the test
Signed-off-by: Jagath Jog J <jagathjog1996@gmail.com>
---
drivers/staging/rtl8723bs/core/rtw_security.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/rtl8723bs/core/rtw_security.c b/drivers/staging/rtl8723bs/core/rtw_security.c
index ac731415f733..fcecee824797 100644
--- a/drivers/staging/rtl8723bs/core/rtw_security.c
+++ b/drivers/staging/rtl8723bs/core/rtw_security.c
@@ -1554,7 +1554,7 @@ void rtw_sec_restore_wep_key(struct adapter *adapter)
struct security_priv *securitypriv = &(adapter->securitypriv);
signed int keyid;
- if ((_WEP40_ == securitypriv->dot11PrivacyAlgrthm) || (_WEP104_ == securitypriv->dot11PrivacyAlgrthm)) {
+ if ((securitypriv->dot11PrivacyAlgrthm == _WEP40_) || (securitypriv->dot11PrivacyAlgrthm == _WEP104_)) {
for (keyid = 0; keyid < 4; keyid++) {
if (securitypriv->key_mask & BIT(keyid)) {
if (keyid == securitypriv->dot11PrivacyKeyIndex)
--
2.17.1
next prev parent reply other threads:[~2022-01-12 4:22 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-01-12 4:21 [PATCH 0/4] Staging: rtl8723bs: Fix codestyle errors and warnings Jagath Jog J
2022-01-12 4:21 ` [PATCH 1/4] Staging: rtl8723bs: Placing opening { braces in previous line Jagath Jog J
2022-01-12 4:21 ` Jagath Jog J [this message]
2022-01-12 4:22 ` [PATCH 3/4] Staging: rtl8723bs: Removed extra spaces between datatype and variable Jagath Jog J
2022-01-12 4:22 ` [PATCH 4/4] Staging: rtl8723bs: Inserting blank line after declaration Jagath Jog J
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220112042201.5056-3-jagathjog1996@gmail.com \
--to=jagathjog1996@gmail.com \
--cc=fabioaiuto83@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-staging@lists.linux.dev \
--cc=marcocesati@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).