ChipIdea USB regression

ChipIdea USB regression

[Charles Keepax]

Hi guys,

My Zynq based board stopped booting today, a bisect points to this
patch:

commit 0f153a1b8193 ("usb: chipidea: Set the DT node on the child device")

It looks like it gets stuck in some sort of boot loop of doom:

48 locks held by swapper/0/1:
#0: 42a2c0d8 (&dev->mutex){....}-{3:3}, at: __driver_attach+0x12c/0x15c
#1: 42a41cd8 (&dev->mutex){....}-{3:3}, at: __device_attach+0x2c/0x164
#2: 42abdcd8 (&dev->mutex){....}-{3:3}, at: __device_attach+0x2c/0x164
#3: 42abd8d8 (&dev->mutex){....}-{3:3}, at: __device_attach+0x2c/0x164
#4: 42abd4d8 (&dev->mutex){....}-{3:3}, at: __device_attach+0x2c/0x164
#5: 42abd0d8 (&dev->mutex){....}-{3:3}, at: __device_attach+0x2c/0x164
#6: 42b00cd8 (&dev->mutex){....}-{3:3}, at: __device_attach+0x2c/0x164
#7: 42b008d8 (&dev->mutex){....}-{3:3}, at: __device_attach+0x2c/0x164
<snip>
[<40100af4>] (__irq_svc) from [<40920270>] (_raw_spin_unlock_irqrestore+0x30/0x5c)
[<40920270>] (_raw_spin_unlock_irqrestore) from [<40433238>] (klist_next+0x84/0xac)
[<40433238>] (klist_next) from [<40503a5c>] (bus_for_each_drv+0x60/0xbc)
[<40503a5c>] (bus_for_each_drv) from [<40505ea8>] (__device_attach+0xc4/0x164)
[<40505ea8>] (__device_attach) from [<405047e0>] (bus_probe_device+0x28/0x84)
[<405047e0>] (bus_probe_device) from [<405022b8>] (device_add+0x590/0x7c4)
[<405022b8>] (device_add) from [<4050835c>] (platform_device_add+0xa8/0x1f0)
[<4050835c>] (platform_device_add) from [<405f329c>] (ci_hdrc_add_device+0x3b4/0x434)
[<405f329c>] (ci_hdrc_add_device) from [<405f5f0c>] (ci_hdrc_usb2_probe+0x130/0x180)
[<405f5f0c>] (ci_hdrc_usb2_probe) from [<40507e60>] (platform_probe+0x58/0xa8)
[<40507e60>] (platform_probe) from [<4050584c>] (really_probe+0x1d8/0x418)
[<4050584c>] (really_probe) from [<40505c44>] (__driver_probe_device+0x1b8/0x1f0)
[<40505c44>] (__driver_probe_device) from [<40505ca0>] (driver_probe_device+0x24/0xa4)
[<40505ca0>] (driver_probe_device) from [<405060b0>] (__device_attach_driver+0xbc/0x110)
[<405060b0>] (__device_attach_driver) from [<40503aa4>] (bus_for_each_drv+0xa8/0xbc)
[<40503aa4>] (bus_for_each_drv) from [<40505ea8>] (__device_attach+0xc4/0x164)
[<40505ea8>] (__device_attach) from [<405047e0>] (bus_probe_device+0x28/0x84)
[<405047e0>] (bus_probe_device) from [<405022b8>] (device_add+0x590/0x7c4)
[<405022b8>] (device_add) from [<4050835c>] (platform_device_add+0xa8/0x1f0)
[<4050835c>] (platform_device_add) from [<405f329c>] (ci_hdrc_add_device+0x3b4/0x434)
[<405f329c>] (ci_hdrc_add_device) from [<405f5f0c>] (ci_hdrc_usb2_probe+0x130/0x180)
[<405f5f0c>] (ci_hdrc_usb2_probe) from [<40507e60>] (platform_probe+0x58/0xa8)
[<40507e60>] (platform_probe) from [<4050584c>] (really_probe+0x1d8/0x418)
[<4050584c>] (really_probe) from [<40505c44>] (__driver_probe_device+0x1b8/0x1f0)
[<40505c44>] (__driver_probe_device) from [<40505ca0>] (driver_probe_device+0x24/0xa4)
[<40505ca0>] (driver_probe_device) from [<405060b0>] (__device_attach_driver+0xbc/0x110)
[<405060b0>] (__device_attach_driver) from [<40503aa4>] (bus_for_each_drv+0xa8/0xbc)
[<40503aa4>] (bus_for_each_drv) from [<40505ea8>] (__device_attach+0xc4/0x164)
[<40505ea8>] (__device_attach) from [<405047e0>] (bus_probe_device+0x28/0x84)
[<405047e0>] (bus_probe_device) from [<405022b8>] (device_add+0x590/0x7c4)
[<405022b8>] (device_add) from [<4050835c>] (platform_device_add+0xa8/0x1f0)
[<4050835c>] (platform_device_add) from [<405f329c>] (ci_hdrc_add_device+0x3b4/0x434)
[<405f329c>] (ci_hdrc_add_device) from [<405f5f0c>] (ci_hdrc_usb2_probe+0x130/0x180)
[<405f5f0c>] (ci_hdrc_usb2_probe) from [<40507e60>] (platform_probe+0x58/0xa8)
[<40507e60>] (platform_probe) from [<4050584c>] (really_probe+0x1d8/0x418)
[<4050584c>] (really_probe) from [<40505c44>] (__driver_probe_device+0x1b8/0x1f0)
[<40505c44>] (__driver_probe_device) from [<40505ca0>] (driver_probe_device+0x24/0xa4)
[<40505ca0>] (driver_probe_device) from [<405060b0>] (__device_attach_driver+0xbc/0x110)
[<405060b0>] (__device_attach_driver) from [<40503aa4>] (bus_for_each_drv+0xa8/0xbc)
[<40503aa4>] (bus_for_each_drv) from [<40505ea8>] (__device_attach+0xc4/0x164)
[<40505ea8>] (__device_attach) from [<405047e0>] (bus_probe_device+0x28/0x84)
[<405047e0>] (bus_probe_device) from [<405022b8>] (device_add+0x590/0x7c4)

I will keep poking it today to see if I can figure out more of
what is actually going wrong, but if any of you guys had any
thoughts/suggestions or if you want me to provide any additional
info all of those would be greatly appreciated.

Thanks,
Charles

Re: ChipIdea USB regression

[Charles Keepax]

On Fri, Jan 14, 2022 at 10:56:20AM +0000, Charles Keepax wrote:
> Hi guys,
> 
> My Zynq based board stopped booting today, a bisect points to this
> patch:
> 
> commit 0f153a1b8193 ("usb: chipidea: Set the DT node on the child device")
> 
> It looks like it gets stuck in some sort of boot loop of doom:

Ok so poking that a little more, I think I can see what happens,
the USB DT node looks like this:

usb0: usb@e0002000 {
	compatible = "xlnx,zynq-usb-2.20a", "chipidea,usb2";
	status = "disabled";
	clocks = <&clkc 28>;
	interrupt-parent = <&intc>;
	interrupts = <0 21 4>;
	reg = <0xe0002000 0x1000>;
	phy_type = "ulpi";
};

&usb0 {
	status = "okay";

	dr_mode = "host";
	usb-phy = <&usb_phy0>;
};

So when that patch copies the DT node to the new platform device
in ci_hdrc_add_device it copies the compatible stuff as well as
the IRQ stuff it was targeting, this presumably causes the kernel
to bind a new copy of the driver to that new device, which probes
and calls ci_hdrc_add_device again repeating the process until
it dies.

Kinda looks to me like the best solution might just be to revert
the patch, I am not sure I see how that copy of the DT is supposed
to work?

Thanks,
Charles

Re: ChipIdea USB regression

[Rob Herring]

+Arnd, Tony

On Fri, Jan 14, 2022 at 5:18 AM Charles Keepax
<ckeepax@opensource.cirrus.com> wrote:
>
> On Fri, Jan 14, 2022 at 10:56:20AM +0000, Charles Keepax wrote:
> > Hi guys,
> >
> > My Zynq based board stopped booting today, a bisect points to this
> > patch:
> >
> > commit 0f153a1b8193 ("usb: chipidea: Set the DT node on the child device")
> >
> > It looks like it gets stuck in some sort of boot loop of doom:
>
> Ok so poking that a little more, I think I can see what happens,
> the USB DT node looks like this:
>
> usb0: usb@e0002000 {
>         compatible = "xlnx,zynq-usb-2.20a", "chipidea,usb2";
>         status = "disabled";
>         clocks = <&clkc 28>;
>         interrupt-parent = <&intc>;
>         interrupts = <0 21 4>;
>         reg = <0xe0002000 0x1000>;
>         phy_type = "ulpi";
> };
>
> &usb0 {
>         status = "okay";
>
>         dr_mode = "host";
>         usb-phy = <&usb_phy0>;
> };
>
> So when that patch copies the DT node to the new platform device
> in ci_hdrc_add_device it copies the compatible stuff as well as
> the IRQ stuff it was targeting, this presumably causes the kernel
> to bind a new copy of the driver to that new device, which probes
> and calls ci_hdrc_add_device again repeating the process until
> it dies.
>
> Kinda looks to me like the best solution might just be to revert
> the patch, I am not sure I see how that copy of the DT is supposed
> to work?

It's not copying the DT, but yes AFAICT it does match and bind the
child device on the parent driver using the compatible match instead
of matching on driver name. I think we can use the of_reuse_node flag
to avoid this in the match, but that needs some more investigation.

Rob

Re: ChipIdea USB regression

[Charles Keepax]

On Sat, Jan 15, 2022 at 09:55:23AM -0600, Rob Herring wrote:
> On Fri, Jan 14, 2022 at 5:18 AM Charles Keepax
> <ckeepax@opensource.cirrus.com> wrote:
> > On Fri, Jan 14, 2022 at 10:56:20AM +0000, Charles Keepax wrote:
> > So when that patch copies the DT node to the new platform device
> > in ci_hdrc_add_device it copies the compatible stuff as well as
> > the IRQ stuff it was targeting, this presumably causes the kernel
> > to bind a new copy of the driver to that new device, which probes
> > and calls ci_hdrc_add_device again repeating the process until
> > it dies.
> >
> > Kinda looks to me like the best solution might just be to revert
> > the patch, I am not sure I see how that copy of the DT is supposed
> > to work?
> 
> It's not copying the DT, but yes AFAICT it does match and bind the
> child device on the parent driver using the compatible match instead
> of matching on driver name. I think we can use the of_reuse_node flag
> to avoid this in the match, but that needs some more investigation.

Assuming you mean the of_node_reused flag, looks like it already
being set, your code does this:

@@ -864,6 +864,7 @@ struct platform_device *ci_hdrc_add_device(struct device *dev,
	pdev->dev.parent = dev;
	+ device_set_of_node_from_dev(&pdev->dev, dev);

And that function does this:

void device_set_of_node_from_dev(struct device *dev, const struct device *dev2)
{
	of_node_put(dev->of_node);
	dev->of_node = of_node_get(dev2->of_node);
	dev->of_node_reused = true;
}
EXPORT_SYMBOL_GPL(device_set_of_node_from_dev);

I guess maybe that flag doesn't do what it is supposed to for
some reason?

Thanks,
Charles

Re: ChipIdea USB regression

[Charles Keepax]

On Mon, Jan 17, 2022 at 09:26:56AM +0000, Charles Keepax wrote:
> On Sat, Jan 15, 2022 at 09:55:23AM -0600, Rob Herring wrote:
> > On Fri, Jan 14, 2022 at 5:18 AM Charles Keepax
> > <ckeepax@opensource.cirrus.com> wrote:
> > > On Fri, Jan 14, 2022 at 10:56:20AM +0000, Charles Keepax wrote:
> > > So when that patch copies the DT node to the new platform device
> > > in ci_hdrc_add_device it copies the compatible stuff as well as
> > > the IRQ stuff it was targeting, this presumably causes the kernel
> > > to bind a new copy of the driver to that new device, which probes
> > > and calls ci_hdrc_add_device again repeating the process until
> > > it dies.
> > >
> > > Kinda looks to me like the best solution might just be to revert
> > > the patch, I am not sure I see how that copy of the DT is supposed
> > > to work?
> > 
> > It's not copying the DT, but yes AFAICT it does match and bind the
> > child device on the parent driver using the compatible match instead
> > of matching on driver name. I think we can use the of_reuse_node flag
> > to avoid this in the match, but that needs some more investigation.
> 
> Assuming you mean the of_node_reused flag, looks like it already
> being set, your code does this:
> 
> @@ -864,6 +864,7 @@ struct platform_device *ci_hdrc_add_device(struct device *dev,
> 	pdev->dev.parent = dev;
> 	+ device_set_of_node_from_dev(&pdev->dev, dev);
> 
> And that function does this:
> 
> void device_set_of_node_from_dev(struct device *dev, const struct device *dev2)
> {
> 	of_node_put(dev->of_node);
> 	dev->of_node = of_node_get(dev2->of_node);
> 	dev->of_node_reused = true;
> }
> EXPORT_SYMBOL_GPL(device_set_of_node_from_dev);
> 
> I guess maybe that flag doesn't do what it is supposed to for
> some reason?
> 

Ah ok it seems that flag is only currently used by the pinctrl
subsystem, didn't realise that was quite so new and not used
anywhere. I guess we probably need to add something to the
platform device code to use that flag too, if that is the way we
want to run with this.

Thanks,
Charles

Re: ChipIdea USB regression

[Rob Herring]

On Mon, Jan 17, 2022 at 3:56 AM Charles Keepax
<ckeepax@opensource.cirrus.com> wrote:
>
> On Mon, Jan 17, 2022 at 09:26:56AM +0000, Charles Keepax wrote:
> > On Sat, Jan 15, 2022 at 09:55:23AM -0600, Rob Herring wrote:
> > > On Fri, Jan 14, 2022 at 5:18 AM Charles Keepax
> > > <ckeepax@opensource.cirrus.com> wrote:
> > > > On Fri, Jan 14, 2022 at 10:56:20AM +0000, Charles Keepax wrote:
> > > > So when that patch copies the DT node to the new platform device
> > > > in ci_hdrc_add_device it copies the compatible stuff as well as
> > > > the IRQ stuff it was targeting, this presumably causes the kernel
> > > > to bind a new copy of the driver to that new device, which probes
> > > > and calls ci_hdrc_add_device again repeating the process until
> > > > it dies.
> > > >
> > > > Kinda looks to me like the best solution might just be to revert
> > > > the patch, I am not sure I see how that copy of the DT is supposed
> > > > to work?
> > >
> > > It's not copying the DT, but yes AFAICT it does match and bind the
> > > child device on the parent driver using the compatible match instead
> > > of matching on driver name. I think we can use the of_reuse_node flag
> > > to avoid this in the match, but that needs some more investigation.
> >
> > Assuming you mean the of_node_reused flag, looks like it already
> > being set, your code does this:
> >
> > @@ -864,6 +864,7 @@ struct platform_device *ci_hdrc_add_device(struct device *dev,
> >       pdev->dev.parent = dev;
> >       + device_set_of_node_from_dev(&pdev->dev, dev);
> >
> > And that function does this:
> >
> > void device_set_of_node_from_dev(struct device *dev, const struct device *dev2)
> > {
> >       of_node_put(dev->of_node);
> >       dev->of_node = of_node_get(dev2->of_node);
> >       dev->of_node_reused = true;
> > }
> > EXPORT_SYMBOL_GPL(device_set_of_node_from_dev);
> >
> > I guess maybe that flag doesn't do what it is supposed to for
> > some reason?
> >
>
> Ah ok it seems that flag is only currently used by the pinctrl
> subsystem, didn't realise that was quite so new and not used
> anywhere. I guess we probably need to add something to the
> platform device code to use that flag too, if that is the way we
> want to run with this.

I pushed a patch[1] for kernel-ci to test if you want to give it a try, too.

Rob

[1] https://git.kernel.org/pub/scm/linux/kernel/git/robh/linux.git/log/?h=for-kernelci

Re: ChipIdea USB regression

[Charles Keepax]

On Tue, Jan 18, 2022 at 08:39:55AM -0600, Rob Herring wrote:
> On Mon, Jan 17, 2022 at 3:56 AM Charles Keepax > <ckeepax@opensource.cirrus.com> wrote:
> > On Mon, Jan 17, 2022 at 09:26:56AM +0000, Charles Keepax wrote:
> > > On Sat, Jan 15, 2022 at 09:55:23AM -0600, Rob Herring wrote:
> > > > On Fri, Jan 14, 2022 at 5:18 AM Charles Keepax > > > > <ckeepax@opensource.cirrus.com> wrote:
> > Ah ok it seems that flag is only currently used by the pinctrl
> > subsystem, didn't realise that was quite so new and not used
> > anywhere. I guess we probably need to add something to the
> > platform device code to use that flag too, if that is the way we
> > want to run with this.
> 
> I pushed a patch[1] for kernel-ci to test if you want to give it a try, too.

Awesome thanks. This seems to fix the issue on my system and
doesn't obviously cause any new issues.

Tested-by: Charles Keepax <ckeepax@opensource.cirrus.com>

Thanks,
Charles

Re: ChipIdea USB regression

[Thorsten Leemhuis]

[TLDR: I'm adding this regression to regzbot, the Linux kernel
regression tracking bot; most text you find below is compiled from a few
templates paragraphs some of you might have seen already.]

Hi, this is your Linux kernel regression tracker speaking.

Adding the regression mailing list to the list of recipients, as it
should be in the loop for all regressions, as explained here:
https://www.kernel.org/doc/html/latest/admin-guide/reporting-issues.html

On 14.01.22 11:56, Charles Keepax wrote:
> Hi guys,
> 
> My Zynq based board stopped booting today, a bisect points to this
> patch:
> 
> commit 0f153a1b8193 ("usb: chipidea: Set the DT node on the child device")

Thanks for the report.

To be sure this issue doesn't fall through the cracks unnoticed, I'm
adding it to regzbot, my Linux kernel regression tracking bot:

#regzbot ^introduced 0f153a1b8193
#regzbot title usb: chipidea: Zynq based board stopped booting today
#regzbot ignore-activity

Reminder: when fixing the issue, please add a 'Link:' tag with the URL
to the report (the parent of this mail) using the kernel.org redirector,
as explained in 'Documentation/process/submitting-patches.rst'. Regzbot
then will automatically mark the regression as resolved once the fix
lands in the appropriate tree. For more details about regzbot see footer.

Sending this to everyone that got the initial report, to make all aware
of the tracking. I also hope that messages like this motivate people to
directly get at least the regression mailing list and ideally even
regzbot involved when dealing with regressions, as messages like this
wouldn't be needed then.

Don't worry, I'll send further messages wrt to this regression just to
the lists (with a tag in the subject so people can filter them away), as
long as they are intended just for regzbot. With a bit of luck no such
messages will be needed anyway.


Ciao, Thorsten (wearing his 'Linux kernel regression tracker' hat)

P.S.: As a Linux kernel regression tracker I'm getting a lot of reports
on my table. I can only look briefly into most of them. Unfortunately
therefore I sometimes will get things wrong or miss something important.
I hope that's not the case here; if you think it is, don't hesitate to
tell me about it in a public reply, that's in everyone's interest.

BTW, I have no personal interest in this issue, which is tracked using
regzbot, my Linux kernel regression tracking bot
(https://linux-regtracking.leemhuis.info/regzbot/). I'm only posting
this mail to get things rolling again and hence don't need to be CC on
all further activities wrt to this regression.



> It looks like it gets stuck in some sort of boot loop of doom:
> 
> 48 locks held by swapper/0/1:
> #0: 42a2c0d8 (&dev->mutex){....}-{3:3}, at: __driver_attach+0x12c/0x15c
> #1: 42a41cd8 (&dev->mutex){....}-{3:3}, at: __device_attach+0x2c/0x164
> #2: 42abdcd8 (&dev->mutex){....}-{3:3}, at: __device_attach+0x2c/0x164
> #3: 42abd8d8 (&dev->mutex){....}-{3:3}, at: __device_attach+0x2c/0x164
> #4: 42abd4d8 (&dev->mutex){....}-{3:3}, at: __device_attach+0x2c/0x164
> #5: 42abd0d8 (&dev->mutex){....}-{3:3}, at: __device_attach+0x2c/0x164
> #6: 42b00cd8 (&dev->mutex){....}-{3:3}, at: __device_attach+0x2c/0x164
> #7: 42b008d8 (&dev->mutex){....}-{3:3}, at: __device_attach+0x2c/0x164
> <snip>
> [<40100af4>] (__irq_svc) from [<40920270>] (_raw_spin_unlock_irqrestore+0x30/0x5c)
> [<40920270>] (_raw_spin_unlock_irqrestore) from [<40433238>] (klist_next+0x84/0xac)
> [<40433238>] (klist_next) from [<40503a5c>] (bus_for_each_drv+0x60/0xbc)
> [<40503a5c>] (bus_for_each_drv) from [<40505ea8>] (__device_attach+0xc4/0x164)
> [<40505ea8>] (__device_attach) from [<405047e0>] (bus_probe_device+0x28/0x84)
> [<405047e0>] (bus_probe_device) from [<405022b8>] (device_add+0x590/0x7c4)
> [<405022b8>] (device_add) from [<4050835c>] (platform_device_add+0xa8/0x1f0)
> [<4050835c>] (platform_device_add) from [<405f329c>] (ci_hdrc_add_device+0x3b4/0x434)
> [<405f329c>] (ci_hdrc_add_device) from [<405f5f0c>] (ci_hdrc_usb2_probe+0x130/0x180)
> [<405f5f0c>] (ci_hdrc_usb2_probe) from [<40507e60>] (platform_probe+0x58/0xa8)
> [<40507e60>] (platform_probe) from [<4050584c>] (really_probe+0x1d8/0x418)
> [<4050584c>] (really_probe) from [<40505c44>] (__driver_probe_device+0x1b8/0x1f0)
> [<40505c44>] (__driver_probe_device) from [<40505ca0>] (driver_probe_device+0x24/0xa4)
> [<40505ca0>] (driver_probe_device) from [<405060b0>] (__device_attach_driver+0xbc/0x110)
> [<405060b0>] (__device_attach_driver) from [<40503aa4>] (bus_for_each_drv+0xa8/0xbc)
> [<40503aa4>] (bus_for_each_drv) from [<40505ea8>] (__device_attach+0xc4/0x164)
> [<40505ea8>] (__device_attach) from [<405047e0>] (bus_probe_device+0x28/0x84)
> [<405047e0>] (bus_probe_device) from [<405022b8>] (device_add+0x590/0x7c4)
> [<405022b8>] (device_add) from [<4050835c>] (platform_device_add+0xa8/0x1f0)
> [<4050835c>] (platform_device_add) from [<405f329c>] (ci_hdrc_add_device+0x3b4/0x434)
> [<405f329c>] (ci_hdrc_add_device) from [<405f5f0c>] (ci_hdrc_usb2_probe+0x130/0x180)
> [<405f5f0c>] (ci_hdrc_usb2_probe) from [<40507e60>] (platform_probe+0x58/0xa8)
> [<40507e60>] (platform_probe) from [<4050584c>] (really_probe+0x1d8/0x418)
> [<4050584c>] (really_probe) from [<40505c44>] (__driver_probe_device+0x1b8/0x1f0)
> [<40505c44>] (__driver_probe_device) from [<40505ca0>] (driver_probe_device+0x24/0xa4)
> [<40505ca0>] (driver_probe_device) from [<405060b0>] (__device_attach_driver+0xbc/0x110)
> [<405060b0>] (__device_attach_driver) from [<40503aa4>] (bus_for_each_drv+0xa8/0xbc)
> [<40503aa4>] (bus_for_each_drv) from [<40505ea8>] (__device_attach+0xc4/0x164)
> [<40505ea8>] (__device_attach) from [<405047e0>] (bus_probe_device+0x28/0x84)
> [<405047e0>] (bus_probe_device) from [<405022b8>] (device_add+0x590/0x7c4)
> [<405022b8>] (device_add) from [<4050835c>] (platform_device_add+0xa8/0x1f0)
> [<4050835c>] (platform_device_add) from [<405f329c>] (ci_hdrc_add_device+0x3b4/0x434)
> [<405f329c>] (ci_hdrc_add_device) from [<405f5f0c>] (ci_hdrc_usb2_probe+0x130/0x180)
> [<405f5f0c>] (ci_hdrc_usb2_probe) from [<40507e60>] (platform_probe+0x58/0xa8)
> [<40507e60>] (platform_probe) from [<4050584c>] (really_probe+0x1d8/0x418)
> [<4050584c>] (really_probe) from [<40505c44>] (__driver_probe_device+0x1b8/0x1f0)
> [<40505c44>] (__driver_probe_device) from [<40505ca0>] (driver_probe_device+0x24/0xa4)
> [<40505ca0>] (driver_probe_device) from [<405060b0>] (__device_attach_driver+0xbc/0x110)
> [<405060b0>] (__device_attach_driver) from [<40503aa4>] (bus_for_each_drv+0xa8/0xbc)
> [<40503aa4>] (bus_for_each_drv) from [<40505ea8>] (__device_attach+0xc4/0x164)
> [<40505ea8>] (__device_attach) from [<405047e0>] (bus_probe_device+0x28/0x84)
> [<405047e0>] (bus_probe_device) from [<405022b8>] (device_add+0x590/0x7c4)
> 
> I will keep poking it today to see if I can figure out more of
> what is actually going wrong, but if any of you guys had any
> thoughts/suggestions or if you want me to provide any additional
> info all of those would be greatly appreciated.
> 
> Thanks,
> Charles

---
Additional information about regzbot:

If you want to know more about regzbot, check out its web-interface, the
getting start guide, and/or the references documentation:

https://linux-regtracking.leemhuis.info/regzbot/
https://gitlab.com/knurd42/regzbot/-/blob/main/docs/getting_started.md
https://gitlab.com/knurd42/regzbot/-/blob/main/docs/reference.md

The last two documents will explain how you can interact with regzbot
yourself if your want to.

Hint for reporters: when reporting a regression it's in your interest to
tell #regzbot about it in the report, as that will ensure the regression
gets on the radar of regzbot and the regression tracker. That's in your
interest, as they will make sure the report won't fall through the
cracks unnoticed.

Hint for developers: you normally don't need to care about regzbot once
it's involved. Fix the issue as you normally would, just remember to
include a 'Link:' tag to the report in the commit message, as explained
in Documentation/process/submitting-patches.rst
That aspect was recently was made more explicit in commit 1f57bd42b77c:
https://git.kernel.org/linus/1f57bd42b77c

Re: ChipIdea USB regression

[Rob Herring]

On Sun, Jan 16, 2022 at 4:21 AM Thorsten Leemhuis
<regressions@leemhuis.info> wrote:
>
> [TLDR: I'm adding this regression to regzbot, the Linux kernel
> regression tracking bot; most text you find below is compiled from a few
> templates paragraphs some of you might have seen already.]
>
> Hi, this is your Linux kernel regression tracker speaking.
>
> Adding the regression mailing list to the list of recipients, as it
> should be in the loop for all regressions, as explained here:
> https://www.kernel.org/doc/html/latest/admin-guide/reporting-issues.html
>
> On 14.01.22 11:56, Charles Keepax wrote:
> > Hi guys,
> >
> > My Zynq based board stopped booting today, a bisect points to this
> > patch:
> >
> > commit 0f153a1b8193 ("usb: chipidea: Set the DT node on the child device")
>
> Thanks for the report.
>
> To be sure this issue doesn't fall through the cracks unnoticed, I'm
> adding it to regzbot, my Linux kernel regression tracking bot:
>
> #regzbot ^introduced 0f153a1b8193
> #regzbot title usb: chipidea: Zynq based board stopped booting today
> #regzbot ignore-activity
>
> Reminder: when fixing the issue, please add a 'Link:' tag with the URL
> to the report (the parent of this mail) using the kernel.org redirector,

'kernel.org redirector' is lore.kernel.org? It would be clearer to
just say that.

> as explained in 'Documentation/process/submitting-patches.rst'. Regzbot
> then will automatically mark the regression as resolved once the fix
> lands in the appropriate tree. For more details about regzbot see footer.

Would it be possible for you to provide the exact link tag in your
reports? That would be easier and less error prone than describing
what to do in prose.

Rob

Re: ChipIdea USB regression

[Thorsten Leemhuis]

On 18.01.22 17:53, Rob Herring wrote:
> On Sun, Jan 16, 2022 at 4:21 AM Thorsten Leemhuis
> <regressions@leemhuis.info> wrote:
>>
>> [TLDR: I'm adding this regression to regzbot, the Linux kernel
>> regression tracking bot; most text you find below is compiled from a few
>> templates paragraphs some of you might have seen already.]
>>
>> Hi, this is your Linux kernel regression tracker speaking.
>>
>> Adding the regression mailing list to the list of recipients, as it
>> should be in the loop for all regressions, as explained here:
>> https://www.kernel.org/doc/html/latest/admin-guide/reporting-issues.html
>>
>> On 14.01.22 11:56, Charles Keepax wrote:
>>> Hi guys,
>>>
>>> My Zynq based board stopped booting today, a bisect points to this
>>> patch:
>>>
>>> commit 0f153a1b8193 ("usb: chipidea: Set the DT node on the child device")
>>
>> Thanks for the report.
>>
>> To be sure this issue doesn't fall through the cracks unnoticed, I'm
>> adding it to regzbot, my Linux kernel regression tracking bot:
>>
>> #regzbot ^introduced 0f153a1b8193
>> #regzbot title usb: chipidea: Zynq based board stopped booting today
>> #regzbot ignore-activity
>>
>> Reminder: when fixing the issue, please add a 'Link:' tag with the URL
>> to the report (the parent of this mail) using the kernel.org redirector,
> 
> 'kernel.org redirector' is lore.kernel.org? It would be clearer to
> just say that.

Yes/No it's lore.kernel.org/r/ (and not lore.kernel.org/list-foo/).
You're right I'll rephrase next time.

>> as explained in 'Documentation/process/submitting-patches.rst'. Regzbot
>> then will automatically mark the regression as resolved once the fix
>> lands in the appropriate tree. For more details about regzbot see footer.
> 
> Would it be possible for you to provide the exact link tag in your
> reports? That would be easier and less error prone than describing
> what to do in prose.

Hmm. The webui already provides this (and other things you likely want
to add) when you show the details for a tracked regression or visit its
individual page:

https://linux-regtracking.leemhuis.info/regzbot/mainline/
https://linux-regtracking.leemhuis.info/regzbot/regression/20220114105620.GK18506@ediswmail.ad.cirrus.com/

I see that it would be convenient for developers and less error prone if
I could mention the proper Link: tag in mails like the one you quoted,
that's why I considered that already. But it would make the regression
tracker's job (aka my "job", which I'm kinda doing in my spare time) yet
again somewhat harder, as I see no easy solution to automate that when
writing these mails (which I do with thunderbird, currently). That's why
I decided to not do that for now, as that job is already hard enough and
I don't want to get burned out by this a second time; and those link
tags are something that were expected from developers even before I came
with regzbot.

But well, maybe over time I can up with some idea to make this easy for
me, then I'll gladly provide that service. One easy way to make this
happen would be: regzbot could send a confirmation mail when it adds a
regression to the list of tracked issues and mention the Link: tag
there. But that would be yet another mail in all out inboxes. But maybe
such a mail would be good for other reasons, too.

Ciao, Thorsten

Re: ChipIdea USB regression

[Rob Herring]

On Tue, Jan 18, 2022 at 11:34 AM Thorsten Leemhuis
<regressions@leemhuis.info> wrote:
>
> On 18.01.22 17:53, Rob Herring wrote:
> > On Sun, Jan 16, 2022 at 4:21 AM Thorsten Leemhuis
> > <regressions@leemhuis.info> wrote:
> >>
> >> [TLDR: I'm adding this regression to regzbot, the Linux kernel
> >> regression tracking bot; most text you find below is compiled from a few
> >> templates paragraphs some of you might have seen already.]
> >>
> >> Hi, this is your Linux kernel regression tracker speaking.
> >>
> >> Adding the regression mailing list to the list of recipients, as it
> >> should be in the loop for all regressions, as explained here:
> >> https://www.kernel.org/doc/html/latest/admin-guide/reporting-issues.html
> >>
> >> On 14.01.22 11:56, Charles Keepax wrote:
> >>> Hi guys,
> >>>
> >>> My Zynq based board stopped booting today, a bisect points to this
> >>> patch:
> >>>
> >>> commit 0f153a1b8193 ("usb: chipidea: Set the DT node on the child device")
> >>
> >> Thanks for the report.
> >>
> >> To be sure this issue doesn't fall through the cracks unnoticed, I'm
> >> adding it to regzbot, my Linux kernel regression tracking bot:
> >>
> >> #regzbot ^introduced 0f153a1b8193
> >> #regzbot title usb: chipidea: Zynq based board stopped booting today
> >> #regzbot ignore-activity
> >>
> >> Reminder: when fixing the issue, please add a 'Link:' tag with the URL
> >> to the report (the parent of this mail) using the kernel.org redirector,
> >
> > 'kernel.org redirector' is lore.kernel.org? It would be clearer to
> > just say that.
>
> Yes/No it's lore.kernel.org/r/ (and not lore.kernel.org/list-foo/).
> You're right I'll rephrase next time.

Or now lore.kernel.org/all/...

> >> as explained in 'Documentation/process/submitting-patches.rst'. Regzbot
> >> then will automatically mark the regression as resolved once the fix
> >> lands in the appropriate tree. For more details about regzbot see footer.
> >
> > Would it be possible for you to provide the exact link tag in your
> > reports? That would be easier and less error prone than describing
> > what to do in prose.
>
> Hmm. The webui already provides this (and other things you likely want
> to add) when you show the details for a tracked regression or visit its
> individual page:
>
> https://linux-regtracking.leemhuis.info/regzbot/mainline/
> https://linux-regtracking.leemhuis.info/regzbot/regression/20220114105620.GK18506@ediswmail.ad.cirrus.com/

That is the link I was originally expecting for when I went back to this thread.

> I see that it would be convenient for developers and less error prone if
> I could mention the proper Link: tag in mails like the one you quoted,
> that's why I considered that already. But it would make the regression
> tracker's job (aka my "job", which I'm kinda doing in my spare time) yet
> again somewhat harder, as I see no easy solution to automate that when
> writing these mails (which I do with thunderbird, currently). That's why
> I decided to not do that for now, as that job is already hard enough and
> I don't want to get burned out by this a second time; and those link
> tags are something that were expected from developers even before I came
> with regzbot.

Fair enough, I thought this was more automated than it is. I have some
scripts for writing replies[1] if that helps. I wrote them because I
couldn't find any that would quote emails. (Maybe because it's a pain
dealing with all the encodings). They are geared toward patches in
terms of trimming the email, but shouldn't be too hard to adapt.

Rob

[1] https://gitlab.com/robherring/pw-utils