From: Charles Keepax <ckeepax@opensource.cirrus.com>
To: <robh@kernel.org>
Cc: <peter.chen@kernel.org>, <gregkh@linuxfoundation.org>,
<linux-usb@vger.kernel.org>, <linux-kernel@vger.kernel.org>
Subject: Re: ChipIdea USB regression
Date: Fri, 14 Jan 2022 11:18:00 +0000 [thread overview]
Message-ID: <20220114111800.GL18506@ediswmail.ad.cirrus.com> (raw)
In-Reply-To: <20220114105620.GK18506@ediswmail.ad.cirrus.com>
On Fri, Jan 14, 2022 at 10:56:20AM +0000, Charles Keepax wrote:
> Hi guys,
>
> My Zynq based board stopped booting today, a bisect points to this
> patch:
>
> commit 0f153a1b8193 ("usb: chipidea: Set the DT node on the child device")
>
> It looks like it gets stuck in some sort of boot loop of doom:
Ok so poking that a little more, I think I can see what happens,
the USB DT node looks like this:
usb0: usb@e0002000 {
compatible = "xlnx,zynq-usb-2.20a", "chipidea,usb2";
status = "disabled";
clocks = <&clkc 28>;
interrupt-parent = <&intc>;
interrupts = <0 21 4>;
reg = <0xe0002000 0x1000>;
phy_type = "ulpi";
};
&usb0 {
status = "okay";
dr_mode = "host";
usb-phy = <&usb_phy0>;
};
So when that patch copies the DT node to the new platform device
in ci_hdrc_add_device it copies the compatible stuff as well as
the IRQ stuff it was targeting, this presumably causes the kernel
to bind a new copy of the driver to that new device, which probes
and calls ci_hdrc_add_device again repeating the process until
it dies.
Kinda looks to me like the best solution might just be to revert
the patch, I am not sure I see how that copy of the DT is supposed
to work?
Thanks,
Charles
next prev parent reply other threads:[~2022-01-14 11:18 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-01-14 10:56 ChipIdea USB regression Charles Keepax
2022-01-14 11:18 ` Charles Keepax [this message]
2022-01-15 15:55 ` Rob Herring
2022-01-17 9:26 ` Charles Keepax
2022-01-17 9:55 ` Charles Keepax
2022-01-18 14:39 ` Rob Herring
2022-01-18 16:16 ` Charles Keepax
2022-01-16 10:21 ` Thorsten Leemhuis
2022-01-18 16:53 ` Rob Herring
2022-01-18 17:33 ` Thorsten Leemhuis
2022-01-18 18:37 ` Rob Herring
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220114111800.GL18506@ediswmail.ad.cirrus.com \
--to=ckeepax@opensource.cirrus.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=peter.chen@kernel.org \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).