From: "Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>
To: Nikita Travkin <nikita@trvn.ru>
Cc: thierry.reding@gmail.com, lee.jones@linaro.org,
robh+dt@kernel.org, sboyd@kernel.org, linus.walleij@linaro.org,
masneyb@onstation.org, linux-pwm@vger.kernel.org,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
~postmarketos/upstreaming@lists.sr.ht
Subject: Re: [PATCH v2 0/2] Clock based PWM output driver
Date: Mon, 17 Jan 2022 13:10:00 +0100 [thread overview]
Message-ID: <20220117121000.3lgohyenamvwmcur@pengutronix.de> (raw)
In-Reply-To: <20211213150335.51888-1-nikita@trvn.ru>
[-- Attachment #1: Type: text/plain, Size: 1323 bytes --]
Hello Nikita,
On Mon, Dec 13, 2021 at 08:03:33PM +0500, Nikita Travkin wrote:
> This series introduces an "adapter" driver that allows PWM consumers
> to control clock outputs with duty-cycle control.
>
> Some platforms (e.g. some Qualcomm chipsets) have "General Purpose"
> clocks that can be muxed to GPIO outputs and used as PWM outputs.
> Those outputs may be connected to various peripherals such as
> leds in display backlight or haptic feedback motor driver.
>
> To avoid re-implementing every single PWM consumer driver with clk
> support (like in [1]) and don't put the burden of providing the PWM
> sources on the clock drivers (as was proposed in [2]), clk based
> pwm controller driver is introduced.
>
> There is an existing driver that provides the opposite function
> in drivers/clk/clk-pwm.c with a compatible "pwm-clock" so the new
> driver uses the opposite naming scheme: drivers/pwm/pwm-clk.c
> and compatible "clk-pwm".
You got some feedback on your patches and didn't respond to it. Are you
interested to improve your patch set? If yes, I'm willing to review more
deeply. If not, I'm not.
Best regards
Uwe
--
Pengutronix e.K. | Uwe Kleine-König |
Industrial Linux Solutions | https://www.pengutronix.de/ |
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
next prev parent reply other threads:[~2022-01-17 12:10 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-12-13 15:03 [PATCH v2 0/2] Clock based PWM output driver Nikita Travkin
2021-12-13 15:03 ` [PATCH v2 1/2] dt-bindings: pwm: Document clk based PWM controller Nikita Travkin
2021-12-13 16:20 ` Rob Herring
2021-12-13 15:03 ` [PATCH v2 2/2] pwm: Add clock based PWM output driver Nikita Travkin
2021-12-14 17:03 ` kernel test robot
2021-12-14 19:17 ` kernel test robot
2022-01-17 15:58 ` Uwe Kleine-König
2022-01-17 18:04 ` Nikita Travkin
2022-01-17 20:04 ` Uwe Kleine-König
2022-01-17 12:10 ` Uwe Kleine-König [this message]
2022-01-17 13:09 ` [PATCH v2 0/2] Clock " Nikita Travkin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220117121000.3lgohyenamvwmcur@pengutronix.de \
--to=u.kleine-koenig@pengutronix.de \
--cc=devicetree@vger.kernel.org \
--cc=lee.jones@linaro.org \
--cc=linus.walleij@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pwm@vger.kernel.org \
--cc=masneyb@onstation.org \
--cc=nikita@trvn.ru \
--cc=robh+dt@kernel.org \
--cc=sboyd@kernel.org \
--cc=thierry.reding@gmail.com \
--cc=~postmarketos/upstreaming@lists.sr.ht \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).