Re: Problems with rcutorture on ppc64le: allmodconfig(2) and other failures

From: "Paul E. McKenney" <paulmck@kernel.org>
To: Paul Menzel <pmenzel@molgen.mpg.de>
Cc: Zhouyi Zhou <zhouzhouyi@gmail.com>,
	Josh Triplett <josh@joshtriplett.org>, rcu <rcu@vger.kernel.org>,
	linux-kselftest@vger.kernel.org,
	LKML <linux-kernel@vger.kernel.org>
Subject: Re: Problems with rcutorture on ppc64le: allmodconfig(2) and other failures
Date: Tue, 18 Jan 2022 15:46:56 -0800	[thread overview]
Message-ID: <20220118234656.GA3120763@paulmck-ThinkPad-P17-Gen-1> (raw)
In-Reply-To: <20220118172904.GG947480@paulmck-ThinkPad-P17-Gen-1>

On Tue, Jan 18, 2022 at 09:29:04AM -0800, Paul E. McKenney wrote:
> On Tue, Jan 18, 2022 at 08:56:24AM +0100, Paul Menzel wrote:
> > Dear Zhouyi,
> > 
> > 
> > Thank you for your quick response.
> > 
> > 
> > Am 18.01.22 um 08:34 schrieb Zhouyi Zhou:
> > 
> > > I have studied the rcu torture test recently. I am also interested in
> > > this topic.
> > > But I can't open
> > > [1]: https://owww.molgen.mpg.de/~pmenzel/allmodconf-Make.out.txt
> > > [2]: https://owww.molgen.mpg.de/~pmenzel/rcutorture-log.txt
> > 
> > Sorry, about that. I should have checked those. I had put them into a
> > directory:
> > 
> > [1]: https://owww.molgen.mpg.de/~pmenzel/rcutorture/allmodconf-Make.out.txt
> > [2]: https://owww.molgen.mpg.de/~pmenzel/rcutorture/rcutorture-log.txt
> > 
> > I am going to try to test your suggestions at the end of the day.
> 
> On x86 rcutorture builds successfully.  However, allmodconfig
> on semi-recent -next got me "Can't open perl script
> "./usr/include/headers_check.pl": No such file or directory".
> Which might well be a local problem or might well be fixed by now.

Not fixed as of next-20220118.  Chasing it down...  ;-)

> Either way, it looks like I need to upgrade the torture.sh script's
> checks for failed builds.  Thank you for reporting this!

Does this make torture.sh more reliably report build failures?

						Thanx, Paul

------------------------------------------------------------------------

commit 0d302830515307ceb58e89d5fb91e81b6d22e0bf
Author: Paul E. McKenney <paulmck@kernel.org>
Date:   Tue Jan 18 15:40:49 2022 -0800

    torture: Make kvm-find-errors.sh notice missing vmlinux file
    
    Currently, an obtuse compiler diagnostic can fool kvm-find-errors.sh
    into believing that the build was successful.  This commit therefore
    adds a check for a missing vmlinux file.
    
    Link: https://lore.kernel.org/lkml/36bd91e4-8eda-5677-7fde-40295932a640@molgen.mpg.de/
    Reported-by: Paul Menzel <pmenzel@molgen.mpg.de>
    Signed-off-by: Paul E. McKenney <paulmck@kernel.org>

diff --git a/tools/testing/selftests/rcutorture/bin/kvm-find-errors.sh b/tools/testing/selftests/rcutorture/bin/kvm-find-errors.sh
index 2e9e9e2eedb69..7d3e11a6b8290 100755
--- a/tools/testing/selftests/rcutorture/bin/kvm-find-errors.sh
+++ b/tools/testing/selftests/rcutorture/bin/kvm-find-errors.sh
@@ -30,10 +30,15 @@ editor=${EDITOR-vi}
 files=
 for i in ${rundir}/*/Make.out
 do
+	scenariodir="`dirname $i`"
 	if egrep -q "error:|warning:|^ld: .*undefined reference to" < $i
 	then
 		egrep "error:|warning:|^ld: .*undefined reference to" < $i > $i.diags
 		files="$files $i.diags $i"
+	elif ! test -f ${scenariodir}/vmlinux
+	then
+		echo No ${scenariodir}/vmlinux file > $i.diags
+		files="$files $i.diags $i"
 	fi
 done
 if test -n "$files"
