From: Jan Kara <jack@suse.cz>
To: Yang Li <yang.lee@linux.alibaba.com>
Cc: jack@suse.cz, amir73il@gmail.com, repnop@google.com,
linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org,
Abaci Robot <abaci@linux.alibaba.com>
Subject: Re: [PATCH -next] fanotify: remove variable set but not used
Date: Thu, 20 Jan 2022 13:57:45 +0100 [thread overview]
Message-ID: <20220120125745.axdqtnasbivkulsm@quack3.lan> (raw)
In-Reply-To: <20220112085403.74670-1-yang.lee@linux.alibaba.com>
On Wed 12-01-22 16:54:03, Yang Li wrote:
> The code that uses the pointer info has been removed in
> 'https://lore.kernel.org/all/20211129201537.1932819-11-amir73il@gmail.com/'
> and fanotify_event_info() doesn't change 'event', so the declaration and
> assignment of info can be removed.
>
> Eliminate the following clang warning:
> fs/notify/fanotify/fanotify_user.c:161:24: warning: variable ‘info’ set
> but not used
>
> Reported-by: Abaci Robot <abaci@linux.alibaba.com>
> Signed-off-by: Yang Li <yang.lee@linux.alibaba.com>
Thanks! I've added the patch to my tree.
Honza
> ---
> fs/notify/fanotify/fanotify_user.c | 3 ---
> 1 file changed, 3 deletions(-)
>
> diff --git a/fs/notify/fanotify/fanotify_user.c b/fs/notify/fanotify/fanotify_user.c
> index 73b1615f9d96..1026f67b1d1e 100644
> --- a/fs/notify/fanotify/fanotify_user.c
> +++ b/fs/notify/fanotify/fanotify_user.c
> @@ -158,7 +158,6 @@ static size_t fanotify_event_len(unsigned int info_mode,
> struct fanotify_event *event)
> {
> size_t event_len = FAN_EVENT_METADATA_LEN;
> - struct fanotify_info *info;
> int fh_len;
> int dot_len = 0;
>
> @@ -168,8 +167,6 @@ static size_t fanotify_event_len(unsigned int info_mode,
> if (fanotify_is_error_event(event->mask))
> event_len += FANOTIFY_ERROR_INFO_LEN;
>
> - info = fanotify_event_info(event);
> -
> if (fanotify_event_has_any_dir_fh(event)) {
> event_len += fanotify_dir_name_info_len(event);
> } else if ((info_mode & FAN_REPORT_NAME) &&
> --
> 2.20.1.7.g153144c
>
--
Jan Kara <jack@suse.com>
SUSE Labs, CR
prev parent reply other threads:[~2022-01-20 12:57 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-01-12 8:54 [PATCH -next] fanotify: remove variable set but not used Yang Li
2022-01-20 12:57 ` Jan Kara [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220120125745.axdqtnasbivkulsm@quack3.lan \
--to=jack@suse.cz \
--cc=abaci@linux.alibaba.com \
--cc=amir73il@gmail.com \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=repnop@google.com \
--cc=yang.lee@linux.alibaba.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).