From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 631D2C433EF for ; Sat, 22 Jan 2022 03:18:49 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232281AbiAVDSS (ORCPT ); Fri, 21 Jan 2022 22:18:18 -0500 Received: from mga01.intel.com ([192.55.52.88]:40585 "EHLO mga01.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231265AbiAVDSS (ORCPT ); Fri, 21 Jan 2022 22:18:18 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1642821498; x=1674357498; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=XVbcynuBp7YPpn7VkTXTU3PKbJA8Lw5NE5fezak49kc=; b=Jdt9gOEYRtZSGF++AZFBJ3rKmglLEyszHN9Q5c6Y5o1gAYq7vO6pP+03 irOW80sWkCah8y7+N895BUDzo3qukA+V9UtD7fKHgHGVVN3L5NRmcIX0O 95umfXBgIfFKTqFz94+rkp2El+APG6dUb4w3U/lBoFs6hRr7YAy4W+mP+ /+uIOcVe60nZzdxV/CdLDNLflRdgN1yYd+YPBWiND7VDvYdnov9PoLjsQ kZ0frx/CV/9GRX0F5e26/4iCuLO0/lbo2cxqgOKilMtgNmiEZ9HWsOCjX T6i5Xj7vtStmj2VvoUhl+5XpY99j27xB53HWe8VdJOGHptnMYZmkcEIL6 g==; X-IronPort-AV: E=McAfee;i="6200,9189,10234"; a="270214646" X-IronPort-AV: E=Sophos;i="5.88,307,1635231600"; d="scan'208";a="270214646" Received: from orsmga005.jf.intel.com ([10.7.209.41]) by fmsmga101.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 21 Jan 2022 19:18:17 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.88,307,1635231600"; d="scan'208";a="694844988" Received: from lkp-server01.sh.intel.com (HELO 276f1b88eecb) ([10.239.97.150]) by orsmga005.jf.intel.com with ESMTP; 21 Jan 2022 19:18:15 -0800 Received: from kbuild by 276f1b88eecb with local (Exim 4.92) (envelope-from ) id 1nB6us-000FxN-Dy; Sat, 22 Jan 2022 03:18:14 +0000 Date: Sat, 22 Jan 2022 11:17:37 +0800 From: kernel test robot To: Hannes Reinecke Cc: kbuild-all@lists.01.org, linux-kernel@vger.kernel.org, Christoph Hellwig , Chaitanya Kulkarni , Keith Busch , Jens Axboe , Sagi Grimberg , linux-nvme@lists.infradead.org Subject: [PATCH] nvme-fabrics: fix returnvar.cocci warnings Message-ID: <20220122031737.GA31599@fba2a898af35> References: <202201221116.hWZkKqts-lkp@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <202201221116.hWZkKqts-lkp@intel.com> User-Agent: Mutt/1.10.1 (2018-07-13) Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: kernel test robot drivers/nvme/host/fabrics.c:1095:5-8: Unneeded variable: "ret". Return "0" on line 1109 Remove unneeded variable used to store return value. Generated by: scripts/coccinelle/misc/returnvar.cocci Fixes: f18ee3d98815 ("nvme-fabrics: print out valid arguments when reading from /dev/nvme-fabrics") CC: Hannes Reinecke Reported-by: kernel test robot Signed-off-by: kernel test robot --- tree: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master head: 9b57f458985742bd1c585f4c7f36d04634ce1143 commit: f18ee3d988157ebcadc9b7e5fd34811938f50223 nvme-fabrics: print out valid arguments when reading from /dev/nvme-fabrics :::::: branch date: 13 hours ago :::::: commit date: 4 weeks ago fabrics.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) --- a/drivers/nvme/host/fabrics.c +++ b/drivers/nvme/host/fabrics.c @@ -1092,7 +1092,6 @@ static void __nvmf_concat_opt_tokens(str static int nvmf_dev_show(struct seq_file *seq_file, void *private) { struct nvme_ctrl *ctrl; - int ret = 0; mutex_lock(&nvmf_dev_mutex); ctrl = seq_file->private; @@ -1106,7 +1105,7 @@ static int nvmf_dev_show(struct seq_file out_unlock: mutex_unlock(&nvmf_dev_mutex); - return ret; + return 0; } static int nvmf_dev_open(struct inode *inode, struct file *file)