From: Eugene Shalygin <eugene.shalygin@gmail.com>
To: eugene.shalygin@gmail.com
Cc: andy.shevchenko@gmail.com, pauk.denis@gmail.com,
oleksandr@natalenko.name, Jean Delvare <jdelvare@suse.com>,
Guenter Roeck <linux@roeck-us.net>,
linux-kernel@vger.kernel.org, linux-hwmon@vger.kernel.org
Subject: [ASUS EC Sensors v8 0/3]
Date: Mon, 24 Jan 2022 02:56:42 +0100 [thread overview]
Message-ID: <20220124015658.687309-1-eugene.shalygin@gmail.com> (raw)
This patchset replaces the HWMON asus_wmi_ec_sensors driver with
an implementation that does not use WMI but queries the embedded
controller directly.
That provides two enhancements: sensor reading became quicker (on some
systems or kernel configuration it took almost a full second to read
all the sensors, that transfers less than 15 bytes of data), the driver
became more fexible. The driver now relies on ACPI mutex to lock access
to the EC, in the same way as the WMI DSDT code does.
Changes in v8:
- Fixed formatting (removed doc comments, removed redundant new line).
- Changed hwmon device name (asus_ec_sensors -> asusec) removing
unnecessary "sensors" word.
Changes in v7:
- Add suport for the ROG STRIX X570-F GAMING board.
- Add the __init attribute to two more functions.
Changes in v6:
- Fixed hwmon device name replacing dashes with underscores.
- Removed module verion.
- Fixed condition for asus_wmi_ec_Sensors in KBuild.
Changes in v5:
- Place the sensors bitset directly into the driver_data field of the
dmi_system_id struct.
- Replace doc comments with regular ones.
Changes in v4:
- Deprecate the wmi driver rather than removing it.
Changes in v3:
- Remove BIOS version checks and BIOS version dependent mutex path.
Changes in v2:
- Replace sensor flags enum with bitset
- Replace module init/probe functions with module_platform_driver_probe
and ask the platform drivers framework to load the driver when ACPI
EC is found (ACPI ID "PNP0C09").
- Extend board data with BIOS version attribute for the mutex path to be
BIOS version dependent.
- Add module parameter to override the mutex path.
Eugene Shalygin (3):
hwmon: (asus-ec-sensors) add driver for ASUS EC
hwmon: (asus-ec-sensors) update documentation
hwmon: deprecate asis_wmi_ec_sensors driver
Documentation/hwmon/asus_ec_sensors.rst | 52 ++
Documentation/hwmon/asus_wmi_ec_sensors.rst | 38 --
MAINTAINERS | 6 +
drivers/hwmon/Kconfig | 16 +-
drivers/hwmon/Makefile | 1 +
drivers/hwmon/asus-ec-sensors.c | 694 ++++++++++++++++++++
6 files changed, 768 insertions(+), 39 deletions(-)
create mode 100644 Documentation/hwmon/asus_ec_sensors.rst
delete mode 100644 Documentation/hwmon/asus_wmi_ec_sensors.rst
create mode 100644 drivers/hwmon/asus-ec-sensors.c
--
2.34.1
next reply other threads:[~2022-01-24 1:57 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-01-24 1:56 Eugene Shalygin [this message]
2022-01-24 1:56 ` [ASUS EC Sensors v8 1/3] hwmon: (asus-ec-sensors) add driver for ASUS EC Eugene Shalygin
2022-01-25 8:49 ` Oleksandr Natalenko
2022-01-24 1:56 ` [ASUS EC Sensors v8 2/3] hwmon: (asus-ec-sensors) update documentation Eugene Shalygin
2022-01-25 8:48 ` Oleksandr Natalenko
2022-01-24 1:56 ` [ASUS EC Sensors v8 3/3] hwmon: deprecate asis_wmi_ec_sensors driver Eugene Shalygin
2022-01-25 8:47 ` Oleksandr Natalenko
2022-02-02 23:58 ` [ASUS EC Sensors v8 0/3] Eugene Shalygin
2022-02-03 1:10 ` Guenter Roeck
2022-02-03 1:16 ` Eugene Shalygin
2022-02-03 3:41 ` Guenter Roeck
2022-02-03 3:48 ` Eugene Shalygin
2022-02-03 7:09 ` Oleksandr Natalenko
2022-02-03 18:54 ` Guenter Roeck
2022-02-03 20:01 ` Eugene Shalygin
2022-02-03 20:24 ` Denis Pauk
2022-02-03 20:55 ` Eugene Shalygin
2022-02-04 20:13 ` Eugene Shalygin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220124015658.687309-1-eugene.shalygin@gmail.com \
--to=eugene.shalygin@gmail.com \
--cc=andy.shevchenko@gmail.com \
--cc=jdelvare@suse.com \
--cc=linux-hwmon@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@roeck-us.net \
--cc=oleksandr@natalenko.name \
--cc=pauk.denis@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).