From: Jakub Kicinski <kuba@kernel.org>
To: Dan Carpenter <dan.carpenter@oracle.com>
Cc: Colin Ian King <colin.i.king@gmail.com>,
"David S . Miller" <davem@davemloft.net>,
netdev@vger.kernel.org, linux-parisc@vger.kernel.org,
kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] net: tulip: remove redundant assignment to variable new_csr6
Date: Tue, 25 Jan 2022 07:45:12 -0800 [thread overview]
Message-ID: <20220125074512.73cc5cec@kicinski-fedora-PC1C0HJN.hsd1.ca.comcast.net> (raw)
In-Reply-To: <20220125141401.GV1951@kadam>
On Tue, 25 Jan 2022 17:14:01 +0300 Dan Carpenter wrote:
> You're looking at the wrong function. This is pnic_do_nway() and you're
> looking at pnic_timer().
Ah, that explains it! Thanks, applied now.
> Of course, Colin's patch assumes the current behavior is correct... I
> guess the current behavior can't be that terrible since it predates git
> and no one has complained.
Entirely possible this driver was never used in the git era.
prev parent reply other threads:[~2022-01-25 15:49 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-01-23 18:34 [PATCH] net: tulip: remove redundant assignment to variable new_csr6 Colin Ian King
2022-01-24 18:30 ` Jakub Kicinski
2022-01-25 14:14 ` Dan Carpenter
2022-01-25 15:45 ` Jakub Kicinski [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220125074512.73cc5cec@kicinski-fedora-PC1C0HJN.hsd1.ca.comcast.net \
--to=kuba@kernel.org \
--cc=colin.i.king@gmail.com \
--cc=dan.carpenter@oracle.com \
--cc=davem@davemloft.net \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-parisc@vger.kernel.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).