From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id F1B82C433FE for ; Tue, 25 Jan 2022 13:09:41 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1575405AbiAYNJc (ORCPT ); Tue, 25 Jan 2022 08:09:32 -0500 Received: from smtp-out2.suse.de ([195.135.220.29]:57222 "EHLO smtp-out2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1385958AbiAYNFk (ORCPT ); Tue, 25 Jan 2022 08:05:40 -0500 Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id 3C3081F381; Tue, 25 Jan 2022 13:05:34 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1643115934; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=kvqxhztJgAeV91/7V7GT00sAA8oyoJf3yoHjPQWb5nk=; b=oqvBcD8RKi/bikFf+h5ikyaDXqBfmyRjnSm3hR5qoyrd3amMZnB9yzF0FkEm4o7HTUOwAd jHOnMexHwJKDWor20M8Dp9zRshSDFQRlOjkob4VYJYafe+6jxbDIepgaRpt9XkLjOHoGmz //sof2f+2mud+hTHVN3leMxz8cWq8Uk= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1643115934; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=kvqxhztJgAeV91/7V7GT00sAA8oyoJf3yoHjPQWb5nk=; b=1rutgpif2Ya6gDZ/DBaIAW65r8Csve7dEoKO8EgmVXbAkgQa2pZcqWwRAHS6l+mPSUf136 0Pxut6ZwVVparxAg== Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 7545D13DE2; Tue, 25 Jan 2022 13:05:33 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id F8RCGp3172FlQAAAMHmgww (envelope-from ); Tue, 25 Jan 2022 13:05:33 +0000 Date: Tue, 25 Jan 2022 14:05:29 +0100 From: Jean Delvare To: Terry Bowman Cc: , , , , , , , , , , , , , Subject: Re: [PATCH v3 1/4] Watchdog: sp5100_tco: Move timer initialization into function Message-ID: <20220125140529.5ce10957@endymion> In-Reply-To: <20220118202234.410555-2-terry.bowman@amd.com> References: <20220118202234.410555-1-terry.bowman@amd.com> <20220118202234.410555-2-terry.bowman@amd.com> Organization: SUSE Linux X-Mailer: Claws Mail 3.18.0 (GTK+ 2.24.32; x86_64-suse-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, 18 Jan 2022 14:22:31 -0600, Terry Bowman wrote: > Refactor driver's timer initialization into new function. This is needed > inorder to support adding new device layouts while using common timer > initialization. > > Co-developed-by: Robert Richter > Signed-off-by: Robert Richter > Signed-off-by: Terry Bowman > To: Guenter Roeck > To: linux-watchdog@vger.kernel.org > To: Jean Delvare > To: linux-i2c@vger.kernel.org > To: Wolfram Sang > To: Andy Shevchenko > To: Rafael J. Wysocki > Cc: linux-kernel@vger.kernel.org > Cc: Wim Van Sebroeck > Cc: Robert Richter > Cc: Thomas Lendacky > --- > drivers/watchdog/sp5100_tco.c | 65 +++++++++++++++++++---------------- > 1 file changed, 36 insertions(+), 29 deletions(-) > (...) Except for the issues already mentioned by Andy, looks good to me. Reviewed-by: Jean Delvare -- Jean Delvare SUSE L3 Support