From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id A0818C5AC75 for ; Wed, 26 Jan 2022 02:28:39 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S236401AbiAZC2j (ORCPT ); Tue, 25 Jan 2022 21:28:39 -0500 Received: from mga07.intel.com ([134.134.136.100]:65385 "EHLO mga07.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S236373AbiAZC2c (ORCPT ); Tue, 25 Jan 2022 21:28:32 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1643164112; x=1674700112; h=date:from:to:cc:subject:message-id:mime-version; bh=pdDFtHOk/10FEgKxvCfG9D3qL8BaoGrFlV86ZE2rz/U=; b=UYedu0zL7mdPYMkkX4tZ2kSoDeznAyHmWaWG7S1GifXCgOQWN733fZgi Pj5AW8bXBL9sTVUdx5+hT8pUW24vN15416kUDRbxrYEmdkmURHiU7wco2 WL9uwA62R6ZllWlTG3IxHmFByDDiyaemNEcU/TiSRwywj0hbw/kSc2yEl WOU5kbLjSfj9XN978I/MdDOU1RTH2N0zQWSNaZqdEBLtW+nhlABf1f6/L vMRMtzJDlS57yLDBQOFA3Pd49iNAPAvaSclSll76acVB9VrkW2BNFqEk8 HezG5Qi8XJide/jJS6L+/+5MCd8Kf2sdnoUv0p3W0mhgU57rmvauPeJfc A==; X-IronPort-AV: E=McAfee;i="6200,9189,10238"; a="309781002" X-IronPort-AV: E=Sophos;i="5.88,316,1635231600"; d="scan'208";a="309781002" Received: from orsmga002.jf.intel.com ([10.7.209.21]) by orsmga105.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 25 Jan 2022 18:28:32 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.88,316,1635231600"; d="scan'208";a="495217835" Received: from lkp-server01.sh.intel.com (HELO 276f1b88eecb) ([10.239.97.150]) by orsmga002.jf.intel.com with ESMTP; 25 Jan 2022 18:28:30 -0800 Received: from kbuild by 276f1b88eecb with local (Exim 4.92) (envelope-from ) id 1nCY2v-000Kg4-NC; Wed, 26 Jan 2022 02:28:29 +0000 Date: Wed, 26 Jan 2022 10:28:10 +0800 From: kernel test robot To: Alexander Aring Cc: kbuild-all@lists.01.org, linux-kernel@vger.kernel.org, David Teigland Subject: fs/dlm/midcomms.c:913:22: sparse: sparse: restricted __le32 degrades to integer Message-ID: <202201260940.QT9lksNM-lkp@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline User-Agent: Mutt/1.10.1 (2018-07-13) Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org tree: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master head: 0280e3c58f92b2fe0e8fbbdf8d386449168de4a8 commit: 658bd576f95ed597e519cdadf1c86ac87c17aea5 fs: dlm: move version conversion to compile time date: 3 months ago config: x86_64-rhel-8.3-kselftests (https://download.01.org/0day-ci/archive/20220126/202201260940.QT9lksNM-lkp@intel.com/config) compiler: gcc-9 (Debian 9.3.0-22) 9.3.0 reproduce: # apt-get install sparse # sparse version: v0.6.4-dirty # https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=658bd576f95ed597e519cdadf1c86ac87c17aea5 git remote add linus https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git git fetch --no-tags linus master git checkout 658bd576f95ed597e519cdadf1c86ac87c17aea5 # save the config file to linux build tree mkdir build_dir make W=1 C=1 CF='-fdiagnostic-prefix -D__CHECK_ENDIAN__' O=build_dir ARCH=x86_64 SHELL=/bin/bash If you fix the issue, kindly add following tag as appropriate Reported-by: kernel test robot sparse warnings: (new ones prefixed by >>) fs/dlm/midcomms.c:213:1: sparse: sparse: symbol '__srcu_struct_nodes_srcu' was not declared. Should it be static? fs/dlm/midcomms.c:570:25: sparse: sparse: cast to restricted __le32 fs/dlm/midcomms.c:678:19: sparse: sparse: cast to restricted __le16 fs/dlm/midcomms.c:680:16: sparse: sparse: cast to restricted __le16 fs/dlm/midcomms.c:718:27: sparse: sparse: cast to restricted __le16 fs/dlm/midcomms.c:737:25: sparse: sparse: cast to restricted __le32 fs/dlm/midcomms.c:747:25: sparse: sparse: cast to restricted __le32 fs/dlm/midcomms.c:756:23: sparse: sparse: cast to restricted __le32 fs/dlm/midcomms.c:766:42: sparse: sparse: cast to restricted __le16 fs/dlm/midcomms.c:769:26: sparse: sparse: cast to restricted __le16 fs/dlm/midcomms.c:804:23: sparse: sparse: cast to restricted __le32 fs/dlm/midcomms.c:838:27: sparse: sparse: cast to restricted __le16 fs/dlm/midcomms.c:898:26: sparse: sparse: cast to restricted __le16 fs/dlm/midcomms.c:920:25: sparse: sparse: cast to restricted __le32 >> fs/dlm/midcomms.c:913:22: sparse: sparse: restricted __le32 degrades to integer fs/dlm/midcomms.c:916:22: sparse: sparse: restricted __le32 degrades to integer fs/dlm/midcomms.c:1056:20: sparse: sparse: context imbalance in 'dlm_midcomms_get_mhandle' - wrong count at exit fs/dlm/midcomms.c: note: in included file (through include/linux/notifier.h, arch/x86/include/asm/uprobes.h, include/linux/uprobes.h, ...): include/linux/srcu.h:188:9: sparse: sparse: context imbalance in 'dlm_midcomms_commit_mhandle' - unexpected unlock vim +913 fs/dlm/midcomms.c 871 872 /* 873 * Called from the low-level comms layer to process a buffer of 874 * commands. 875 */ 876 877 int dlm_process_incoming_buffer(int nodeid, unsigned char *buf, int len) 878 { 879 const unsigned char *ptr = buf; 880 const struct dlm_header *hd; 881 uint16_t msglen; 882 int ret = 0; 883 884 while (len >= sizeof(struct dlm_header)) { 885 hd = (struct dlm_header *)ptr; 886 887 /* no message should be more than DLM_MAX_SOCKET_BUFSIZE or 888 * less than dlm_header size. 889 * 890 * Some messages does not have a 8 byte length boundary yet 891 * which can occur in a unaligned memory access of some dlm 892 * messages. However this problem need to be fixed at the 893 * sending side, for now it seems nobody run into architecture 894 * related issues yet but it slows down some processing. 895 * Fixing this issue should be scheduled in future by doing 896 * the next major version bump. 897 */ 898 msglen = le16_to_cpu(hd->h_length); 899 if (msglen > DLM_MAX_SOCKET_BUFSIZE || 900 msglen < sizeof(struct dlm_header)) { 901 log_print("received invalid length header: %u from node %d, will abort message parsing", 902 msglen, nodeid); 903 return -EBADMSG; 904 } 905 906 /* caller will take care that leftover 907 * will be parsed next call with more data 908 */ 909 if (msglen > len) 910 break; 911 912 switch (hd->h_version) { > 913 case cpu_to_le32(DLM_VERSION_3_1): 914 dlm_midcomms_receive_buffer_3_1((union dlm_packet *)ptr, nodeid); 915 break; 916 case cpu_to_le32(DLM_VERSION_3_2): 917 dlm_midcomms_receive_buffer_3_2((union dlm_packet *)ptr, nodeid); 918 break; 919 default: 920 log_print("received invalid version header: %u from node %d, will skip this message", 921 le32_to_cpu(hd->h_version), nodeid); 922 break; 923 } 924 925 ret += msglen; 926 len -= msglen; 927 ptr += msglen; 928 } 929 930 return ret; 931 } 932 --- 0-DAY CI Kernel Test Service, Intel Corporation https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org