From: Sudeep Holla <sudeep.holla@arm.com>
To: Kohei Tarumizu <tarumizu.kohei@fujitsu.com>
Cc: catalin.marinas@arm.com, will@kernel.org, tglx@linutronix.de,
Sudeep Holla <sudeep.holla@arm.com>,
mingo@redhat.com, bp@alien8.de, dave.hansen@linux.intel.com,
x86@kernel.org, hpa@zytor.com,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 5/8] arm64: Create cache sysfs directory without ACPI PPTT for hardware prefetch control
Date: Wed, 26 Jan 2022 10:36:14 +0000 [thread overview]
Message-ID: <20220126103614.pcrcuc2kzklkq3xa@bogus> (raw)
In-Reply-To: <20220125071414.811344-6-tarumizu.kohei@fujitsu.com>
On Tue, Jan 25, 2022 at 04:14:11PM +0900, Kohei Tarumizu wrote:
> This patch will create a cache sysfs directory without ACPI PPTT if
> the CONFIG_HWPF_CONTROL is true.
>
> Hardware prefetch control driver need cache sysfs directory and cache
> level/type information. In ARM processor, these information can be
> obtained from the register even without PPTT. Therefore, we set the
> cpu_map_populated to true to create cache sysfs directory if the
> machine doesn't have PPTT.
I am assuming this is ACPI enabled system.
This looks bit hacky in my opinion. Before I explore better way of adding it,
I would like to check if you have explored ways to add PPTT reading these
registers from UEFI/EDK2 as PPTT has other topology information which you will
need anyways. That would simplify handling of these cacheinfo sysfs in the
kernel. Let me know what are your thoughts ?
--
Regards,
Sudeep
next prev parent reply other threads:[~2022-01-26 10:36 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-01-25 7:14 [PATCH 0/8] Add hardware prefetch control driver for arm64 and x86 Kohei Tarumizu
2022-01-25 7:14 ` [PATCH 1/8] drivers: base: Add hardware prefetch control core driver Kohei Tarumizu
2022-01-25 7:14 ` [PATCH 2/8] drivers: base: Add Kconfig/Makefile to build " Kohei Tarumizu
2022-01-25 7:14 ` [PATCH 3/8] arm64: Add hardware prefetch control support for ARM64 Kohei Tarumizu
2022-01-25 7:14 ` [PATCH 4/8] arm64: Add Kconfig/Makefile to build hardware prefetch control driver Kohei Tarumizu
2022-01-29 17:03 ` Randy Dunlap
2022-02-01 12:04 ` tarumizu.kohei
2022-01-25 7:14 ` [PATCH 5/8] arm64: Create cache sysfs directory without ACPI PPTT for hardware prefetch control Kohei Tarumizu
2022-01-26 10:36 ` Sudeep Holla [this message]
2022-02-01 11:56 ` tarumizu.kohei
2022-07-07 14:37 ` Jeremy Linton
2022-07-07 14:44 ` Sudeep Holla
2022-07-08 10:21 ` tarumizu.kohei
2022-01-25 7:14 ` [PATCH 6/8] x86: Add hardware prefetch control support for x86 Kohei Tarumizu
2022-01-25 7:14 ` [PATCH 7/8] x86: Add Kconfig/Makefile to build hardware prefetch control driver Kohei Tarumizu
2022-01-25 7:14 ` [PATCH 8/8] docs: ABI: Add sysfs documentation interface of " Kohei Tarumizu
2022-01-25 15:12 ` [PATCH 0/8] Add hardware prefetch control driver for arm64 and x86 Dave Hansen
2022-01-26 9:24 ` tarumizu.kohei
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220126103614.pcrcuc2kzklkq3xa@bogus \
--to=sudeep.holla@arm.com \
--cc=bp@alien8.de \
--cc=catalin.marinas@arm.com \
--cc=dave.hansen@linux.intel.com \
--cc=hpa@zytor.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=tarumizu.kohei@fujitsu.com \
--cc=tglx@linutronix.de \
--cc=will@kernel.org \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).