From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 128EBC28CF5 for ; Wed, 26 Jan 2022 10:42:07 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S240099AbiAZKmG convert rfc822-to-8bit (ORCPT ); Wed, 26 Jan 2022 05:42:06 -0500 Received: from relay9-d.mail.gandi.net ([217.70.183.199]:49519 "EHLO relay9-d.mail.gandi.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S240080AbiAZKmF (ORCPT ); Wed, 26 Jan 2022 05:42:05 -0500 Received: (Authenticated sender: miquel.raynal@bootlin.com) by mail.gandi.net (Postfix) with ESMTPSA id 41EA1FF80C; Wed, 26 Jan 2022 10:42:01 +0000 (UTC) Date: Wed, 26 Jan 2022 11:42:00 +0100 From: Miquel Raynal To: Manivannan Sadhasivam Cc: Konrad Dybcio , ~postmarketos/upstreaming@lists.sr.ht, martin.botka@somainline.org, angelogioacchino.delregno@somainline.org, marijn.suijten@somainline.org, jamipkettunen@somainline.org, Richard Weinberger , Vignesh Raghavendra , linux-mtd@lists.infradead.org, linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org, mdalam@codeaurora.org, sricharan@codeaurora.org Subject: Re: [PATCH] mtd: nand: raw: qcom_nandc: Don't clear_bam_transaction on READID Message-ID: <20220126114200.4cc3c21b@xps13> In-Reply-To: <20220126103316.GA212068@thinkpad> References: <20220113184427.2259509-1-konrad.dybcio@somainline.org> <20220114082718.32a2fc83@xps13> <20220126111613.3ab0021e@xps13> <20220126103316.GA212068@thinkpad> Organization: Bootlin X-Mailer: Claws Mail 3.17.7 (GTK+ 2.24.32; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8BIT Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Mani, mani@kernel.org wrote on Wed, 26 Jan 2022 16:03:16 +0530: > On Wed, Jan 26, 2022 at 11:16:13AM +0100, Miquel Raynal wrote: > > Hello, > > > > miquel.raynal@bootlin.com wrote on Fri, 14 Jan 2022 08:27:18 +0100: > > > > > Hi Konrad, > > > > > > konrad.dybcio@somainline.org wrote on Thu, 13 Jan 2022 19:44:26 +0100: > > > > > > > While I have absolutely 0 idea why and how, running clear_bam_transaction > > > > when READID is issued makes the DMA totally clog up and refuse to function > > > > at all on mdm9607. In fact, it is so bad that all the data gets garbled > > > > and after a short while in the nand probe flow, the CPU decides that > > > > sepuku is the only option. > > > > > > > > Removing _READID from the if condition makes it work like a charm, I can > > > > read data and mount partitions without a problem. > > > > > > > > Signed-off-by: Konrad Dybcio > > > > --- > > > > This is totally just an observation which took me an inhumane amount of > > > > debug prints to find.. perhaps there's a better reason behind this, but > > > > I can't seem to find any answers.. Therefore, this is a BIG RFC! > > > > > > I'm adding two people from codeaurora who worked a lot on this driver. > > > Hopefully they will have an idea :) > > > > Sadre, I've spent a significant amount of time reviewing your patches, > > now it's your turn to not take a month to answer to your peers > > proposals. > > > > Please help reviewing this patch. > > > > Sorry. I was hoping that Qcom folks would chime in as I don't have any idea > about the mdm9607 platform. It could be that the mail server migration from > codeaurora to quicinc put a barrier here. > > Let me ping them internally. Oh, ok, I didn't know. Thanks! > > BTW why is this driver still using cmdfund? It should have been > > migrated to ->exec_op() a long time ago. > > I'll look into it. That would be great, given the number of updates this driver has received, it would be nice to tackle the legacy bits there. Thanks, Miquèl