From: Jakub Kicinski <kuba@kernel.org>
To: Oleksij Rempel <o.rempel@pengutronix.de>
Cc: Andrew Lunn <andrew@lunn.ch>, Oliver Neukum <oneukum@suse.com>,
"David S. Miller" <davem@davemloft.net>,
kernel@pengutronix.de, linux-kernel@vger.kernel.org,
linux-usb@vger.kernel.org, netdev@vger.kernel.org
Subject: Re: [PATCH net-next v1 1/1] usbnet: add devlink support
Date: Thu, 27 Jan 2022 08:56:27 -0800 [thread overview]
Message-ID: <20220127085627.70b31e30@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com> (raw)
In-Reply-To: <YfK9uV0BviEiemDi@lunn.ch>
On Thu, 27 Jan 2022 16:43:53 +0100 Andrew Lunn wrote:
> On Thu, Jan 27, 2022 at 12:07:42PM +0100, Oleksij Rempel wrote:
> > The weakest link of usbnet devices is the USB cable. Currently there is
> > no way to automatically detect cable related issues except of analyzing
> > kernel log, which would differ depending on the USB host controller.
> >
> > The Ethernet packet counter could potentially show evidence of some USB
> > related issues, but can be Ethernet related problem as well.
>
> I don't know the usbnet drivers very well. A quick look suggests they
> don't support statistics via ethtool -S. So you could make use of that
> to return statistics about USB error events.
On using devlink health - it is great when you want to attach some extra
info to the error report. If you're just counting different types of
errors seems like an overkill.
> However, GregKH point still stands, maybe such statistics should be
> made for all USB devices, and be available in /sys/bus/usb/devices/*
next prev parent reply other threads:[~2022-01-27 16:56 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-01-27 11:07 [PATCH net-next v1 1/1] usbnet: add devlink support Oleksij Rempel
2022-01-27 11:13 ` Greg KH
2022-01-27 12:31 ` Oleksij Rempel
2022-01-27 13:22 ` Greg KH
2022-01-28 11:12 ` Oleksij Rempel
2022-01-28 11:23 ` Greg KH
2022-01-28 11:31 ` Oleksij Rempel
2022-02-02 9:14 ` Oliver Neukum
2022-01-27 17:00 ` Alan Stern
2022-01-28 11:27 ` Oleksij Rempel
2022-01-28 15:33 ` Alan Stern
2022-01-27 11:18 ` Greg KH
2022-01-27 11:19 ` Greg KH
2022-01-27 15:43 ` Andrew Lunn
2022-01-27 16:56 ` Jakub Kicinski [this message]
2022-01-27 19:59 ` kernel test robot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220127085627.70b31e30@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com \
--to=kuba@kernel.org \
--cc=andrew@lunn.ch \
--cc=davem@davemloft.net \
--cc=kernel@pengutronix.de \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=o.rempel@pengutronix.de \
--cc=oneukum@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).