From: Dan Carpenter <dan.carpenter@oracle.com>
To: Stefan Wahren <stefan.wahren@i2se.com>
Cc: cgel.zte@gmail.com, nsaenz@kernel.org, rdunlap@infradead.org,
unixbhaskar@gmail.com, dave.stevenson@raspberrypi.com,
bcm-kernel-feedback-list@broadcom.com,
linux-rpi-kernel@lists.infradead.org,
linux-arm-kernel@lists.infradead.org,
linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org,
"Minghao Chi (CGEL ZTE)" <chi.minghao@zte.com.cn>,
Zeal Robot <zealci@zte.com.cn>
Subject: Re: [PATCH] vchiq-mmal: Remove redundant 'flush_workqueue()' calls
Date: Fri, 28 Jan 2022 10:03:31 +0300 [thread overview]
Message-ID: <20220128070330.GD1951@kadam> (raw)
In-Reply-To: <fdbe3eaf-c737-0714-6b54-8a7cdbe38a0c@i2se.com>
On Thu, Jan 27, 2022 at 01:35:09PM +0100, Stefan Wahren wrote:
> Hi,
>
> Am 27.01.22 um 02:44 schrieb cgel.zte@gmail.com:
> > From: "Minghao Chi (CGEL ZTE)" <chi.minghao@zte.com.cn>
> >
> > 'destroy_workqueue()' already drains the queue before destroying it,
> > so there is no need to flush it explicitly.
> >
> > Remove the redundant 'flush_workqueue()' calls.
> are you sure that drain_workqueue() is the same as flush_workqueue()?
drain_workqueue() calls flush_workqueue() repeatedly.
regards,
dan carpenter
next prev parent reply other threads:[~2022-01-28 7:04 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-01-27 1:44 [PATCH] vchiq-mmal: Remove redundant 'flush_workqueue()' calls cgel.zte
2022-01-27 12:35 ` Stefan Wahren
2022-01-28 7:03 ` Dan Carpenter [this message]
2022-01-28 11:51 ` Stefan Wahren
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220128070330.GD1951@kadam \
--to=dan.carpenter@oracle.com \
--cc=bcm-kernel-feedback-list@broadcom.com \
--cc=cgel.zte@gmail.com \
--cc=chi.minghao@zte.com.cn \
--cc=dave.stevenson@raspberrypi.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rpi-kernel@lists.infradead.org \
--cc=linux-staging@lists.linux.dev \
--cc=nsaenz@kernel.org \
--cc=rdunlap@infradead.org \
--cc=stefan.wahren@i2se.com \
--cc=unixbhaskar@gmail.com \
--cc=zealci@zte.com.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).