From: Sebastian Andrzej Siewior <bigeasy@linutronix.de>
To: greybus-dev@lists.linaro.org, linux-i2c@vger.kernel.org,
linux-kernel@vger.kernel.org, linux-staging@lists.linux.dev,
linux-usb@vger.kernel.org, netdev@vger.kernel.org
Cc: "David S. Miller" <davem@davemloft.net>,
Alex Elder <elder@kernel.org>, Arnd Bergmann <arnd@arndb.de>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Hans de Goede <hdegoede@redhat.com>,
Jakub Kicinski <kuba@kernel.org>, Johan Hovold <johan@kernel.org>,
Lee Jones <lee.jones@linaro.org>,
Rui Miguel Silva <rmfrfs@gmail.com>,
Thomas Gleixner <tglx@linutronix.de>,
UNGLinuxDriver@microchip.com, Wolfram Sang <wsa@kernel.org>,
Woojung Huh <woojung.huh@microchip.com>,
Sebastian Andrzej Siewior <bigeasy@linutronix.de>
Subject: [PATCH v2 5/7] mfd: ezx-pcap: Use generic_handle_irq_safe().
Date: Mon, 31 Jan 2022 13:34:02 +0100 [thread overview]
Message-ID: <20220131123404.175438-6-bigeasy@linutronix.de> (raw)
In-Reply-To: <20220131123404.175438-1-bigeasy@linutronix.de>
Instead of manually disabling interrupts before invoking use
generic_handle_irq_safe() which can be invoked with enabled and disabled
interrupts.
Signed-off-by: Sebastian Andrzej Siewior <bigeasy@linutronix.de>
---
drivers/mfd/ezx-pcap.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/drivers/mfd/ezx-pcap.c b/drivers/mfd/ezx-pcap.c
index 70fa18b04ad2b..b14d3f98e1ebd 100644
--- a/drivers/mfd/ezx-pcap.c
+++ b/drivers/mfd/ezx-pcap.c
@@ -193,13 +193,11 @@ static void pcap_isr_work(struct work_struct *work)
ezx_pcap_write(pcap, PCAP_REG_MSR, isr | msr);
ezx_pcap_write(pcap, PCAP_REG_ISR, isr);
- local_irq_disable();
service = isr & ~msr;
for (irq = pcap->irq_base; service; service >>= 1, irq++) {
if (service & 1)
- generic_handle_irq(irq);
+ generic_handle_irq_safe(irq);
}
- local_irq_enable();
ezx_pcap_write(pcap, PCAP_REG_MSR, pcap->msr);
} while (gpio_get_value(pdata->gpio));
}
--
2.34.1
next prev parent reply other threads:[~2022-01-31 12:34 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-01-31 12:33 [PATCH v2 0/7] Provide and use generic_handle_irq_safe() where appropriate Sebastian Andrzej Siewior
2022-01-31 12:33 ` [PATCH v2 1/7] genirq: Provide generic_handle_irq_safe() Sebastian Andrzej Siewior
2022-02-06 20:11 ` Wolfram Sang
2022-02-09 8:33 ` [PATCH v3 " Sebastian Andrzej Siewior
2022-01-31 12:33 ` [PATCH v2 2/7] i2c: core: Use generic_handle_irq_safe() in i2c_handle_smbus_host_notify() Sebastian Andrzej Siewior
2022-01-31 12:34 ` [PATCH v2 3/7] i2c: cht-wc: Use generic_handle_irq_safe() Sebastian Andrzej Siewior
2022-01-31 12:34 ` [PATCH v2 4/7] mfd: hi6421-spmi-pmic: " Sebastian Andrzej Siewior
2022-01-31 15:54 ` Lee Jones
2022-02-01 10:19 ` [PATCH v2.1 4/7] misc: " Sebastian Andrzej Siewior
2022-01-31 12:34 ` Sebastian Andrzej Siewior [this message]
2022-01-31 12:34 ` [PATCH v2 6/7] net: usb: lan78xx: " Sebastian Andrzej Siewior
2022-01-31 12:34 ` [PATCH v2 7/7] staging: greybus: gpio: " Sebastian Andrzej Siewior
2022-01-31 12:54 ` Greg Kroah-Hartman
2022-02-01 9:45 ` Johan Hovold
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220131123404.175438-6-bigeasy@linutronix.de \
--to=bigeasy@linutronix.de \
--cc=UNGLinuxDriver@microchip.com \
--cc=arnd@arndb.de \
--cc=davem@davemloft.net \
--cc=elder@kernel.org \
--cc=gregkh@linuxfoundation.org \
--cc=greybus-dev@lists.linaro.org \
--cc=hdegoede@redhat.com \
--cc=johan@kernel.org \
--cc=kuba@kernel.org \
--cc=lee.jones@linaro.org \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-staging@lists.linux.dev \
--cc=linux-usb@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=rmfrfs@gmail.com \
--cc=tglx@linutronix.de \
--cc=woojung.huh@microchip.com \
--cc=wsa@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).