From: Andrew Morton <akpm@linux-foundation.org>
To: Jann Horn <jannh@google.com>
Cc: "Eric W. Biederman" <ebiederm@xmission.com>,
linux-kernel@vger.kernel.org,
Bill Messmer <wmessmer@microsoft.com>,
Al Viro <viro@zeniv.linux.org.uk>,
Randy Dunlap <rdunlap@infradead.org>,
stable@vger.kernel.org, Kees Cook <keescook@chromium.org>
Subject: Re: [PATCH] coredump: Also dump first pages of non-executable ELF libraries
Date: Fri, 4 Feb 2022 14:44:31 -0800 [thread overview]
Message-ID: <20220204144431.b5d2b40d22bd5c458846b008@linux-foundation.org> (raw)
In-Reply-To: <CAG48ez1RzO8KrbAv_9kwRCyjS7E3K+adJzdqV6uLqKPoyQmPnw@mail.gmail.com>
On Fri, 4 Feb 2022 00:59:59 +0100 Jann Horn <jannh@google.com> wrote:
> > > I looked in the history and the code was filtering for ELF headers
> > > there already. I am just thinking this feels like a good idea
> > > regardless of the file format to help verify the file on-disk
> > > is the file we think was mapped.
> >
> > Yeah, I guess that's reasonable. The main difference will probably be
> > that the starting pages of some font files, locale files and python
> > libraries will also be logged.
>
> Are you planning to turn that into a proper patch and take it through
> your tree, or something like that? If so, we should tell akpm to take
> this one back out...
I have
coredump-also-dump-first-pages-of-non-executable-elf-libraries.patch on
hold, pending outcome of this discussion.
prev parent reply other threads:[~2022-02-04 22:44 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-01-26 2:57 [PATCH] coredump: Also dump first pages of non-executable ELF libraries Jann Horn
2022-01-26 21:19 ` [EXTERNAL] " Bill Messmer
2022-02-02 15:19 ` Eric W. Biederman
2022-02-02 17:43 ` Jann Horn
2022-02-03 23:59 ` Jann Horn
2022-02-04 22:44 ` Andrew Morton [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220204144431.b5d2b40d22bd5c458846b008@linux-foundation.org \
--to=akpm@linux-foundation.org \
--cc=ebiederm@xmission.com \
--cc=jannh@google.com \
--cc=keescook@chromium.org \
--cc=linux-kernel@vger.kernel.org \
--cc=rdunlap@infradead.org \
--cc=stable@vger.kernel.org \
--cc=viro@zeniv.linux.org.uk \
--cc=wmessmer@microsoft.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).