From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1ECBAC433F5 for ; Mon, 7 Feb 2022 01:04:03 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S243320AbiBGBEB (ORCPT ); Sun, 6 Feb 2022 20:04:01 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:49796 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230225AbiBGBEA (ORCPT ); Sun, 6 Feb 2022 20:04:00 -0500 Received: from mga09.intel.com (mga09.intel.com [134.134.136.24]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 4320FC06173B for ; Sun, 6 Feb 2022 17:03:59 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1644195839; x=1675731839; h=date:from:to:cc:subject:message-id:mime-version; bh=59Ys8lop+dANH2jufpC/AldVNuUV3D8aZlkVkEYGNMQ=; b=CL2/a/Qs5Ys/Pb4O/HZYm5asB/0Wm6nbaM3U4ToViE68NYDbGOj4MN84 xNUQeui7jqShRFNTYpLA3G7OVSMXor4BbrBZiGDSJhTdpRdeoA34DveSQ GadSbCPNEQ88v10AmKJdhFc2BzygBpcYfB17xzpWjk6Tx1ZKIAvMVgYB3 np4H6+FcMa55Xu+QnKznDNaTEplC5A5S+Sidb7AkmbITUfntKz+Y4MEJD yjXJSVYI7rZW2XmM0uWoz3MPuw/JYlJrqr2spQ7CjeNmpNc/hYJSSonwU q5DXbMfOi4TPjFLXlH8y5vPJxhQxSXit2/BILStevEAECKO0K4hVrhFjG A==; X-IronPort-AV: E=McAfee;i="6200,9189,10250"; a="248383130" X-IronPort-AV: E=Sophos;i="5.88,348,1635231600"; d="scan'208";a="248383130" Received: from orsmga007.jf.intel.com ([10.7.209.58]) by orsmga102.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 06 Feb 2022 17:03:58 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.88,348,1635231600"; d="scan'208";a="524949036" Received: from lkp-server01.sh.intel.com (HELO 276f1b88eecb) ([10.239.97.150]) by orsmga007.jf.intel.com with ESMTP; 06 Feb 2022 17:03:56 -0800 Received: from kbuild by 276f1b88eecb with local (Exim 4.92) (envelope-from ) id 1nGsRg-000awv-8D; Mon, 07 Feb 2022 01:03:56 +0000 Date: Mon, 7 Feb 2022 09:03:25 +0800 From: kernel test robot To: Chris Wilson Cc: llvm@lists.linux.dev, kbuild-all@lists.01.org, linux-kernel@vger.kernel.org, Daniele Ceraolo Spurio , Tvrtko Ursulin Subject: drivers/gpu/drm/i915/gt/selftest_execlists.c:167:4: error: format string is not a string literal (potentially insecure) Message-ID: <202202070826.I6zgScfr-lkp@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline User-Agent: Mutt/1.10.1 (2018-07-13) Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Chris, First bad commit (maybe != root cause): tree: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master head: dfd42facf1e4ada021b939b4e19c935dcdd55566 commit: 70a2b431c36483c0c06e589e11c59e438cd0ac06 drm/i915/gt: Rename lrc.c to execlists_submission.c date: 1 year, 2 months ago config: i386-randconfig-a001-20220207 (https://download.01.org/0day-ci/archive/20220207/202202070826.I6zgScfr-lkp@intel.com/config) compiler: clang version 15.0.0 (https://github.com/llvm/llvm-project 6daaf5a44925592c764c59219b0024ee06317028) reproduce (this is a W=1 build): wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross chmod +x ~/bin/make.cross # https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=70a2b431c36483c0c06e589e11c59e438cd0ac06 git remote add linus https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git git fetch --no-tags linus master git checkout 70a2b431c36483c0c06e589e11c59e438cd0ac06 # save the config file to linux build tree mkdir build_dir COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross W=1 O=build_dir ARCH=i386 SHELL=/bin/bash If you fix the issue, kindly add following tag as appropriate Reported-by: kernel test robot All errors (new ones prefixed by >>): In file included from drivers/gpu/drm/i915/gt/intel_execlists_submission.c:6116: >> drivers/gpu/drm/i915/gt/selftest_execlists.c:167:4: error: format string is not a string literal (potentially insecure) [-Werror,-Wformat-security] GEM_TRACE("spinner failed to start\n"); ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ drivers/gpu/drm/i915/i915_gem.h:69:24: note: expanded from macro 'GEM_TRACE' #define GEM_TRACE(...) trace_printk(__VA_ARGS__) ^~~~~~~~~~~~~~~~~~~~~~~~~ include/linux/kernel.h:724:3: note: expanded from macro 'trace_printk' do_trace_printk(fmt, ##__VA_ARGS__); \ ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ include/linux/kernel.h:738:30: note: expanded from macro 'do_trace_printk' __trace_bprintk(_THIS_IP_, trace_printk_fmt, ##args); \ ^~~~~~~~~~~~~~~~ drivers/gpu/drm/i915/gt/selftest_execlists.c:167:4: note: treat the string as an argument to avoid this drivers/gpu/drm/i915/i915_gem.h:69:24: note: expanded from macro 'GEM_TRACE' #define GEM_TRACE(...) trace_printk(__VA_ARGS__) ^ include/linux/kernel.h:724:3: note: expanded from macro 'trace_printk' do_trace_printk(fmt, ##__VA_ARGS__); \ ^ include/linux/kernel.h:738:30: note: expanded from macro 'do_trace_printk' __trace_bprintk(_THIS_IP_, trace_printk_fmt, ##args); \ ^ In file included from drivers/gpu/drm/i915/gt/intel_execlists_submission.c:6116: drivers/gpu/drm/i915/gt/selftest_execlists.c:1790:4: error: format string is not a string literal (potentially insecure) [-Werror,-Wformat-security] GEM_TRACE("lo spinner failed to start\n"); ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ drivers/gpu/drm/i915/i915_gem.h:69:24: note: expanded from macro 'GEM_TRACE' #define GEM_TRACE(...) trace_printk(__VA_ARGS__) ^~~~~~~~~~~~~~~~~~~~~~~~~ include/linux/kernel.h:724:3: note: expanded from macro 'trace_printk' do_trace_printk(fmt, ##__VA_ARGS__); \ ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ include/linux/kernel.h:738:30: note: expanded from macro 'do_trace_printk' __trace_bprintk(_THIS_IP_, trace_printk_fmt, ##args); \ ^~~~~~~~~~~~~~~~ drivers/gpu/drm/i915/gt/selftest_execlists.c:1790:4: note: treat the string as an argument to avoid this drivers/gpu/drm/i915/i915_gem.h:69:24: note: expanded from macro 'GEM_TRACE' #define GEM_TRACE(...) trace_printk(__VA_ARGS__) ^ include/linux/kernel.h:724:3: note: expanded from macro 'trace_printk' do_trace_printk(fmt, ##__VA_ARGS__); \ ^ include/linux/kernel.h:738:30: note: expanded from macro 'do_trace_printk' __trace_bprintk(_THIS_IP_, trace_printk_fmt, ##args); \ ^ In file included from drivers/gpu/drm/i915/gt/intel_execlists_submission.c:6116: drivers/gpu/drm/i915/gt/selftest_execlists.c:1807:4: error: format string is not a string literal (potentially insecure) [-Werror,-Wformat-security] GEM_TRACE("hi spinner failed to start\n"); ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ drivers/gpu/drm/i915/i915_gem.h:69:24: note: expanded from macro 'GEM_TRACE' #define GEM_TRACE(...) trace_printk(__VA_ARGS__) ^~~~~~~~~~~~~~~~~~~~~~~~~ include/linux/kernel.h:724:3: note: expanded from macro 'trace_printk' do_trace_printk(fmt, ##__VA_ARGS__); \ ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ include/linux/kernel.h:738:30: note: expanded from macro 'do_trace_printk' __trace_bprintk(_THIS_IP_, trace_printk_fmt, ##args); \ ^~~~~~~~~~~~~~~~ drivers/gpu/drm/i915/gt/selftest_execlists.c:1807:4: note: treat the string as an argument to avoid this drivers/gpu/drm/i915/i915_gem.h:69:24: note: expanded from macro 'GEM_TRACE' #define GEM_TRACE(...) trace_printk(__VA_ARGS__) ^ include/linux/kernel.h:724:3: note: expanded from macro 'trace_printk' do_trace_printk(fmt, ##__VA_ARGS__); \ ^ include/linux/kernel.h:738:30: note: expanded from macro 'do_trace_printk' __trace_bprintk(_THIS_IP_, trace_printk_fmt, ##args); \ ^ 3 errors generated. vim +167 drivers/gpu/drm/i915/gt/selftest_execlists.c 280e285dc78f736 drivers/gpu/drm/i915/gt/selftest_lrc.c Chris Wilson 2020-02-27 134 2c66555ec19235e drivers/gpu/drm/i915/selftests/intel_lrc.c Chris Wilson 2018-04-04 135 static int live_sanitycheck(void *arg) 2c66555ec19235e drivers/gpu/drm/i915/selftests/intel_lrc.c Chris Wilson 2018-04-04 136 { 1357fa8136ea030 drivers/gpu/drm/i915/gt/selftest_lrc.c Chris Wilson 2019-10-16 137 struct intel_gt *gt = arg; e6ba76480299a0d drivers/gpu/drm/i915/gt/selftest_lrc.c Chris Wilson 2019-12-21 138 struct intel_engine_cs *engine; e6ba76480299a0d drivers/gpu/drm/i915/gt/selftest_lrc.c Chris Wilson 2019-12-21 139 enum intel_engine_id id; 8d2f6e2f2721097 drivers/gpu/drm/i915/selftests/intel_lrc.c Tvrtko Ursulin 2018-11-30 140 struct igt_spinner spin; e6ba76480299a0d drivers/gpu/drm/i915/gt/selftest_lrc.c Chris Wilson 2019-12-21 141 int err = 0; 2c66555ec19235e drivers/gpu/drm/i915/selftests/intel_lrc.c Chris Wilson 2018-04-04 142 1357fa8136ea030 drivers/gpu/drm/i915/gt/selftest_lrc.c Chris Wilson 2019-10-16 143 if (!HAS_LOGICAL_RING_CONTEXTS(gt->i915)) 2c66555ec19235e drivers/gpu/drm/i915/selftests/intel_lrc.c Chris Wilson 2018-04-04 144 return 0; 2c66555ec19235e drivers/gpu/drm/i915/selftests/intel_lrc.c Chris Wilson 2018-04-04 145 1357fa8136ea030 drivers/gpu/drm/i915/gt/selftest_lrc.c Chris Wilson 2019-10-16 146 if (igt_spinner_init(&spin, gt)) 2af402982ab3822 drivers/gpu/drm/i915/gt/selftest_lrc.c Chris Wilson 2019-10-04 147 return -ENOMEM; 2c66555ec19235e drivers/gpu/drm/i915/selftests/intel_lrc.c Chris Wilson 2018-04-04 148 e6ba76480299a0d drivers/gpu/drm/i915/gt/selftest_lrc.c Chris Wilson 2019-12-21 149 for_each_engine(engine, gt, id) { e6ba76480299a0d drivers/gpu/drm/i915/gt/selftest_lrc.c Chris Wilson 2019-12-21 150 struct intel_context *ce; 2c66555ec19235e drivers/gpu/drm/i915/selftests/intel_lrc.c Chris Wilson 2018-04-04 151 struct i915_request *rq; 2c66555ec19235e drivers/gpu/drm/i915/selftests/intel_lrc.c Chris Wilson 2018-04-04 152 e6ba76480299a0d drivers/gpu/drm/i915/gt/selftest_lrc.c Chris Wilson 2019-12-21 153 ce = intel_context_create(engine); e6ba76480299a0d drivers/gpu/drm/i915/gt/selftest_lrc.c Chris Wilson 2019-12-21 154 if (IS_ERR(ce)) { e6ba76480299a0d drivers/gpu/drm/i915/gt/selftest_lrc.c Chris Wilson 2019-12-21 155 err = PTR_ERR(ce); e6ba76480299a0d drivers/gpu/drm/i915/gt/selftest_lrc.c Chris Wilson 2019-12-21 156 break; e6ba76480299a0d drivers/gpu/drm/i915/gt/selftest_lrc.c Chris Wilson 2019-12-21 157 } e6ba76480299a0d drivers/gpu/drm/i915/gt/selftest_lrc.c Chris Wilson 2019-12-21 158 f277bc0c98a4077 drivers/gpu/drm/i915/gt/selftest_lrc.c Chris Wilson 2019-07-31 159 rq = igt_spinner_create_request(&spin, ce, MI_NOOP); 2c66555ec19235e drivers/gpu/drm/i915/selftests/intel_lrc.c Chris Wilson 2018-04-04 160 if (IS_ERR(rq)) { 2c66555ec19235e drivers/gpu/drm/i915/selftests/intel_lrc.c Chris Wilson 2018-04-04 161 err = PTR_ERR(rq); e6ba76480299a0d drivers/gpu/drm/i915/gt/selftest_lrc.c Chris Wilson 2019-12-21 162 goto out_ctx; 2c66555ec19235e drivers/gpu/drm/i915/selftests/intel_lrc.c Chris Wilson 2018-04-04 163 } 2c66555ec19235e drivers/gpu/drm/i915/selftests/intel_lrc.c Chris Wilson 2018-04-04 164 2c66555ec19235e drivers/gpu/drm/i915/selftests/intel_lrc.c Chris Wilson 2018-04-04 165 i915_request_add(rq); 8d2f6e2f2721097 drivers/gpu/drm/i915/selftests/intel_lrc.c Tvrtko Ursulin 2018-11-30 166 if (!igt_wait_for_spinner(&spin, rq)) { 2c66555ec19235e drivers/gpu/drm/i915/selftests/intel_lrc.c Chris Wilson 2018-04-04 @167 GEM_TRACE("spinner failed to start\n"); 2c66555ec19235e drivers/gpu/drm/i915/selftests/intel_lrc.c Chris Wilson 2018-04-04 168 GEM_TRACE_DUMP(); 1357fa8136ea030 drivers/gpu/drm/i915/gt/selftest_lrc.c Chris Wilson 2019-10-16 169 intel_gt_set_wedged(gt); 2c66555ec19235e drivers/gpu/drm/i915/selftests/intel_lrc.c Chris Wilson 2018-04-04 170 err = -EIO; e6ba76480299a0d drivers/gpu/drm/i915/gt/selftest_lrc.c Chris Wilson 2019-12-21 171 goto out_ctx; 2c66555ec19235e drivers/gpu/drm/i915/selftests/intel_lrc.c Chris Wilson 2018-04-04 172 } 2c66555ec19235e drivers/gpu/drm/i915/selftests/intel_lrc.c Chris Wilson 2018-04-04 173 8d2f6e2f2721097 drivers/gpu/drm/i915/selftests/intel_lrc.c Tvrtko Ursulin 2018-11-30 174 igt_spinner_end(&spin); 1357fa8136ea030 drivers/gpu/drm/i915/gt/selftest_lrc.c Chris Wilson 2019-10-16 175 if (igt_flush_test(gt->i915)) { 2c66555ec19235e drivers/gpu/drm/i915/selftests/intel_lrc.c Chris Wilson 2018-04-04 176 err = -EIO; e6ba76480299a0d drivers/gpu/drm/i915/gt/selftest_lrc.c Chris Wilson 2019-12-21 177 goto out_ctx; 2c66555ec19235e drivers/gpu/drm/i915/selftests/intel_lrc.c Chris Wilson 2018-04-04 178 } e6ba76480299a0d drivers/gpu/drm/i915/gt/selftest_lrc.c Chris Wilson 2019-12-21 179 e6ba76480299a0d drivers/gpu/drm/i915/gt/selftest_lrc.c Chris Wilson 2019-12-21 180 out_ctx: e6ba76480299a0d drivers/gpu/drm/i915/gt/selftest_lrc.c Chris Wilson 2019-12-21 181 intel_context_put(ce); e6ba76480299a0d drivers/gpu/drm/i915/gt/selftest_lrc.c Chris Wilson 2019-12-21 182 if (err) e6ba76480299a0d drivers/gpu/drm/i915/gt/selftest_lrc.c Chris Wilson 2019-12-21 183 break; 2c66555ec19235e drivers/gpu/drm/i915/selftests/intel_lrc.c Chris Wilson 2018-04-04 184 } 2c66555ec19235e drivers/gpu/drm/i915/selftests/intel_lrc.c Chris Wilson 2018-04-04 185 8d2f6e2f2721097 drivers/gpu/drm/i915/selftests/intel_lrc.c Tvrtko Ursulin 2018-11-30 186 igt_spinner_fini(&spin); 2c66555ec19235e drivers/gpu/drm/i915/selftests/intel_lrc.c Chris Wilson 2018-04-04 187 return err; 2c66555ec19235e drivers/gpu/drm/i915/selftests/intel_lrc.c Chris Wilson 2018-04-04 188 } 2c66555ec19235e drivers/gpu/drm/i915/selftests/intel_lrc.c Chris Wilson 2018-04-04 189 :::::: The code at line 167 was first introduced by commit :::::: 2c66555ec19235efd689741c44bbeb893aa8e7de drm/i915/selftests: Add basic sanitychecks for execlists :::::: TO: Chris Wilson :::::: CC: Chris Wilson --- 0-DAY CI Kernel Test Service, Intel Corporation https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org