* [PATCH v2 0/4] platform/chrome: cros_ec_typec: Reorganize mux configuration
@ 2022-02-08 18:47 Prashant Malani
2022-02-08 18:47 ` [PATCH v2 1/4] platform/chrome: cros_ec_typec: Move mux flag checks Prashant Malani
` (5 more replies)
0 siblings, 6 replies; 11+ messages in thread
From: Prashant Malani @ 2022-02-08 18:47 UTC (permalink / raw)
To: linux-kernel
Cc: Prashant Malani, Benson Leung,
open list:CHROMEOS EC USB TYPE-C DRIVER, Guenter Roeck
This is a short series that reorganizes when mux configuration occurs
during Type C port updates. The first 2 patches are minor refactors
which move some of the mux update logic to within
cros_typec_configure_mux(). The third patch moves
cros_typec_configure_mux() itself to be earlier in
cros_typec_port_update().
The final patch updates the stashed mux flag when a partner removal has
occured.
v1:
https://lore.kernel.org/chrome-platform/20220207214026.1526151-1-pmalani@chromium.org/
Changes in v2:
- Addressed minor comments (unrelated variable initialization. variable
name change, return value can be 0).
Prashant Malani (4):
platform/chrome: cros_ec_typec: Move mux flag checks
platform/chrome: cros_ec_typec: Get mux state inside configure_mux
platform/chrome: cros_ec_typec: Configure muxes at start of port
update
platform/chrome: cros_ec_typec: Update mux flags during partner
removal
drivers/platform/chrome/cros_ec_typec.c | 76 +++++++++++--------------
1 file changed, 34 insertions(+), 42 deletions(-)
--
2.35.0.263.gb82422642f-goog
^ permalink raw reply [flat|nested] 11+ messages in thread
* [PATCH v2 1/4] platform/chrome: cros_ec_typec: Move mux flag checks
2022-02-08 18:47 [PATCH v2 0/4] platform/chrome: cros_ec_typec: Reorganize mux configuration Prashant Malani
@ 2022-02-08 18:47 ` Prashant Malani
2022-02-09 3:32 ` Tzung-Bi Shih
2022-02-08 18:47 ` [PATCH v2 2/4] platform/chrome: cros_ec_typec: Get mux state inside configure_mux Prashant Malani
` (4 subsequent siblings)
5 siblings, 1 reply; 11+ messages in thread
From: Prashant Malani @ 2022-02-08 18:47 UTC (permalink / raw)
To: linux-kernel
Cc: Prashant Malani, Benson Leung,
open list:CHROMEOS EC USB TYPE-C DRIVER, Guenter Roeck
Move mux and role flag checks inside of cros_typec_configure_mux(),
which is a more logical location for them.
Signed-off-by: Prashant Malani <pmalani@chromium.org>
---
Changes in v2:
- Removed unrelated "ret" variable initialization.
drivers/platform/chrome/cros_ec_typec.c | 14 +++++++-------
1 file changed, 7 insertions(+), 7 deletions(-)
diff --git a/drivers/platform/chrome/cros_ec_typec.c b/drivers/platform/chrome/cros_ec_typec.c
index c6f17e3ef72d..58d08dd02f65 100644
--- a/drivers/platform/chrome/cros_ec_typec.c
+++ b/drivers/platform/chrome/cros_ec_typec.c
@@ -521,6 +521,13 @@ static int cros_typec_configure_mux(struct cros_typec_data *typec, int port_num,
enum typec_orientation orientation;
int ret;
+ /* No change needs to be made, let's exit early. */
+ if (port->mux_flags == mux_flags && port->role == pd_ctrl->role)
+ return 0;
+
+ port->mux_flags = mux_flags;
+ port->role = pd_ctrl->role;
+
if (mux_flags == USB_PD_MUX_NONE) {
ret = cros_typec_usb_disconnect_state(port);
goto mux_ack;
@@ -983,13 +990,6 @@ static int cros_typec_port_update(struct cros_typec_data *typec, int port_num)
return 0;
}
- /* No change needs to be made, let's exit early. */
- if (typec->ports[port_num]->mux_flags == mux_resp.flags &&
- typec->ports[port_num]->role == resp.role)
- return 0;
-
- typec->ports[port_num]->mux_flags = mux_resp.flags;
- typec->ports[port_num]->role = resp.role;
ret = cros_typec_configure_mux(typec, port_num, mux_resp.flags, &resp);
if (ret)
dev_warn(typec->dev, "Configure muxes failed, err = %d\n", ret);
--
2.35.0.263.gb82422642f-goog
^ permalink raw reply related [flat|nested] 11+ messages in thread
* [PATCH v2 2/4] platform/chrome: cros_ec_typec: Get mux state inside configure_mux
2022-02-08 18:47 [PATCH v2 0/4] platform/chrome: cros_ec_typec: Reorganize mux configuration Prashant Malani
2022-02-08 18:47 ` [PATCH v2 1/4] platform/chrome: cros_ec_typec: Move mux flag checks Prashant Malani
@ 2022-02-08 18:47 ` Prashant Malani
2022-02-09 3:32 ` Tzung-Bi Shih
2022-02-08 18:47 ` [PATCH v2 3/4] platform/chrome: cros_ec_typec: Configure muxes at start of port update Prashant Malani
` (3 subsequent siblings)
5 siblings, 1 reply; 11+ messages in thread
From: Prashant Malani @ 2022-02-08 18:47 UTC (permalink / raw)
To: linux-kernel
Cc: Prashant Malani, Benson Leung,
open list:CHROMEOS EC USB TYPE-C DRIVER, Guenter Roeck
Move the function which gets current mux state inside the
cros_typec_configure_mux() function. It is better to group those
bits of functionality together, and it makes it easier to move around
cros_typec_configure_mux() later.
While we are doing this, also inline the cros_typec_get_mux_info() inside
of cros_typec_configure_mux().
Signed-off-by: Prashant Malani <pmalani@chromium.org>
---
Changes in v2:
- Changed "mux_resp" variable to "resp".
drivers/platform/chrome/cros_ec_typec.c | 55 +++++++++++--------------
1 file changed, 23 insertions(+), 32 deletions(-)
diff --git a/drivers/platform/chrome/cros_ec_typec.c b/drivers/platform/chrome/cros_ec_typec.c
index 58d08dd02f65..3d34ece7f790 100644
--- a/drivers/platform/chrome/cros_ec_typec.c
+++ b/drivers/platform/chrome/cros_ec_typec.c
@@ -513,27 +513,38 @@ static int cros_typec_enable_usb4(struct cros_typec_data *typec,
}
static int cros_typec_configure_mux(struct cros_typec_data *typec, int port_num,
- uint8_t mux_flags,
struct ec_response_usb_pd_control_v2 *pd_ctrl)
{
struct cros_typec_port *port = typec->ports[port_num];
+ struct ec_response_usb_pd_mux_info resp;
+ struct ec_params_usb_pd_mux_info req = {
+ .port = port_num,
+ };
struct ec_params_usb_pd_mux_ack mux_ack;
enum typec_orientation orientation;
int ret;
+ ret = cros_ec_command(typec->ec, 0, EC_CMD_USB_PD_MUX_INFO,
+ &req, sizeof(req), &resp, sizeof(resp));
+ if (ret < 0) {
+ dev_warn(typec->dev, "Failed to get mux info for port: %d, err = %d\n",
+ port_num, ret);
+ return ret;
+ }
+
/* No change needs to be made, let's exit early. */
- if (port->mux_flags == mux_flags && port->role == pd_ctrl->role)
+ if (port->mux_flags == resp.flags && port->role == pd_ctrl->role)
return 0;
- port->mux_flags = mux_flags;
+ port->mux_flags = resp.flags;
port->role = pd_ctrl->role;
- if (mux_flags == USB_PD_MUX_NONE) {
+ if (port->mux_flags == USB_PD_MUX_NONE) {
ret = cros_typec_usb_disconnect_state(port);
goto mux_ack;
}
- if (mux_flags & USB_PD_MUX_POLARITY_INVERTED)
+ if (port->mux_flags & USB_PD_MUX_POLARITY_INVERTED)
orientation = TYPEC_ORIENTATION_REVERSE;
else
orientation = TYPEC_ORIENTATION_NORMAL;
@@ -548,22 +559,22 @@ static int cros_typec_configure_mux(struct cros_typec_data *typec, int port_num,
if (ret)
return ret;
- if (mux_flags & USB_PD_MUX_USB4_ENABLED) {
+ if (port->mux_flags & USB_PD_MUX_USB4_ENABLED) {
ret = cros_typec_enable_usb4(typec, port_num, pd_ctrl);
- } else if (mux_flags & USB_PD_MUX_TBT_COMPAT_ENABLED) {
+ } else if (port->mux_flags & USB_PD_MUX_TBT_COMPAT_ENABLED) {
ret = cros_typec_enable_tbt(typec, port_num, pd_ctrl);
- } else if (mux_flags & USB_PD_MUX_DP_ENABLED) {
+ } else if (port->mux_flags & USB_PD_MUX_DP_ENABLED) {
ret = cros_typec_enable_dp(typec, port_num, pd_ctrl);
- } else if (mux_flags & USB_PD_MUX_SAFE_MODE) {
+ } else if (port->mux_flags & USB_PD_MUX_SAFE_MODE) {
ret = cros_typec_usb_safe_state(port);
- } else if (mux_flags & USB_PD_MUX_USB_ENABLED) {
+ } else if (port->mux_flags & USB_PD_MUX_USB_ENABLED) {
port->state.alt = NULL;
port->state.mode = TYPEC_STATE_USB;
ret = typec_mux_set(port->mux, &port->state);
} else {
dev_dbg(typec->dev,
"Unrecognized mode requested, mux flags: %x\n",
- mux_flags);
+ port->mux_flags);
}
mux_ack:
@@ -638,17 +649,6 @@ static void cros_typec_set_port_params_v1(struct cros_typec_data *typec,
}
}
-static int cros_typec_get_mux_info(struct cros_typec_data *typec, int port_num,
- struct ec_response_usb_pd_mux_info *resp)
-{
- struct ec_params_usb_pd_mux_info req = {
- .port = port_num,
- };
-
- return cros_ec_command(typec->ec, 0, EC_CMD_USB_PD_MUX_INFO, &req,
- sizeof(req), resp, sizeof(*resp));
-}
-
/*
* Helper function to register partner/plug altmodes.
*/
@@ -946,7 +946,6 @@ static int cros_typec_port_update(struct cros_typec_data *typec, int port_num)
{
struct ec_params_usb_pd_control req;
struct ec_response_usb_pd_control_v2 resp;
- struct ec_response_usb_pd_mux_info mux_resp;
int ret;
if (port_num < 0 || port_num >= typec->num_ports) {
@@ -982,15 +981,7 @@ static int cros_typec_port_update(struct cros_typec_data *typec, int port_num)
cros_typec_handle_status(typec, port_num);
/* Update the switches if they exist, according to requested state */
- ret = cros_typec_get_mux_info(typec, port_num, &mux_resp);
- if (ret < 0) {
- dev_warn(typec->dev,
- "Failed to get mux info for port: %d, err = %d\n",
- port_num, ret);
- return 0;
- }
-
- ret = cros_typec_configure_mux(typec, port_num, mux_resp.flags, &resp);
+ ret = cros_typec_configure_mux(typec, port_num, &resp);
if (ret)
dev_warn(typec->dev, "Configure muxes failed, err = %d\n", ret);
--
2.35.0.263.gb82422642f-goog
^ permalink raw reply related [flat|nested] 11+ messages in thread
* [PATCH v2 3/4] platform/chrome: cros_ec_typec: Configure muxes at start of port update
2022-02-08 18:47 [PATCH v2 0/4] platform/chrome: cros_ec_typec: Reorganize mux configuration Prashant Malani
2022-02-08 18:47 ` [PATCH v2 1/4] platform/chrome: cros_ec_typec: Move mux flag checks Prashant Malani
2022-02-08 18:47 ` [PATCH v2 2/4] platform/chrome: cros_ec_typec: Get mux state inside configure_mux Prashant Malani
@ 2022-02-08 18:47 ` Prashant Malani
2022-02-15 0:27 ` Benson Leung
2022-02-08 18:47 ` [PATCH v2 4/4] platform/chrome: cros_ec_typec: Update mux flags during partner removal Prashant Malani
` (2 subsequent siblings)
5 siblings, 1 reply; 11+ messages in thread
From: Prashant Malani @ 2022-02-08 18:47 UTC (permalink / raw)
To: linux-kernel
Cc: Prashant Malani, Benson Leung, Guenter Roeck,
open list:CHROMEOS EC USB TYPE-C DRIVER
There are situations where the mux state reported by the Embedded
Controller (EC), might lag the partner "connected" state. So, the mux
state might still suggest that a partner is connected, while the PD
"connected" state, being in Try.SNK (for example) suggests that the
partner is disconnected.
In such a scenario, we will end up sending a disconnect command to the
mux driver, followed by a connect command, since the mux is configured
later. Avoid this by configuring the mux before
registering/disconnecting a partner.
Signed-off-by: Prashant Malani <pmalani@chromium.org>
---
Changes in v2:
- Change return at end of port_update() to just return 0.
drivers/platform/chrome/cros_ec_typec.c | 12 ++++++------
1 file changed, 6 insertions(+), 6 deletions(-)
diff --git a/drivers/platform/chrome/cros_ec_typec.c b/drivers/platform/chrome/cros_ec_typec.c
index 3d34ece7f790..3019e29f200d 100644
--- a/drivers/platform/chrome/cros_ec_typec.c
+++ b/drivers/platform/chrome/cros_ec_typec.c
@@ -965,6 +965,11 @@ static int cros_typec_port_update(struct cros_typec_data *typec, int port_num)
if (ret < 0)
return ret;
+ /* Update the switches if they exist, according to requested state */
+ ret = cros_typec_configure_mux(typec, port_num, &resp);
+ if (ret)
+ dev_warn(typec->dev, "Configure muxes failed, err = %d\n", ret);
+
dev_dbg(typec->dev, "Enabled %d: 0x%hhx\n", port_num, resp.enabled);
dev_dbg(typec->dev, "Role %d: 0x%hhx\n", port_num, resp.role);
dev_dbg(typec->dev, "Polarity %d: 0x%hhx\n", port_num, resp.polarity);
@@ -980,12 +985,7 @@ static int cros_typec_port_update(struct cros_typec_data *typec, int port_num)
if (typec->typec_cmd_supported)
cros_typec_handle_status(typec, port_num);
- /* Update the switches if they exist, according to requested state */
- ret = cros_typec_configure_mux(typec, port_num, &resp);
- if (ret)
- dev_warn(typec->dev, "Configure muxes failed, err = %d\n", ret);
-
- return ret;
+ return 0;
}
static int cros_typec_get_cmd_version(struct cros_typec_data *typec)
--
2.35.0.263.gb82422642f-goog
^ permalink raw reply related [flat|nested] 11+ messages in thread
* [PATCH v2 4/4] platform/chrome: cros_ec_typec: Update mux flags during partner removal
2022-02-08 18:47 [PATCH v2 0/4] platform/chrome: cros_ec_typec: Reorganize mux configuration Prashant Malani
` (2 preceding siblings ...)
2022-02-08 18:47 ` [PATCH v2 3/4] platform/chrome: cros_ec_typec: Configure muxes at start of port update Prashant Malani
@ 2022-02-08 18:47 ` Prashant Malani
2022-02-09 3:32 ` Tzung-Bi Shih
2022-02-15 20:00 ` [PATCH v2 0/4] platform/chrome: cros_ec_typec: Reorganize mux configuration patchwork-bot+chrome-platform
2022-02-16 22:00 ` patchwork-bot+chrome-platform
5 siblings, 1 reply; 11+ messages in thread
From: Prashant Malani @ 2022-02-08 18:47 UTC (permalink / raw)
To: linux-kernel
Cc: Prashant Malani, Benson Leung, Guenter Roeck,
open list:CHROMEOS EC USB TYPE-C DRIVER
In cros_typec_remove_partner(), we call
cros_typec_usb_disconnect_state() which sets the switches/muxes to be in
a disconnected state. This also happens in cros_typec_configure_mux().
However, unlike there, here the mux_flags variable hasn't been updated
to reflect that a disconnection has occurred. Update the flag here
accordingly.
Signed-off-by: Prashant Malani <pmalani@chromium.org>
---
Changes in v2:
- No changes.
drivers/platform/chrome/cros_ec_typec.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/platform/chrome/cros_ec_typec.c b/drivers/platform/chrome/cros_ec_typec.c
index 3019e29f200d..4bd2752c0823 100644
--- a/drivers/platform/chrome/cros_ec_typec.c
+++ b/drivers/platform/chrome/cros_ec_typec.c
@@ -228,6 +228,7 @@ static void cros_typec_remove_partner(struct cros_typec_data *typec,
cros_typec_unregister_altmodes(typec, port_num, true);
cros_typec_usb_disconnect_state(port);
+ port->mux_flags = USB_PD_MUX_NONE;
typec_unregister_partner(port->partner);
port->partner = NULL;
--
2.35.0.263.gb82422642f-goog
^ permalink raw reply related [flat|nested] 11+ messages in thread
* Re: [PATCH v2 1/4] platform/chrome: cros_ec_typec: Move mux flag checks
2022-02-08 18:47 ` [PATCH v2 1/4] platform/chrome: cros_ec_typec: Move mux flag checks Prashant Malani
@ 2022-02-09 3:32 ` Tzung-Bi Shih
0 siblings, 0 replies; 11+ messages in thread
From: Tzung-Bi Shih @ 2022-02-09 3:32 UTC (permalink / raw)
To: Prashant Malani
Cc: linux-kernel, Benson Leung,
open list:CHROMEOS EC USB TYPE-C DRIVER, Guenter Roeck
On Tue, Feb 08, 2022 at 06:47:18PM +0000, Prashant Malani wrote:
> Move mux and role flag checks inside of cros_typec_configure_mux(),
> which is a more logical location for them.
>
> Signed-off-by: Prashant Malani <pmalani@chromium.org>
Reviewed-by: Tzung-Bi Shih <tzungbi@google.com>
^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [PATCH v2 2/4] platform/chrome: cros_ec_typec: Get mux state inside configure_mux
2022-02-08 18:47 ` [PATCH v2 2/4] platform/chrome: cros_ec_typec: Get mux state inside configure_mux Prashant Malani
@ 2022-02-09 3:32 ` Tzung-Bi Shih
0 siblings, 0 replies; 11+ messages in thread
From: Tzung-Bi Shih @ 2022-02-09 3:32 UTC (permalink / raw)
To: Prashant Malani
Cc: linux-kernel, Benson Leung,
open list:CHROMEOS EC USB TYPE-C DRIVER, Guenter Roeck
On Tue, Feb 08, 2022 at 06:47:20PM +0000, Prashant Malani wrote:
> Move the function which gets current mux state inside the
> cros_typec_configure_mux() function. It is better to group those
> bits of functionality together, and it makes it easier to move around
> cros_typec_configure_mux() later.
>
> While we are doing this, also inline the cros_typec_get_mux_info() inside
> of cros_typec_configure_mux().
>
> Signed-off-by: Prashant Malani <pmalani@chromium.org>
Reviewed-by: Tzung-Bi Shih <tzungbi@google.com>
^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [PATCH v2 4/4] platform/chrome: cros_ec_typec: Update mux flags during partner removal
2022-02-08 18:47 ` [PATCH v2 4/4] platform/chrome: cros_ec_typec: Update mux flags during partner removal Prashant Malani
@ 2022-02-09 3:32 ` Tzung-Bi Shih
0 siblings, 0 replies; 11+ messages in thread
From: Tzung-Bi Shih @ 2022-02-09 3:32 UTC (permalink / raw)
To: Prashant Malani
Cc: linux-kernel, Benson Leung, Guenter Roeck,
open list:CHROMEOS EC USB TYPE-C DRIVER
On Tue, Feb 08, 2022 at 06:47:24PM +0000, Prashant Malani wrote:
> In cros_typec_remove_partner(), we call
> cros_typec_usb_disconnect_state() which sets the switches/muxes to be in
> a disconnected state. This also happens in cros_typec_configure_mux().
> However, unlike there, here the mux_flags variable hasn't been updated
> to reflect that a disconnection has occurred. Update the flag here
> accordingly.
>
> Signed-off-by: Prashant Malani <pmalani@chromium.org>
Reviewed-by: Tzung-Bi Shih <tzungbi@google.com>
^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [PATCH v2 3/4] platform/chrome: cros_ec_typec: Configure muxes at start of port update
2022-02-08 18:47 ` [PATCH v2 3/4] platform/chrome: cros_ec_typec: Configure muxes at start of port update Prashant Malani
@ 2022-02-15 0:27 ` Benson Leung
0 siblings, 0 replies; 11+ messages in thread
From: Benson Leung @ 2022-02-15 0:27 UTC (permalink / raw)
To: Prashant Malani
Cc: linux-kernel, Benson Leung, Guenter Roeck,
open list:CHROMEOS EC USB TYPE-C DRIVER
[-- Attachment #1: Type: text/plain, Size: 2512 bytes --]
Hi Prashant,
On Tue, Feb 08, 2022 at 06:47:22PM +0000, Prashant Malani wrote:
> There are situations where the mux state reported by the Embedded
> Controller (EC), might lag the partner "connected" state. So, the mux
> state might still suggest that a partner is connected, while the PD
> "connected" state, being in Try.SNK (for example) suggests that the
> partner is disconnected.
>
> In such a scenario, we will end up sending a disconnect command to the
> mux driver, followed by a connect command, since the mux is configured
> later. Avoid this by configuring the mux before
> registering/disconnecting a partner.
>
> Signed-off-by: Prashant Malani <pmalani@chromium.org>
Reviewed-by: Benson Leung <bleung@chromium.org>
> ---
>
> Changes in v2:
> - Change return at end of port_update() to just return 0.
>
> drivers/platform/chrome/cros_ec_typec.c | 12 ++++++------
> 1 file changed, 6 insertions(+), 6 deletions(-)
>
> diff --git a/drivers/platform/chrome/cros_ec_typec.c b/drivers/platform/chrome/cros_ec_typec.c
> index 3d34ece7f790..3019e29f200d 100644
> --- a/drivers/platform/chrome/cros_ec_typec.c
> +++ b/drivers/platform/chrome/cros_ec_typec.c
> @@ -965,6 +965,11 @@ static int cros_typec_port_update(struct cros_typec_data *typec, int port_num)
> if (ret < 0)
> return ret;
>
> + /* Update the switches if they exist, according to requested state */
> + ret = cros_typec_configure_mux(typec, port_num, &resp);
> + if (ret)
> + dev_warn(typec->dev, "Configure muxes failed, err = %d\n", ret);
> +
> dev_dbg(typec->dev, "Enabled %d: 0x%hhx\n", port_num, resp.enabled);
> dev_dbg(typec->dev, "Role %d: 0x%hhx\n", port_num, resp.role);
> dev_dbg(typec->dev, "Polarity %d: 0x%hhx\n", port_num, resp.polarity);
> @@ -980,12 +985,7 @@ static int cros_typec_port_update(struct cros_typec_data *typec, int port_num)
> if (typec->typec_cmd_supported)
> cros_typec_handle_status(typec, port_num);
>
> - /* Update the switches if they exist, according to requested state */
> - ret = cros_typec_configure_mux(typec, port_num, &resp);
> - if (ret)
> - dev_warn(typec->dev, "Configure muxes failed, err = %d\n", ret);
> -
> - return ret;
> + return 0;
> }
>
> static int cros_typec_get_cmd_version(struct cros_typec_data *typec)
> --
> 2.35.0.263.gb82422642f-goog
>
>
--
Benson Leung
Staff Software Engineer
Chrome OS Kernel
Google Inc.
bleung@google.com
Chromium OS Project
bleung@chromium.org
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]
^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [PATCH v2 0/4] platform/chrome: cros_ec_typec: Reorganize mux configuration
2022-02-08 18:47 [PATCH v2 0/4] platform/chrome: cros_ec_typec: Reorganize mux configuration Prashant Malani
` (3 preceding siblings ...)
2022-02-08 18:47 ` [PATCH v2 4/4] platform/chrome: cros_ec_typec: Update mux flags during partner removal Prashant Malani
@ 2022-02-15 20:00 ` patchwork-bot+chrome-platform
2022-02-16 22:00 ` patchwork-bot+chrome-platform
5 siblings, 0 replies; 11+ messages in thread
From: patchwork-bot+chrome-platform @ 2022-02-15 20:00 UTC (permalink / raw)
To: Prashant Malani; +Cc: linux-kernel, bleung, chrome-platform, groeck
Hello:
This series was applied to chrome-platform/linux.git (for-kernelci)
by Prashant Malani <pmalani@chromium.org>:
On Tue, 8 Feb 2022 18:47:16 +0000 you wrote:
> This is a short series that reorganizes when mux configuration occurs
> during Type C port updates. The first 2 patches are minor refactors
> which move some of the mux update logic to within
> cros_typec_configure_mux(). The third patch moves
> cros_typec_configure_mux() itself to be earlier in
> cros_typec_port_update().
>
> [...]
Here is the summary with links:
- [v2,1/4] platform/chrome: cros_ec_typec: Move mux flag checks
https://git.kernel.org/chrome-platform/c/53a0023c6450
- [v2,2/4] platform/chrome: cros_ec_typec: Get mux state inside configure_mux
https://git.kernel.org/chrome-platform/c/0d8495dc0321
- [v2,3/4] platform/chrome: cros_ec_typec: Configure muxes at start of port update
https://git.kernel.org/chrome-platform/c/af34f115b3b7
- [v2,4/4] platform/chrome: cros_ec_typec: Update mux flags during partner removal
https://git.kernel.org/chrome-platform/c/b579f139e470
You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html
^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [PATCH v2 0/4] platform/chrome: cros_ec_typec: Reorganize mux configuration
2022-02-08 18:47 [PATCH v2 0/4] platform/chrome: cros_ec_typec: Reorganize mux configuration Prashant Malani
` (4 preceding siblings ...)
2022-02-15 20:00 ` [PATCH v2 0/4] platform/chrome: cros_ec_typec: Reorganize mux configuration patchwork-bot+chrome-platform
@ 2022-02-16 22:00 ` patchwork-bot+chrome-platform
5 siblings, 0 replies; 11+ messages in thread
From: patchwork-bot+chrome-platform @ 2022-02-16 22:00 UTC (permalink / raw)
To: Prashant Malani; +Cc: linux-kernel, bleung, chrome-platform, groeck
Hello:
This series was applied to chrome-platform/linux.git (for-next)
by Prashant Malani <pmalani@chromium.org>:
On Tue, 8 Feb 2022 18:47:16 +0000 you wrote:
> This is a short series that reorganizes when mux configuration occurs
> during Type C port updates. The first 2 patches are minor refactors
> which move some of the mux update logic to within
> cros_typec_configure_mux(). The third patch moves
> cros_typec_configure_mux() itself to be earlier in
> cros_typec_port_update().
>
> [...]
Here is the summary with links:
- [v2,1/4] platform/chrome: cros_ec_typec: Move mux flag checks
https://git.kernel.org/chrome-platform/c/53a0023c6450
- [v2,2/4] platform/chrome: cros_ec_typec: Get mux state inside configure_mux
https://git.kernel.org/chrome-platform/c/0d8495dc0321
- [v2,3/4] platform/chrome: cros_ec_typec: Configure muxes at start of port update
https://git.kernel.org/chrome-platform/c/af34f115b3b7
- [v2,4/4] platform/chrome: cros_ec_typec: Update mux flags during partner removal
https://git.kernel.org/chrome-platform/c/b579f139e470
You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html
^ permalink raw reply [flat|nested] 11+ messages in thread
end of thread, other threads:[~2022-02-16 22:00 UTC | newest]
Thread overview: 11+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-02-08 18:47 [PATCH v2 0/4] platform/chrome: cros_ec_typec: Reorganize mux configuration Prashant Malani
2022-02-08 18:47 ` [PATCH v2 1/4] platform/chrome: cros_ec_typec: Move mux flag checks Prashant Malani
2022-02-09 3:32 ` Tzung-Bi Shih
2022-02-08 18:47 ` [PATCH v2 2/4] platform/chrome: cros_ec_typec: Get mux state inside configure_mux Prashant Malani
2022-02-09 3:32 ` Tzung-Bi Shih
2022-02-08 18:47 ` [PATCH v2 3/4] platform/chrome: cros_ec_typec: Configure muxes at start of port update Prashant Malani
2022-02-15 0:27 ` Benson Leung
2022-02-08 18:47 ` [PATCH v2 4/4] platform/chrome: cros_ec_typec: Update mux flags during partner removal Prashant Malani
2022-02-09 3:32 ` Tzung-Bi Shih
2022-02-15 20:00 ` [PATCH v2 0/4] platform/chrome: cros_ec_typec: Reorganize mux configuration patchwork-bot+chrome-platform
2022-02-16 22:00 ` patchwork-bot+chrome-platform
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).