From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1A49AC433EF for ; Wed, 9 Feb 2022 08:45:27 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234913AbiBIIpU (ORCPT ); Wed, 9 Feb 2022 03:45:20 -0500 Received: from gmail-smtp-in.l.google.com ([23.128.96.19]:43080 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230252AbiBIIpO (ORCPT ); Wed, 9 Feb 2022 03:45:14 -0500 Received: from metis.ext.pengutronix.de (metis.ext.pengutronix.de [IPv6:2001:67c:670:201:290:27ff:fe1d:cc33]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id B8FB4C0DE7D1 for ; Wed, 9 Feb 2022 00:45:08 -0800 (PST) Received: from gallifrey.ext.pengutronix.de ([2001:67c:670:201:5054:ff:fe8d:eefb] helo=bjornoya.blackshift.org) by metis.ext.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1nHiZz-0001J0-Nj; Wed, 09 Feb 2022 09:43:59 +0100 Received: from pengutronix.de (unknown [195.138.59.174]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (P-256) server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) (Authenticated sender: mkl-all@blackshift.org) by smtp.blackshift.org (Postfix) with ESMTPSA id 9F4912EFC8; Wed, 9 Feb 2022 08:43:58 +0000 (UTC) Date: Wed, 9 Feb 2022 09:43:55 +0100 From: Marc Kleine-Budde To: Srinivas Neeli Cc: "wg@grandegger.com" , "davem@davemloft.net" , "kuba@kernel.org" , Michal Simek , "linux-can@vger.kernel.org" , "netdev@vger.kernel.org" , "linux-arm-kernel@lists.infradead.org" , "linux-kernel@vger.kernel.org" , Appana Durga Kedareswara Rao , Srinivas Goud , git Subject: Re: [PATCH] can: xilinx_can: Add check for NAPI Poll function Message-ID: <20220209084355.2q5xjrodusfsudtb@pengutronix.de> References: <20220208162053.39896-1-srinivas.neeli@xilinx.com> <20220209074930.azbn26glrxukg4sr@pengutronix.de> <20220209083155.xma5m7tayy2atyoo@pengutronix.de> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="w3ohdsvc62wrfxhg" Content-Disposition: inline In-Reply-To: X-SA-Exim-Connect-IP: 2001:67c:670:201:5054:ff:fe8d:eefb X-SA-Exim-Mail-From: mkl@pengutronix.de X-SA-Exim-Scanned: No (on metis.ext.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: linux-kernel@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --w3ohdsvc62wrfxhg Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On 09.02.2022 08:40:48, Srinivas Neeli wrote: > Hi Marc, >=20 > > -----Original Message----- > > From: Marc Kleine-Budde > > Sent: Wednesday, February 9, 2022 2:02 PM > > To: Srinivas Neeli > > Cc: wg@grandegger.com; davem@davemloft.net; kuba@kernel.org; Michal > > Simek ; linux-can@vger.kernel.org; > > netdev@vger.kernel.org; linux-arm-kernel@lists.infradead.org; linux- > > kernel@vger.kernel.org; Appana Durga Kedareswara Rao > > ; Srinivas Goud ; git > > > > Subject: Re: [PATCH] can: xilinx_can: Add check for NAPI Poll function > >=20 > > On 09.02.2022 08:29:55, Srinivas Neeli wrote: > > > > On 08.02.2022 21:50:53, Srinivas Neeli wrote: > > > > > Add check for NAPI poll function to avoid enabling interrupts with > > > > > out completing the NAPI call. > > > > > > > > Thanks for the patch. Does this fix a bug? If so, please add a Fixe= s: > > > > tag that lists the patch that introduced that bug. > > > > > > It is not a bug. I am adding additional safety check( Validating the > > > return value of "napi_complete_done" call). > >=20 > > Thanks for your feedback. Should this go into can or can-next? >=20 > If possible please apply on both branches. That's not an option. Going for can-next as Michal Simek suggested. Adding to linux-can-next/testing. Marc --=20 Pengutronix e.K. | Marc Kleine-Budde | Embedded Linux | https://www.pengutronix.de | Vertretung West/Dortmund | Phone: +49-231-2826-924 | Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 | --w3ohdsvc62wrfxhg Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAABCgAdFiEEBsvAIBsPu6mG7thcrX5LkNig010FAmIDfsgACgkQrX5LkNig 011hcwf+LN6j6ou9DxkXTRlfTtRlwD9sWCvC37dmSkKz5N566qP+hDBt38tZadUU mEVeUbwdhqSFM0KP1GEfc6gSixRL7Se4oNYgmavLDsRN1CS4444s+ngfF2SUX9z5 j132Se8fEH3MdTAuA/1YyTBIbXscuGe4xKq36IBwpgFfIzrOtjg8jSawiDtrwWyS xqa7kbWNaRDP6WCDNTvhqi77ZEwKMHdRKoctNA5CSOaQbo1SC5RylZsfJsaoZX8v m+Z0Gn4ZSJdQHZJqPBIZVuBocyuLuiD/elX5cGEfPeXDmMrzrtpzIt1GJvRT+N7h 4tHSiRn/E5vlzS+XtidqLSeo6V6r2Q== =mnTK -----END PGP SIGNATURE----- --w3ohdsvc62wrfxhg--